From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH] Fix buffer overflow issue in app/test/commands.c(we add 1 extra byte for trailing \0). Date: Sat, 05 Mar 2016 23:09:52 +0100 Message-ID: <1495521.iYHtmlEZSL@xps13> References: <1456470671-18425-1-git-send-email-mzhao@luminatewireless.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org To: Ming Zhao Return-path: Received: from mail-wm0-f45.google.com (mail-wm0-f45.google.com [74.125.82.45]) by dpdk.org (Postfix) with ESMTP id 6550C2BFA for ; Sat, 5 Mar 2016 23:11:30 +0100 (CET) Received: by mail-wm0-f45.google.com with SMTP id l68so30261543wml.1 for ; Sat, 05 Mar 2016 14:11:30 -0800 (PST) In-Reply-To: <1456470671-18425-1-git-send-email-mzhao@luminatewireless.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, 2016-02-25 23:11, Ming Zhao: > Fix memleak of cmdline in app/test/test.c It looks to be two different fixes: - an overflow - a memleak Please send 2 patches, with Fixes lines (even if is there since the first commit), with Signed-off-by line. See http://dpdk.org/doc/guides/contributing/patches.html#commit-messages-subject-line