All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Arend Van Spriel <arend.vanspriel@broadcom.com>,
	Sander Eikelenboom <linux@eikelenboom.it>
Cc: linux-wireless <linux-wireless@vger.kernel.org>, netdev@vger.kernel.org
Subject: Re: 4.12-RC2 BUG: scheduling while atomic: irq/47-iwlwifi
Date: Tue, 23 May 2017 09:22:33 +0200	[thread overview]
Message-ID: <1495524153.2464.2.camel@sipsolutions.net> (raw)
In-Reply-To: <09ddb018-7093-2e2a-c84b-148889f7f06d@broadcom.com> (sfid-20170523_091928_491554_FD588B32)

On Tue, 2017-05-23 at 09:19 +0200, Arend Van Spriel wrote:
> 
> > 	WARN_ON_ONCE(!rcu_read_lock_held() && !lockdep_rtnl_is_held());
> 
> Thought about something like this after sending the email. So there
> are two call sites. One for scheduled scan results notification and
> one in scheduled scan stop scenario. So for the latter it is not
> needed to use the rcu_read_lock() as it should have RTNL lock hence
> the two checks above?

Right. The latter can't even really use rcu_read_lock() since it also
wants to modify the list, and that's not sufficient protection for
modifying.

Thanks!

johannes

  reply	other threads:[~2017-05-23  7:22 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-22 10:36 4.12-RC2 BUG: scheduling while atomic: irq/47-iwlwifi Sander Eikelenboom
2017-05-22 10:36 ` Sander Eikelenboom
2017-05-22 10:57 ` Johannes Berg
2017-05-22 10:57   ` Johannes Berg
2017-05-22 12:09   ` Arend van Spriel
2017-05-22 21:02     ` Arend Van Spriel
2017-05-22 21:02       ` Arend Van Spriel
2017-05-22 21:04       ` Johannes Berg
2017-05-23  7:19         ` Arend Van Spriel
2017-05-23  7:22           ` Johannes Berg [this message]
2017-05-23  7:24             ` Arend Van Spriel
2017-05-23  7:24               ` Arend Van Spriel
2017-05-23 17:51       ` Sander Eikelenboom

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1495524153.2464.2.camel@sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=arend.vanspriel@broadcom.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linux@eikelenboom.it \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.