Re: [Qemu-devel] [PATCH 1/1] Improve Cocoa modifier key handling

[Gerd Hoffmann <kraxel@redhat.com>]

  Hi,

> looked at the keyCode to determine what modifier key changed. This
> usually works fine but sometimes the keyCode is 0 and the app should
> instead be looking at the modifierFlags bitmask. Key code 0 is the
> 'a'
> key.
> 
> I added code that handles keyCode == 0 differently. It checks the
> modifierFlags and if they differ from QEMU's idea of which modifier
> keys are currently pressed it toggles those changed keys.

Sounds like this happens in case there is a modifier state change
without linked key event, such as state change while qemu did not have
the keyboard focus.  Nice that macos sends notifications in that case.

I'm wondering whenever we should just use modifierFlags all the time.

cheers,
  Gerd