From: <gregkh@linuxfoundation.org>
To: johan@kernel.org, gregkh@linuxfoundation.org, zaitcev@yahoo.com
Cc: <stable@vger.kernel.org>, <stable-commits@vger.kernel.org>
Subject: Patch "USB: serial: mct_u232: fix big-endian baud-rate handling" has been added to the 4.4-stable tree
Date: Tue, 23 May 2017 14:42:16 +0200 [thread overview]
Message-ID: <1495543336113197@kroah.com> (raw)
This is a note to let you know that I've just added the patch titled
USB: serial: mct_u232: fix big-endian baud-rate handling
to the 4.4-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
usb-serial-mct_u232-fix-big-endian-baud-rate-handling.patch
and it can be found in the queue-4.4 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@vger.kernel.org> know about it.
>From 26cede343656c0bc2c33cdc783771282405c7fb2 Mon Sep 17 00:00:00 2001
From: Johan Hovold <johan@kernel.org>
Date: Thu, 11 May 2017 11:41:20 +0200
Subject: USB: serial: mct_u232: fix big-endian baud-rate handling
From: Johan Hovold <johan@kernel.org>
commit 26cede343656c0bc2c33cdc783771282405c7fb2 upstream.
Drop erroneous cpu_to_le32 when setting the baud rate, something which
corrupted the divisor on big-endian hosts.
Found using sparse:
warning: incorrect type in argument 1 (different base types)
expected unsigned int [unsigned] [usertype] val
got restricted __le32 [usertype] <noident>
Fixes: af2ac1a091bc ("USB: serial mct_usb232: move DMA buffers to heap")
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Acked-By: Pete Zaitcev <zaitcev@yahoo.com>
Signed-off-by: Johan Hovold <johan@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
drivers/usb/serial/mct_u232.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/usb/serial/mct_u232.c
+++ b/drivers/usb/serial/mct_u232.c
@@ -189,7 +189,7 @@ static int mct_u232_set_baud_rate(struct
return -ENOMEM;
divisor = mct_u232_calculate_baud_rate(serial, value, &speed);
- put_unaligned_le32(cpu_to_le32(divisor), buf);
+ put_unaligned_le32(divisor, buf);
rc = usb_control_msg(serial->dev, usb_sndctrlpipe(serial->dev, 0),
MCT_U232_SET_BAUD_RATE_REQUEST,
MCT_U232_SET_REQUEST_TYPE,
Patches currently in stable-queue which might be from johan@kernel.org are
queue-4.4/usb-serial-io_ti-fix-div-by-zero-in-set_termios.patch
queue-4.4/usb-hub-fix-non-ss-hub-descriptor-handling.patch
queue-4.4/usb-serial-ftdi_sio-add-olimex-arm-usb-tiny-h-pids.patch
queue-4.4/usb-serial-ftdi_sio-fix-setting-latency-for-unprivileged-users.patch
queue-4.4/usb-iowarrior-fix-info-ioctl-on-big-endian-hosts.patch
queue-4.4/watchdog-pcwd_usb-fix-null-deref-at-probe.patch
queue-4.4/usb-serial-qcserial-add-more-lenovo-em74xx-device-ids.patch
queue-4.4/usb-serial-option-add-telit-me910-support.patch
queue-4.4/net-irda-irda-usb-fix-firmware-name-on-big-endian-hosts.patch
queue-4.4/usbvision-fix-null-deref-at-probe.patch
queue-4.4/usb-serial-mct_u232-fix-big-endian-baud-rate-handling.patch
queue-4.4/usb-ehci-platform-fix-companion-device-leak.patch
queue-4.4/mceusb-fix-null-deref-at-probe.patch
queue-4.4/usb-hub-fix-ss-hub-descriptor-handling.patch
queue-4.4/ath9k_htc-fix-null-deref-at-probe.patch
reply other threads:[~2017-05-23 12:43 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1495543336113197@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=johan@kernel.org \
--cc=stable-commits@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=zaitcev@yahoo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.