From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 1259C21A16E5F for ; Tue, 23 May 2017 06:11:44 -0700 (PDT) Message-ID: <1495545099.6967.81.camel@linux.intel.com> Subject: Re: [PATCH 10/23] afs: switch to use uuid_t and uuid_gen From: Andy Shevchenko Date: Tue, 23 May 2017 16:11:39 +0300 In-Reply-To: <20170523084956.GB20121@lst.de> References: <20170518062705.25902-1-hch@lst.de> <20170518062705.25902-11-hch@lst.de> <1495478957.6967.69.camel@linux.intel.com> <20170523084956.GB20121@lst.de> Mime-Version: 1.0 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: linux-nvdimm-bounces@lists.01.org Sender: "Linux-nvdimm" To: Christoph Hellwig Cc: linux-xfs@vger.kernel.org, linux-raid@vger.kernel.org, linux-nvdimm@lists.01.org, Mimi Zohar , Amir Goldstein , linux-kernel@vger.kernel.org, David Howells , linux-fsdevel@vger.kernel.org, Shaohua Li , Steven Whitehouse List-ID: T24gVHVlLCAyMDE3LTA1LTIzIGF0IDEwOjQ5ICswMjAwLCBDaHJpc3RvcGggSGVsbHdpZyB3cm90 ZToKPiBPbiBNb24sIE1heSAyMiwgMjAxNyBhdCAwOTo0OToxN1BNICswMzAwLCBBbmR5IFNoZXZj aGVua28gd3JvdGU6Cj4gPiA+IMKgCXN0cnVjdCBhZnNfY2FsbCAqY2FsbCA9IGNvbnRhaW5lcl9v Zih3b3JrLCBzdHJ1Y3QKPiA+ID4gYWZzX2NhbGwsCj4gPiA+IHdvcmspOwo+ID4gPiAtCXN0cnVj dCB1dWlkX3YxICpyID0gY2FsbC0+cmVxdWVzdDsKPiA+ID4gKwl1dWlkX3QgKnIgPSBjYWxsLT5y ZXF1ZXN0Owo+ID4gPiDCoAo+ID4gPiDCoAlzdHJ1Y3Qgewo+ID4gPiDCoAkJX19iZTMyCW1hdGNo Owo+ID4gPiAKPiA+IAo+ID4gSnVzdCB0byBkb3VibGUgY2hlY2sgdGhhdCB0aGlzIGRvZXNuJ3Qg Y3JlYXRlIGEgdW5pb24gYWxpYXNpbmcuCj4gCj4gV2hhdCBkbyB5b3UgbWVhbiB3aXRoIHRoYXQ/ CgpTaW5jZSB3ZSBpbnRyb2R1Y2VkIGEgdW5pb24gaXQncyBwb3NzaWJsZSB0aGF0IHdlIG1pZ2h0 IGFjY2VzcyB0aGUKbWVtYmVyIHdoaWNoIHdhc24ndCBsYXN0IG1vZGlmaWVkIG9uZS4gU28sIG15 IGNvbW1lbnQgaXMgdG8gZ2l2ZSBhbgphdHRlbnRpb24gb24gc3VjaCBwb3NzaWJpbGl0eSBhbmQg YXZvaWQgaWYgdGhlcmUgaXMgYW4gYWxpYXNpbmcKaGFwcGVuZWQuCgotLSAKQW5keSBTaGV2Y2hl bmtvIDxhbmRyaXkuc2hldmNoZW5rb0BsaW51eC5pbnRlbC5jb20+CkludGVsIEZpbmxhbmQgT3kK X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KTGludXgtbnZk aW1tIG1haWxpbmcgbGlzdApMaW51eC1udmRpbW1AbGlzdHMuMDEub3JnCmh0dHBzOi8vbGlzdHMu MDEub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtbnZkaW1tCg== From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andy Shevchenko Subject: Re: [PATCH 10/23] afs: switch to use uuid_t and uuid_gen Date: Tue, 23 May 2017 16:11:39 +0300 Message-ID: <1495545099.6967.81.camel@linux.intel.com> References: <20170518062705.25902-1-hch@lst.de> <20170518062705.25902-11-hch@lst.de> <1495478957.6967.69.camel@linux.intel.com> <20170523084956.GB20121@lst.de> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20170523084956.GB20121-jcswGhMUV9g@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linux-nvdimm-bounces-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org Sender: "Linux-nvdimm" To: Christoph Hellwig Cc: linux-xfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-raid-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-nvdimm-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org, Mimi Zohar , Amir Goldstein , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, David Howells , linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Shaohua Li , Steven Whitehouse List-Id: linux-raid.ids T24gVHVlLCAyMDE3LTA1LTIzIGF0IDEwOjQ5ICswMjAwLCBDaHJpc3RvcGggSGVsbHdpZyB3cm90 ZToKPiBPbiBNb24sIE1heSAyMiwgMjAxNyBhdCAwOTo0OToxN1BNICswMzAwLCBBbmR5IFNoZXZj aGVua28gd3JvdGU6Cj4gPiA+IMKgCXN0cnVjdCBhZnNfY2FsbCAqY2FsbCA9IGNvbnRhaW5lcl9v Zih3b3JrLCBzdHJ1Y3QKPiA+ID4gYWZzX2NhbGwsCj4gPiA+IHdvcmspOwo+ID4gPiAtCXN0cnVj dCB1dWlkX3YxICpyID0gY2FsbC0+cmVxdWVzdDsKPiA+ID4gKwl1dWlkX3QgKnIgPSBjYWxsLT5y ZXF1ZXN0Owo+ID4gPiDCoAo+ID4gPiDCoAlzdHJ1Y3Qgewo+ID4gPiDCoAkJX19iZTMyCW1hdGNo Owo+ID4gPiAKPiA+IAo+ID4gSnVzdCB0byBkb3VibGUgY2hlY2sgdGhhdCB0aGlzIGRvZXNuJ3Qg Y3JlYXRlIGEgdW5pb24gYWxpYXNpbmcuCj4gCj4gV2hhdCBkbyB5b3UgbWVhbiB3aXRoIHRoYXQ/ CgpTaW5jZSB3ZSBpbnRyb2R1Y2VkIGEgdW5pb24gaXQncyBwb3NzaWJsZSB0aGF0IHdlIG1pZ2h0 IGFjY2VzcyB0aGUKbWVtYmVyIHdoaWNoIHdhc24ndCBsYXN0IG1vZGlmaWVkIG9uZS4gU28sIG15 IGNvbW1lbnQgaXMgdG8gZ2l2ZSBhbgphdHRlbnRpb24gb24gc3VjaCBwb3NzaWJpbGl0eSBhbmQg YXZvaWQgaWYgdGhlcmUgaXMgYW4gYWxpYXNpbmcKaGFwcGVuZWQuCgotLSAKQW5keSBTaGV2Y2hl bmtvIDxhbmRyaXkuc2hldmNoZW5rb0BsaW51eC5pbnRlbC5jb20+CkludGVsIEZpbmxhbmQgT3kK X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KTGludXgtbnZk aW1tIG1haWxpbmcgbGlzdApMaW51eC1udmRpbW1AbGlzdHMuMDEub3JnCmh0dHBzOi8vbGlzdHMu MDEub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtbnZkaW1tCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com ([134.134.136.31]:36843 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1763155AbdEWNLp (ORCPT ); Tue, 23 May 2017 09:11:45 -0400 Message-ID: <1495545099.6967.81.camel@linux.intel.com> Subject: Re: [PATCH 10/23] afs: switch to use uuid_t and uuid_gen From: Andy Shevchenko Date: Tue, 23 May 2017 16:11:39 +0300 In-Reply-To: <20170523084956.GB20121@lst.de> References: <20170518062705.25902-1-hch@lst.de> <20170518062705.25902-11-hch@lst.de> <1495478957.6967.69.camel@linux.intel.com> <20170523084956.GB20121@lst.de> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-xfs-owner@vger.kernel.org List-ID: List-Id: xfs To: Christoph Hellwig Cc: Amir Goldstein , linux-fsdevel@vger.kernel.org, Shaohua Li , Dan Williams , David Howells , Steven Whitehouse , Mimi Zohar , linux-xfs@vger.kernel.org, linux-raid@vger.kernel.org, linux-nvdimm@lists.01.org, linux-kernel@vger.kernel.org On Tue, 2017-05-23 at 10:49 +0200, Christoph Hellwig wrote: > On Mon, May 22, 2017 at 09:49:17PM +0300, Andy Shevchenko wrote: > > >   struct afs_call *call = container_of(work, struct > > > afs_call, > > > work); > > > - struct uuid_v1 *r = call->request; > > > + uuid_t *r = call->request; > > >   > > >   struct { > > >   __be32 match; > > > > > > > Just to double check that this doesn't create a union aliasing. > > What do you mean with that? Since we introduced a union it's possible that we might access the member which wasn't last modified one. So, my comment is to give an attention on such possibility and avoid if there is an aliasing happened. -- Andy Shevchenko Intel Finland Oy From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1764031AbdEWNLs (ORCPT ); Tue, 23 May 2017 09:11:48 -0400 Received: from mga06.intel.com ([134.134.136.31]:36843 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1763155AbdEWNLp (ORCPT ); Tue, 23 May 2017 09:11:45 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.38,382,1491289200"; d="scan'208";a="1173205499" Message-ID: <1495545099.6967.81.camel@linux.intel.com> Subject: Re: [PATCH 10/23] afs: switch to use uuid_t and uuid_gen From: Andy Shevchenko To: Christoph Hellwig Cc: Amir Goldstein , linux-fsdevel@vger.kernel.org, Shaohua Li , Dan Williams , David Howells , Steven Whitehouse , Mimi Zohar , linux-xfs@vger.kernel.org, linux-raid@vger.kernel.org, linux-nvdimm@ml01.01.org, linux-kernel@vger.kernel.org Date: Tue, 23 May 2017 16:11:39 +0300 In-Reply-To: <20170523084956.GB20121@lst.de> References: <20170518062705.25902-1-hch@lst.de> <20170518062705.25902-11-hch@lst.de> <1495478957.6967.69.camel@linux.intel.com> <20170523084956.GB20121@lst.de> Organization: Intel Finland Oy Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.22.6-1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2017-05-23 at 10:49 +0200, Christoph Hellwig wrote: > On Mon, May 22, 2017 at 09:49:17PM +0300, Andy Shevchenko wrote: > > >   struct afs_call *call = container_of(work, struct > > > afs_call, > > > work); > > > - struct uuid_v1 *r = call->request; > > > + uuid_t *r = call->request; > > >   > > >   struct { > > >   __be32 match; > > > > > > > Just to double check that this doesn't create a union aliasing. > > What do you mean with that? Since we introduced a union it's possible that we might access the member which wasn't last modified one. So, my comment is to give an attention on such possibility and avoid if there is an aliasing happened. -- Andy Shevchenko Intel Finland Oy