From: Trond Myklebust <trondmy@primarydata.com>
To: "Anna.Schumaker@Netapp.com" <Anna.Schumaker@Netapp.com>,
"xiaolong.ye@intel.com" <xiaolong.ye@intel.com>
Cc: "torvalds@linux-foundation.org" <torvalds@linux-foundation.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"lkp@01.org" <lkp@01.org>,
"linux-nfs@vger.kernel.org" <linux-nfs@vger.kernel.org>
Subject: Re: [lkp-robot] [NFS] 14d1bbb0ca: BUG:scheduling_while_atomic
Date: Wed, 24 May 2017 11:44:27 +0000 [thread overview]
Message-ID: <1495626265.8735.2.camel@primarydata.com> (raw)
In-Reply-To: <20170524023629.GK1795@yexl-desktop>
T24gV2VkLCAyMDE3LTA1LTI0IGF0IDEwOjM2ICswODAwLCBrZXJuZWwgdGVzdCByb2JvdCB3cm90
ZToNCj4gRllJLCB3ZSBub3RpY2VkIHRoZSBmb2xsb3dpbmcgY29tbWl0Og0KPiANCj4gY29tbWl0
OiAxNGQxYmJiMGNhNDI1YzRmZGQ5YTM4ZWFhYzM0NmMwMjg2NjFiNzUyICgiTkZTOiBDcmVhdGUg
YQ0KPiBjb21tb24gbmZzNF9tYXRjaF9jbGllbnQoKSBmdW5jdGlvbiIpDQo+IGh0dHBzOi8vZ2l0
Lmtlcm5lbC5vcmcvY2dpdC9saW51eC9rZXJuZWwvZ2l0L3RvcnZhbGRzL2xpbnV4LmdpdA0KPiBt
YXN0ZXINCj4gDQo+IGluIHRlc3RjYXNlOiBib290DQo+IA0KPiBvbiB0ZXN0IG1hY2hpbmU6IHFl
bXUtc3lzdGVtLXg4Nl82NCAtZW5hYmxlLWt2bSAtY3B1IGhvc3QgLXNtcCAyIC1tDQo+IDRHDQo+
IA0KPiBjYXVzZWQgYmVsb3cgY2hhbmdlcyAocGxlYXNlIHJlZmVyIHRvIGF0dGFjaGVkIGRtZXNn
L2ttc2cgZm9yIGVudGlyZQ0KPiBsb2cvYmFja3RyYWNlKToNCj4gDQo+IA0KPiArLS0tLS0tLS0t
LS0tLS0tLS0tLS0tLS0tLS0tLS0tLSstLS0tLS0tLS0tLS0rLS0tLS0tLS0tLS0tKw0KPiA+IMKg
wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC
oHwgNWI2ZDNmZjYwNSB8IDE0ZDFiYmIwY2EgfA0KPiANCj4gKy0tLS0tLS0tLS0tLS0tLS0tLS0t
LS0tLS0tLS0tLS0rLS0tLS0tLS0tLS0tKy0tLS0tLS0tLS0tLSsNCj4gPiBib290X3N1Y2Nlc3Nl
c8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgfCA0NjnCoMKgwqDCoMKgwqDCoMKgfCA0
NzDCoMKgwqDCoMKgwqDCoMKgfA0KPiA+IGJvb3RfZmFpbHVyZXPCoMKgwqDCoMKgwqDCoMKgwqDC
oMKgwqDCoMKgwqDCoMKgfCAwwqDCoMKgwqDCoMKgwqDCoMKgwqB8IDMxwqDCoMKgwqDCoMKgwqDC
oMKgfA0KPiA+IEJVRzpzY2hlZHVsaW5nX3doaWxlX2F0b21pY8KgwqDCoHwgMMKgwqDCoMKgwqDC
oMKgwqDCoMKgfCAzMcKgwqDCoMKgwqDCoMKgwqDCoHwNCj4gPiBCVUc6c3BpbmxvY2tfcmVjdXJz
aW9uX29uX0NQVSB8IDDCoMKgwqDCoMKgwqDCoMKgwqDCoHwgMzDCoMKgwqDCoMKgwqDCoMKgwqB8
DQo+IA0KPiArLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLSstLS0tLS0tLS0tLS0rLS0t
LS0tLS0tLS0tKw0KPiANCj4gDQo+IA0KPiBbwqDCoDI5OS4xNTg5OTFdIEJVRzogc2NoZWR1bGlu
ZyB3aGlsZSBhdG9taWM6DQo+IG1vdW50Lm5mcy85Mzg3LzB4MDAwMDAwMDINCj4gW8KgwqAyOTku
MTY5NTg3XSAyIGxvY2tzIGhlbGQgYnkgbW91bnQubmZzLzkzODc6DQo+IFvCoMKgMjk5LjE3NjE2
NV3CoMKgIzA6wqDCoChuZnNfY2xpZF9pbml0X211dGV4KXsuLi4uLi59LCBhdDoNCj4gWzxmZmZm
ZmZmZjgxMzBjYzkyPl0gbmZzNF9kaXNjb3Zlcl9zZXJ2ZXJfdHJ1bmtpbmcrMHg0Ny8weDFmYw0K
PiBbwqDCoDI5OS4yMDE4MDJdwqDCoCMxOsKgwqAoJigmbm4tPm5mc19jbGllbnRfbG9jayktPnJs
b2NrKXsuLi4uLi59LCBhdDoNCj4gWzxmZmZmZmZmZjgxMzEyNWZhPl0gbmZzNDBfd2Fsa19jbGll
bnRfbGlzdCsweDJlOS8weDMzOA0KPiANCg0KT29wcy4gQW5uYSwgaXQgbG9va3MgYXMgaWYgdGhh
dCBwYXRjaCBhZGRzIGFuIGluY29ycmVjdCBjYWxsIHRvDQoic3Bpbl9sb2NrKCZubi0+bmZzX2Ns
aWVudF9sb2NrKSIgZm9yIHRoZSAiZGVmYXVsdDoiIGNhc2Ugd2hlbg0KcHJvY2Vzc2luZyB0aGUg
cmVzdWx0IGZyb20gdGhlIFNFVENMSUVOVElEX0NPTkZJUk0gY2FsbC4gSSBjYW4gc2VuZCBhDQpm
aXguDQoNClRoYW5rcyBYaWFvbG9uZyENCg0KQ2hlZXJzDQogIFRyb25kDQoNCi0tIA0KVHJvbmQg
TXlrbGVidXN0DQpMaW51eCBORlMgY2xpZW50IG1haW50YWluZXIsIFByaW1hcnlEYXRhDQp0cm9u
ZC5teWtsZWJ1c3RAcHJpbWFyeWRhdGEuY29tDQo=
WARNING: multiple messages have this Message-ID (diff)
From: Trond Myklebust <trondmy@primarydata.com>
To: lkp@lists.01.org
Subject: Re: [lkp-robot] [NFS] 14d1bbb0ca: BUG:scheduling_while_atomic
Date: Wed, 24 May 2017 11:44:27 +0000 [thread overview]
Message-ID: <1495626265.8735.2.camel@primarydata.com> (raw)
In-Reply-To: <20170524023629.GK1795@yexl-desktop>
[-- Attachment #1: Type: text/plain, Size: 1912 bytes --]
On Wed, 2017-05-24 at 10:36 +0800, kernel test robot wrote:
> FYI, we noticed the following commit:
>
> commit: 14d1bbb0ca425c4fdd9a38eaac346c028661b752 ("NFS: Create a
> common nfs4_match_client() function")
> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git
> master
>
> in testcase: boot
>
> on test machine: qemu-system-x86_64 -enable-kvm -cpu host -smp 2 -m
> 4G
>
> caused below changes (please refer to attached dmesg/kmsg for entire
> log/backtrace):
>
>
> +-------------------------------+------------+------------+
> > | 5b6d3ff605 | 14d1bbb0ca |
>
> +-------------------------------+------------+------------+
> > boot_successes | 469 | 470 |
> > boot_failures | 0 | 31 |
> > BUG:scheduling_while_atomic | 0 | 31 |
> > BUG:spinlock_recursion_on_CPU | 0 | 30 |
>
> +-------------------------------+------------+------------+
>
>
>
> [ 299.158991] BUG: scheduling while atomic:
> mount.nfs/9387/0x00000002
> [ 299.169587] 2 locks held by mount.nfs/9387:
> [ 299.176165] #0: (nfs_clid_init_mutex){......}, at:
> [<ffffffff8130cc92>] nfs4_discover_server_trunking+0x47/0x1fc
> [ 299.201802] #1: (&(&nn->nfs_client_lock)->rlock){......}, at:
> [<ffffffff813125fa>] nfs40_walk_client_list+0x2e9/0x338
>
Oops. Anna, it looks as if that patch adds an incorrect call to
"spin_lock(&nn->nfs_client_lock)" for the "default:" case when
processing the result from the SETCLIENTID_CONFIRM call. I can send a
fix.
Thanks Xiaolong!
Cheers
Trond
--
Trond Myklebust
Linux NFS client maintainer, PrimaryData
trond.myklebust(a)primarydata.com
WARNING: multiple messages have this Message-ID (diff)
From: Trond Myklebust <trondmy@primarydata.com>
To: "Anna.Schumaker@Netapp.com" <Anna.Schumaker@Netapp.com>,
"xiaolong.ye@intel.com" <xiaolong.ye@intel.com>
Cc: "torvalds@linux-foundation.org" <torvalds@linux-foundation.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"lkp@01.org" <lkp@01.org>,
"linux-nfs@vger.kernel.org" <linux-nfs@vger.kernel.org>
Subject: Re: [lkp-robot] [NFS] 14d1bbb0ca: BUG:scheduling_while_atomic
Date: Wed, 24 May 2017 11:44:27 +0000 [thread overview]
Message-ID: <1495626265.8735.2.camel@primarydata.com> (raw)
In-Reply-To: <20170524023629.GK1795@yexl-desktop>
On Wed, 2017-05-24 at 10:36 +0800, kernel test robot wrote:
> FYI, we noticed the following commit:
>
> commit: 14d1bbb0ca425c4fdd9a38eaac346c028661b752 ("NFS: Create a
> common nfs4_match_client() function")
> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git
> master
>
> in testcase: boot
>
> on test machine: qemu-system-x86_64 -enable-kvm -cpu host -smp 2 -m
> 4G
>
> caused below changes (please refer to attached dmesg/kmsg for entire
> log/backtrace):
>
>
> +-------------------------------+------------+------------+
> > | 5b6d3ff605 | 14d1bbb0ca |
>
> +-------------------------------+------------+------------+
> > boot_successes | 469 | 470 |
> > boot_failures | 0 | 31 |
> > BUG:scheduling_while_atomic | 0 | 31 |
> > BUG:spinlock_recursion_on_CPU | 0 | 30 |
>
> +-------------------------------+------------+------------+
>
>
>
> [ 299.158991] BUG: scheduling while atomic:
> mount.nfs/9387/0x00000002
> [ 299.169587] 2 locks held by mount.nfs/9387:
> [ 299.176165] #0: (nfs_clid_init_mutex){......}, at:
> [<ffffffff8130cc92>] nfs4_discover_server_trunking+0x47/0x1fc
> [ 299.201802] #1: (&(&nn->nfs_client_lock)->rlock){......}, at:
> [<ffffffff813125fa>] nfs40_walk_client_list+0x2e9/0x338
>
Oops. Anna, it looks as if that patch adds an incorrect call to
"spin_lock(&nn->nfs_client_lock)" for the "default:" case when
processing the result from the SETCLIENTID_CONFIRM call. I can send a
fix.
Thanks Xiaolong!
Cheers
Trond
--
Trond Myklebust
Linux NFS client maintainer, PrimaryData
trond.myklebust@primarydata.com
next prev parent reply other threads:[~2017-05-24 11:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-24 2:36 [lkp-robot] [NFS] 14d1bbb0ca: BUG:scheduling_while_atomic kernel test robot
2017-05-24 2:36 ` kernel test robot
2017-05-24 11:44 ` Trond Myklebust [this message]
2017-05-24 11:44 ` Trond Myklebust
2017-05-24 11:44 ` Trond Myklebust
2017-05-24 12:09 ` [PATCH] NFSv4.0: Fix a lock leak in nfs40_walk_client_list Trond Myklebust
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1495626265.8735.2.camel@primarydata.com \
--to=trondmy@primarydata.com \
--cc=Anna.Schumaker@Netapp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=lkp@01.org \
--cc=torvalds@linux-foundation.org \
--cc=xiaolong.ye@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.