From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-194.mimecast.com ([63.128.21.194]:44769 "EHLO us-smtp-delivery-194.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965590AbdEXLog (ORCPT ); Wed, 24 May 2017 07:44:36 -0400 From: Trond Myklebust To: "Anna.Schumaker@Netapp.com" , "xiaolong.ye@intel.com" CC: "torvalds@linux-foundation.org" , "linux-kernel@vger.kernel.org" , "lkp@01.org" , "linux-nfs@vger.kernel.org" Subject: Re: [lkp-robot] [NFS] 14d1bbb0ca: BUG:scheduling_while_atomic Date: Wed, 24 May 2017 11:44:27 +0000 Message-ID: <1495626265.8735.2.camel@primarydata.com> References: <20170524023629.GK1795@yexl-desktop> In-Reply-To: <20170524023629.GK1795@yexl-desktop> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Sender: linux-nfs-owner@vger.kernel.org List-ID: T24gV2VkLCAyMDE3LTA1LTI0IGF0IDEwOjM2ICswODAwLCBrZXJuZWwgdGVzdCByb2JvdCB3cm90 ZToNCj4gRllJLCB3ZSBub3RpY2VkIHRoZSBmb2xsb3dpbmcgY29tbWl0Og0KPiANCj4gY29tbWl0 OiAxNGQxYmJiMGNhNDI1YzRmZGQ5YTM4ZWFhYzM0NmMwMjg2NjFiNzUyICgiTkZTOiBDcmVhdGUg YQ0KPiBjb21tb24gbmZzNF9tYXRjaF9jbGllbnQoKSBmdW5jdGlvbiIpDQo+IGh0dHBzOi8vZ2l0 Lmtlcm5lbC5vcmcvY2dpdC9saW51eC9rZXJuZWwvZ2l0L3RvcnZhbGRzL2xpbnV4LmdpdA0KPiBt YXN0ZXINCj4gDQo+IGluIHRlc3RjYXNlOiBib290DQo+IA0KPiBvbiB0ZXN0IG1hY2hpbmU6IHFl bXUtc3lzdGVtLXg4Nl82NCAtZW5hYmxlLWt2bSAtY3B1IGhvc3QgLXNtcCAyIC1tDQo+IDRHDQo+ IA0KPiBjYXVzZWQgYmVsb3cgY2hhbmdlcyAocGxlYXNlIHJlZmVyIHRvIGF0dGFjaGVkIGRtZXNn L2ttc2cgZm9yIGVudGlyZQ0KPiBsb2cvYmFja3RyYWNlKToNCj4gDQo+IA0KPiArLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLSstLS0tLS0tLS0tLS0rLS0tLS0tLS0tLS0tKw0KPiA+IMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oHwgNWI2ZDNmZjYwNSB8IDE0ZDFiYmIwY2EgfA0KPiANCj4gKy0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0rLS0tLS0tLS0tLS0tKy0tLS0tLS0tLS0tLSsNCj4gPiBib290X3N1Y2Nlc3Nl c8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgfCA0NjnCoMKgwqDCoMKgwqDCoMKgfCA0 NzDCoMKgwqDCoMKgwqDCoMKgfA0KPiA+IGJvb3RfZmFpbHVyZXPCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgfCAwwqDCoMKgwqDCoMKgwqDCoMKgwqB8IDMxwqDCoMKgwqDCoMKgwqDC oMKgfA0KPiA+IEJVRzpzY2hlZHVsaW5nX3doaWxlX2F0b21pY8KgwqDCoHwgMMKgwqDCoMKgwqDC oMKgwqDCoMKgfCAzMcKgwqDCoMKgwqDCoMKgwqDCoHwNCj4gPiBCVUc6c3BpbmxvY2tfcmVjdXJz aW9uX29uX0NQVSB8IDDCoMKgwqDCoMKgwqDCoMKgwqDCoHwgMzDCoMKgwqDCoMKgwqDCoMKgwqB8 DQo+IA0KPiArLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLSstLS0tLS0tLS0tLS0rLS0t LS0tLS0tLS0tKw0KPiANCj4gDQo+IA0KPiBbwqDCoDI5OS4xNTg5OTFdIEJVRzogc2NoZWR1bGlu ZyB3aGlsZSBhdG9taWM6DQo+IG1vdW50Lm5mcy85Mzg3LzB4MDAwMDAwMDINCj4gW8KgwqAyOTku MTY5NTg3XSAyIGxvY2tzIGhlbGQgYnkgbW91bnQubmZzLzkzODc6DQo+IFvCoMKgMjk5LjE3NjE2 NV3CoMKgIzA6wqDCoChuZnNfY2xpZF9pbml0X211dGV4KXsuLi4uLi59LCBhdDoNCj4gWzxmZmZm ZmZmZjgxMzBjYzkyPl0gbmZzNF9kaXNjb3Zlcl9zZXJ2ZXJfdHJ1bmtpbmcrMHg0Ny8weDFmYw0K PiBbwqDCoDI5OS4yMDE4MDJdwqDCoCMxOsKgwqAoJigmbm4tPm5mc19jbGllbnRfbG9jayktPnJs b2NrKXsuLi4uLi59LCBhdDoNCj4gWzxmZmZmZmZmZjgxMzEyNWZhPl0gbmZzNDBfd2Fsa19jbGll bnRfbGlzdCsweDJlOS8weDMzOA0KPiANCg0KT29wcy4gQW5uYSwgaXQgbG9va3MgYXMgaWYgdGhh dCBwYXRjaCBhZGRzIGFuIGluY29ycmVjdCBjYWxsIHRvDQoic3Bpbl9sb2NrKCZubi0+bmZzX2Ns aWVudF9sb2NrKSIgZm9yIHRoZSAiZGVmYXVsdDoiIGNhc2Ugd2hlbg0KcHJvY2Vzc2luZyB0aGUg cmVzdWx0IGZyb20gdGhlIFNFVENMSUVOVElEX0NPTkZJUk0gY2FsbC4gSSBjYW4gc2VuZCBhDQpm aXguDQoNClRoYW5rcyBYaWFvbG9uZyENCg0KQ2hlZXJzDQogIFRyb25kDQoNCi0tIA0KVHJvbmQg TXlrbGVidXN0DQpMaW51eCBORlMgY2xpZW50IG1haW50YWluZXIsIFByaW1hcnlEYXRhDQp0cm9u ZC5teWtsZWJ1c3RAcHJpbWFyeWRhdGEuY29tDQo= From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============5384788270280961380==" MIME-Version: 1.0 From: Trond Myklebust To: lkp@lists.01.org Subject: Re: [lkp-robot] [NFS] 14d1bbb0ca: BUG:scheduling_while_atomic Date: Wed, 24 May 2017 11:44:27 +0000 Message-ID: <1495626265.8735.2.camel@primarydata.com> In-Reply-To: <20170524023629.GK1795@yexl-desktop> List-Id: --===============5384788270280961380== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable On Wed, 2017-05-24 at 10:36 +0800, kernel test robot wrote: > FYI, we noticed the following commit: > = > commit: 14d1bbb0ca425c4fdd9a38eaac346c028661b752 ("NFS: Create a > common nfs4_match_client() function") > https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git > master > = > in testcase: boot > = > on test machine: qemu-system-x86_64 -enable-kvm -cpu host -smp 2 -m > 4G > = > caused below changes (please refer to attached dmesg/kmsg for entire > log/backtrace): > = > = > +-------------------------------+------------+------------+ > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0| 5b6d3ff605 | 14d1bbb0ca | > = > +-------------------------------+------------+------------+ > > boot_successes=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0| 469=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0| 470=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0| > > boot_failures=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0| 0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0| 31=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0| > > BUG:scheduling_while_atomic=C2=A0=C2=A0=C2=A0| 0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0| 31=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0| > > BUG:spinlock_recursion_on_CPU | 0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0| 30=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0| > = > +-------------------------------+------------+------------+ > = > = > = > [=C2=A0=C2=A0299.158991] BUG: scheduling while atomic: > mount.nfs/9387/0x00000002 > [=C2=A0=C2=A0299.169587] 2 locks held by mount.nfs/9387: > [=C2=A0=C2=A0299.176165]=C2=A0=C2=A0#0:=C2=A0=C2=A0(nfs_clid_init_mutex){= ......}, at: > [] nfs4_discover_server_trunking+0x47/0x1fc > [=C2=A0=C2=A0299.201802]=C2=A0=C2=A0#1:=C2=A0=C2=A0(&(&nn->nfs_client_loc= k)->rlock){......}, at: > [] nfs40_walk_client_list+0x2e9/0x338 > = Oops. Anna, it looks as if that patch adds an incorrect call to "spin_lock(&nn->nfs_client_lock)" for the "default:" case when processing the result from the SETCLIENTID_CONFIRM call. I can send a fix. Thanks Xiaolong! Cheers Trond -- = Trond Myklebust Linux NFS client maintainer, PrimaryData trond.myklebust(a)primarydata.com --===============5384788270280961380==-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1163684AbdEXLox (ORCPT ); Wed, 24 May 2017 07:44:53 -0400 Received: from us-smtp-delivery-194.mimecast.com ([63.128.21.194]:49242 "EHLO us-smtp-delivery-194.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965587AbdEXLog (ORCPT ); Wed, 24 May 2017 07:44:36 -0400 From: Trond Myklebust To: "Anna.Schumaker@Netapp.com" , "xiaolong.ye@intel.com" CC: "torvalds@linux-foundation.org" , "linux-kernel@vger.kernel.org" , "lkp@01.org" , "linux-nfs@vger.kernel.org" Subject: Re: [lkp-robot] [NFS] 14d1bbb0ca: BUG:scheduling_while_atomic Thread-Topic: [lkp-robot] [NFS] 14d1bbb0ca: BUG:scheduling_while_atomic Thread-Index: AQHS1DcNJ/YwdBdonk6zZOgIe/hWmKIDXcGA Date: Wed, 24 May 2017 11:44:27 +0000 Message-ID: <1495626265.8735.2.camel@primarydata.com> References: <20170524023629.GK1795@yexl-desktop> In-Reply-To: <20170524023629.GK1795@yexl-desktop> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [68.49.162.121] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;MWHPR11MB1359;7:dCDCV+NFwYbvj/VZ/anSf1oj0MEU2h9XEHpUWQXG1q8X5MNdKZ7ndm4d4Mi9RnqHOWGg133IMOMWblGy2gmdH0AjS3ati+7L1IUxg9pNZvLsCdMWoUZjrsNaY0OhUo+Ap+gRhDLmZW1pwgfnbse6YkVDwumwdxmpM4iXAX72mMIfCHZPjnBo4e84pTvenm2sMB/FaEUsQwrNRoSjsV4iRglKKvxPbtpgt1lUOxB+Vkgc95oa/IO4I5YoFylOIG7AW0EoVuJVGXMG2Jl7Utw+SukRK9/bIdxyAsBmO2CCCXkMvQATt9731kE7Pj04HnonfqN4JAbiu24xYTR5/qCMqw==;20:HdCn/j8w2wU4QbMJV/gIzDJy3V82KwI/VxnA5M+MTkxcyhljDanM7rcvsSzpi7u+zU34aCRpKtqZdSwETrvN+fvVGqmd07x7Ox7RnNusNrrCZYapyTAAb2r6b8I+hLG98j67ANpPllAX1GwNkqur7EIYwO8rpBcmLCpmFGqs+hs= x-ms-traffictypediagnostic: MWHPR11MB1359: x-ms-office365-filtering-correlation-id: 364d20e3-0bad-48cb-e563-08d4a29a3bff x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(2017030254075)(201703131423075);SRVR:MWHPR11MB1359; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(84791874153150); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(6040450)(601004)(2401047)(5005006)(8121501046)(10201501046)(3002001)(93006095)(93001095)(6041248)(20161123562025)(2016111802025)(20161123564025)(20161123560025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123555025)(20161123558100)(6043046)(6072148);SRVR:MWHPR11MB1359;BCL:0;PCL:0;RULEID:;SRVR:MWHPR11MB1359; x-forefront-prvs: 031763BCAF x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6009001)(39840400002)(39450400003)(39400400002)(39410400002)(24454002)(377424004)(76176999)(50986999)(66066001)(81166006)(33646002)(8936002)(8676002)(54356999)(86362001)(575784001)(2501003)(478600001)(5890100001)(2950100002)(36756003)(2906002)(122556002)(305945005)(3660700001)(7736002)(3280700002)(6306002)(25786009)(4326008)(2900100001)(966005)(102836003)(5660300001)(3846002)(6116002)(77096006)(6486002)(6246003)(54906002)(229853002)(6436002)(6512007)(99286003)(103116003)(38730400002)(53936002)(6506006)(189998001);DIR:OUT;SFP:1102;SCL:1;SRVR:MWHPR11MB1359;H:MWHPR11MB1359.namprd11.prod.outlook.com;FPR:;SPF:None;MLV:sfv;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-ID: <0923A5B79055EB4099AA7D5EB28A8105@namprd11.prod.outlook.com> MIME-Version: 1.0 X-OriginatorOrg: primarydata.com X-MS-Exchange-CrossTenant-originalarrivaltime: 24 May 2017 11:44:27.9028 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 03193ed6-8726-4bb3-a832-18ab0d28adb7 X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB1359 X-MC-Unique: XcbgS1OSPtKOLXOvVf-kOg-1 Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id v4OBivuV023214 On Wed, 2017-05-24 at 10:36 +0800, kernel test robot wrote: > FYI, we noticed the following commit: > > commit: 14d1bbb0ca425c4fdd9a38eaac346c028661b752 ("NFS: Create a > common nfs4_match_client() function") > https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git > master > > in testcase: boot > > on test machine: qemu-system-x86_64 -enable-kvm -cpu host -smp 2 -m > 4G > > caused below changes (please refer to attached dmesg/kmsg for entire > log/backtrace): > > > +-------------------------------+------------+------------+ > >                               | 5b6d3ff605 | 14d1bbb0ca | > > +-------------------------------+------------+------------+ > > boot_successes                | 469        | 470        | > > boot_failures                 | 0          | 31         | > > BUG:scheduling_while_atomic   | 0          | 31         | > > BUG:spinlock_recursion_on_CPU | 0          | 30         | > > +-------------------------------+------------+------------+ > > > > [  299.158991] BUG: scheduling while atomic: > mount.nfs/9387/0x00000002 > [  299.169587] 2 locks held by mount.nfs/9387: > [  299.176165]  #0:  (nfs_clid_init_mutex){......}, at: > [] nfs4_discover_server_trunking+0x47/0x1fc > [  299.201802]  #1:  (&(&nn->nfs_client_lock)->rlock){......}, at: > [] nfs40_walk_client_list+0x2e9/0x338 > Oops. Anna, it looks as if that patch adds an incorrect call to "spin_lock(&nn->nfs_client_lock)" for the "default:" case when processing the result from the SETCLIENTID_CONFIRM call. I can send a fix. Thanks Xiaolong! Cheers Trond -- Trond Myklebust Linux NFS client maintainer, PrimaryData trond.myklebust@primarydata.com