From: Bart Van Assche <Bart.VanAssche@sandisk.com>
To: "jthumshirn@suse.de" <jthumshirn@suse.de>,
"martin.petersen@oracle.com" <martin.petersen@oracle.com>
Cc: "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"himanshu.madhani@cavium.com" <himanshu.madhani@cavium.com>,
"qla2xxx-upstream@qlogic.com" <qla2xxx-upstream@qlogic.com>
Subject: Re: [PATCH] qla2xxx: don't disable a not previously enabled PCI device
Date: Wed, 24 May 2017 15:47:14 +0000 [thread overview]
Message-ID: <1495640832.2823.5.camel@sandisk.com> (raw)
In-Reply-To: <20170523145047.5020-1-jthumshirn@suse.de>
On Tue, 2017-05-23 at 16:50 +0200, Johannes Thumshirn wrote:
> When pci_enable_device() or pci_enable_device_mem() fail in
> qla2x00_probe_one() we bail out but do a call to
> pci_disable_device(). This causes the dev_WARN_ON() in
> pci_disable_device() to trigger, as the device wasn't enabled
> previously.
>
> So instead of taking the 'probe_out' error path we can directly return
> *iff* one of the pci_enable_device() calls fails.
>
> Additionally rename the 'probe_out' goto label's name to the more
> descriptive 'disable_device'.
>
> Signed-off-by: Johannes Thumshirn <jthumshirn@suse.de>
> Fixes: e315cd28b9ef ("[SCSI] qla2xxx: Code changes for qla data structure refactoring")
Hello Johannes,
Please consider adding a Cc: stable tag to this patch. Since otherwise this
patch looks fine to me:
Reviewed-by: Bart Van Assche <bart.vanassche@sandisk.com>
next prev parent reply other threads:[~2017-05-24 15:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-23 14:50 [PATCH] qla2xxx: don't disable a not previously enabled PCI device Johannes Thumshirn
2017-05-24 2:37 ` Martin K. Petersen
2017-05-24 15:47 ` Bart Van Assche [this message]
2017-05-24 17:12 ` Malavali, Giridhar
2017-05-24 19:11 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1495640832.2823.5.camel@sandisk.com \
--to=bart.vanassche@sandisk.com \
--cc=himanshu.madhani@cavium.com \
--cc=jthumshirn@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=qla2xxx-upstream@qlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.