From: Bart Van Assche <Bart.VanAssche@sandisk.com>
To: "chad.dupuis@cavium.com" <chad.dupuis@cavium.com>,
"martin.petersen@oracle.com" <martin.petersen@oracle.com>
Cc: "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"james.bottomley@hansenpartnership.com"
<james.bottomley@hansenpartnership.com>,
"QLogic-Storage-Upstream@cavium.com"
<QLogic-Storage-Upstream@cavium.com>
Subject: Re: [PATCH 09/15] qedf: Add bus_reset No-op.
Date: Wed, 24 May 2017 16:37:12 +0000 [thread overview]
Message-ID: <1495643831.2823.24.camel@sandisk.com> (raw)
In-Reply-To: <20170523131931.1777-10-chad.dupuis@cavium.com>
On Tue, 2017-05-23 at 06:19 -0700, Dupuis, Chad wrote:
> We need to add a bus reset no-op as without it some of the LUNs attached to a
> vport may go offline when the error handler escalates to host reset due to not
> having a bus reset handler in the driver. What happens is we escalate to host
> reset which does a soft link down/link up to reset the adapter. However with
> multiple vports attached it's been observed that if the vports do log back into
> the target within 5 seconds, the SCSI layer offlines the devices most likely
> due to a TUR timing out to verify that the device is online. Adding a bus
> reset handler will cause the TUR to be sent after the bus reset handler where
> the devices will still be online if the bus reset is initiated by sg_reset
> (which is the case in the test that was failing). The bus reset will succeed
> and not needlessly bring the device offline/online.
Reviewed-by: Bart Van Assche <Bart.VanAssche@sandisk.com>
next prev parent reply other threads:[~2017-05-24 16:37 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-23 13:19 [PATCH 00/15] qedf: Update driver to version 8.18.22.0 Dupuis, Chad
2017-05-23 13:19 ` [PATCH 01/15] qedf: Enable basic FDMI information Dupuis, Chad
2017-05-24 16:16 ` Bart Van Assche
2017-05-23 13:19 ` [PATCH 02/15] qedf: Update copyright to 2017 Dupuis, Chad
2017-05-23 13:19 ` [PATCH 03/15] qedf: Honor qed_ops->common->set_fp_int() return code Dupuis, Chad
2017-05-24 16:22 ` Bart Van Assche
2017-05-23 13:19 ` [PATCH 04/15] qedf: Look at all descriptors when processing a clear virtual link Dupuis, Chad
2017-05-24 16:24 ` Bart Van Assche
2017-05-23 13:19 ` [PATCH 05/15] qedf: Check that fcport is offloaded before dereferencing pointers in initiate_abts|cleanup Dupuis, Chad
2017-05-24 16:25 ` Bart Van Assche
2017-05-23 13:19 ` [PATCH 06/15] qedf: Add fka_period SCSI host attribute to show fip keep alive period Dupuis, Chad
2017-05-24 16:34 ` Bart Van Assche
2017-05-23 13:19 ` [PATCH 07/15] qedf: Set qed logging level to QED_LEVEL_NOTICE Dupuis, Chad
2017-05-24 16:35 ` Bart Van Assche
2017-05-23 13:19 ` [PATCH 08/15] qedf: Use same logic for SCSI host reset and FC lip_reset Dupuis, Chad
2017-05-24 16:36 ` Bart Van Assche
2017-05-23 13:19 ` [PATCH 09/15] qedf: Add bus_reset No-op Dupuis, Chad
2017-05-24 16:37 ` Bart Van Assche [this message]
2017-05-23 13:19 ` [PATCH 10/15] qedf: Add non-offload receive filters Dupuis, Chad
2017-05-24 16:39 ` Bart Van Assche
2017-05-23 13:19 ` [PATCH 11/15] qedf: Fixup unnecessary paratheses around test_bit operations Dupuis, Chad
2017-05-24 16:41 ` Bart Van Assche
2017-05-23 13:19 ` [PATCH 12/15] qedf: Move some prints to a debug level so they do not print when no debugging is enabled Dupuis, Chad
2017-05-24 16:43 ` Bart Van Assche
2017-05-23 13:19 ` [PATCH 13/15] qedf: Change cmd_per_lun in scsi_host_template to 32 to increase performance Dupuis, Chad
2017-05-24 16:43 ` Bart Van Assche
2017-05-23 13:19 ` [PATCH 14/15] qedf: Add change_queue_depth member to scsi_host_template() Dupuis, Chad
2017-05-24 16:44 ` Bart Van Assche
2017-05-23 13:19 ` [PATCH 15/15] qedf: Update version number to 8.18.22.0 Dupuis, Chad
2017-05-24 16:51 ` Bart Van Assche
2017-05-24 2:35 ` [PATCH 00/15] qedf: Update driver to version 8.18.22.0 Martin K. Petersen
2017-05-24 19:12 ` Martin K. Petersen
2017-05-24 19:14 ` Chad Dupuis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1495643831.2823.24.camel@sandisk.com \
--to=bart.vanassche@sandisk.com \
--cc=QLogic-Storage-Upstream@cavium.com \
--cc=chad.dupuis@cavium.com \
--cc=james.bottomley@hansenpartnership.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.