All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chee, Tien Fong <tien.fong.chee@intel.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v6 0/6] Add Intel Arria 10 SoC FPGA driver
Date: Thu, 25 May 2017 08:53:36 +0000	[thread overview]
Message-ID: <1495702414.2373.5.camel@intel.com> (raw)
In-Reply-To: <481e0bfc-f2b4-887f-8c1d-a7cf513584d5@kernel.org>

On Rab, 2017-05-24 at 09:56 -0500, Dinh Nguyen wrote:
> 
> On 05/23/2017 09:24 PM, tien.fong.chee at intel.com wrote:
> > 
> > From: Tien Fong Chee <tien.fong.chee@intel.com>
> > 
> > This is the 6th version of patchset to adds support for Intel Arria
> > 10 SoC FPGA
> > driver. This version mainly resolved comments from Dinh in [v5].
> > This series is working on top of u-boot-socfpga-next branch
> > http://git.denx.de/?p=u-boot/u-boot-socfpga.git;a=shortlog;h=refs/h
> > eads/next.
> > 
> > [v5]: https://www.mail-archive.com/u-boot at lists.denx.de/msg250517.h
> > tml
> > 
> > v5 -> v6 changes:
> > -----------------
> > - Created separate patch for enabling FPGA driver support.
> > 
> Please consider at least doing a compile test for this patch series?
> I'm
> now very skeptical that you've done any kind of testing on this patch
> series? :(
> 
> For 'make socfpga_cyclone5_defconfig:
> 
> arch/arm/mach-socfpga/built-in.o: In function
> `socfpga_bridges_reset':
> /home/dinguyen/linux_dev/u-boot/arch/arm/mach-
> socfpga/reset_manager_gen5.c:101:
> undefined reference to `fpgamgr_test_fpga_ready'
> arch/arm/mach-socfpga/built-in.o: In function
> `populate_sysmgr_fpgaintf_module':
> /home/dinguyen/linux_dev/u-boot/arch/arm/mach-
> socfpga/system_manager_gen5.c:48:
> undefined reference to `fpgamgr_test_fpga_ready'
> drivers/built-in.o: In function `sdram_mmr_init_full':
> /home/dinguyen/linux_dev/u-boot/drivers/ddr/altera/sdram.c:448:
> undefined reference to `fpgamgr_test_fpga_ready'
> scripts/Makefile.spl:334: recipe for target 'spl/u-boot-spl' failed
> make[1]: *** [spl/u-boot-spl] Error 1
> Makefile:1347: recipe for target 'spl/u-boot-spl' failed
> make: *** [spl/u-boot-spl] Error 2
> 
> For socfpga_arria10_defconfig:
> 
> arch/arm/mach-socfpga/built-in.o: In function `socfpga_fpga_add':
> /home/dinguyen/linux_dev/u-boot/arch/arm/mach-socfpga/misc.c:110:
> undefined reference to `fpga_init'
> /home/dinguyen/linux_dev/u-boot/arch/arm/mach-socfpga/misc.c:112:
> undefined reference to `fpga_add'
> scripts/Makefile.spl:334: recipe for target 'spl/u-boot-spl' failed
> make[1]: *** [spl/u-boot-spl] Error 1
> Makefile:1347: recipe for target 'spl/u-boot-spl' failed
> make: *** [spl/u-boot-spl] Error 2
> 
> 
> Dinh

I did the compilation on each patch, and testing the patch set on all
arria10, cyclone5 and arria10 devkit.

I suspect something wrong with v6-0005-arm-socfpga-Move-FPGA-manager-
driver-to-FPGA-driv.patch you applied. Could you help me check again
and confirm all the patches waere applied properly?

In the meantime, i will clone the lastet from mainstream to confirm
again. This cloning need take a few hours to finish.

Thanks.

  reply	other threads:[~2017-05-25  8:53 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-24  2:24 [U-Boot] [PATCH v6 0/6] Add Intel Arria 10 SoC FPGA driver tien.fong.chee at intel.com
2017-05-24  2:24 ` [U-Boot] [PATCH v6 1/6] arm: socfpga: Remove unused passing parameter of socfpga_bridges_reset tien.fong.chee at intel.com
2017-05-24  2:24 ` [U-Boot] [PATCH v6 2/6] arm: socfpga: Restructure FPGA driver in the preparation to support A10 tien.fong.chee at intel.com
2017-05-24  2:24 ` [U-Boot] [PATCH v6 3/6] arm: socfpga: Enable FPGA driver on SPL tien.fong.chee at intel.com
2017-05-24  2:24 ` [U-Boot] [PATCH v6 4/6] arm: socfpga: Enable FPGA driver build " tien.fong.chee at intel.com
2017-05-24  2:24 ` [U-Boot] [PATCH v6 5/6] arm: socfpga: Move FPGA manager driver to FPGA driver tien.fong.chee at intel.com
2017-05-24  2:24 ` [U-Boot] [PATCH v6 6/6] arm: socfpga: Add FPGA driver support for Arria 10 tien.fong.chee at intel.com
2017-05-24 14:56 ` [U-Boot] [PATCH v6 0/6] Add Intel Arria 10 SoC FPGA driver Dinh Nguyen
2017-05-25  8:53   ` Chee, Tien Fong [this message]
2017-05-25  9:18     ` Marek Vasut
2017-05-26  2:36       ` Chee, Tien Fong
2017-05-25 13:35     ` Dinh Nguyen
2017-05-26  8:48       ` Chee, Tien Fong
2017-05-26 14:49         ` Dinh Nguyen
2017-05-29  3:00           ` Chee, Tien Fong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1495702414.2373.5.camel@intel.com \
    --to=tien.fong.chee@intel.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.