From: Bernd Petrovitsch <bernd@petrovitsch.priv.at>
To: Joe Perches <joe@perches.com>,
Alexey Dobriyan <adobriyan@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] CodingStyle: delete "kmalloc(sizeof(*var))" as preferred allocation form
Date: Thu, 25 May 2017 12:46:04 +0200 [thread overview]
Message-ID: <1495709164.25090.23.camel@petrovitsch.priv.at> (raw)
In-Reply-To: <1495708535.29207.1.camel@perches.com>
On Thu, 2017-05-25 at 03:35 -0700, Joe Perches wrote:
> On Wed, 2017-05-24 at 13:18 +0300, Alexey Dobriyan wrote:
> > Proper fix is to introduce typed allocation macros with the following
> > signatures:
> >
> > T* lmalloc(T, gfp);
Ack (FWIW).
[...]
> > struct foo *x;
> > x = lmalloc(struct foo, GFP_KERNEL);
>
> Then code would be written
>
> x = lmalloc(typeof(*x), GFP_KERNEL);
At least it is correct and changes automagically if x changes the type
which
struct bar *x;
x = kmalloc(sizeof(struct foo), GFP_KERNEL);
doesn't do and the compiler doesn't complain.
And the typeof() version could be written that way today but I can't
remember seeing it (in the kernel and elsewhere).
MfG,
Bernd
--
Bernd Petrovitsch Email : bernd@petrovitsch.priv.at
LUGA : http://www.luga.at
next prev parent reply other threads:[~2017-05-25 11:31 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-22 21:38 [PATCH] CodingStyle: delete "kmalloc(sizeof(*var))" as preferred allocation form Alexey Dobriyan
2017-05-22 21:43 ` Joe Perches
2017-05-22 21:49 ` Randy Dunlap
2017-05-22 22:22 ` Andrew Morton
2017-05-22 22:41 ` Joe Perches
2017-05-24 10:18 ` Alexey Dobriyan
2017-05-25 10:35 ` Joe Perches
2017-05-25 10:46 ` Bernd Petrovitsch [this message]
2017-05-28 19:16 ` Pavel Machek
2017-05-22 21:49 ` [PATCH] checkpatch: Remove preference for alloc(sizeof(*p), ...) Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1495709164.25090.23.camel@petrovitsch.priv.at \
--to=bernd@petrovitsch.priv.at \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.