From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id AF96821A08D83 for ; Thu, 25 May 2017 06:30:55 -0700 (PDT) Message-ID: <1495718961.6967.117.camel@linux.intel.com> Subject: Re: [PATCH 10/23] afs: switch to use uuid_t and uuid_gen From: Andy Shevchenko Date: Thu, 25 May 2017 16:29:21 +0300 In-Reply-To: <20170525130027.GA30194@lst.de> References: <20170518062705.25902-1-hch@lst.de> <20170518062705.25902-11-hch@lst.de> <1495478957.6967.69.camel@linux.intel.com> <20170523084956.GB20121@lst.de> <1495545099.6967.81.camel@linux.intel.com> <20170525130027.GA30194@lst.de> Mime-Version: 1.0 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: linux-nvdimm-bounces@lists.01.org Sender: "Linux-nvdimm" To: Christoph Hellwig Cc: linux-xfs@vger.kernel.org, linux-raid@vger.kernel.org, linux-nvdimm@lists.01.org, Mimi Zohar , Amir Goldstein , linux-kernel@vger.kernel.org, David Howells , linux-fsdevel@vger.kernel.org, Shaohua Li , Steven Whitehouse List-ID: T24gVGh1LCAyMDE3LTA1LTI1IGF0IDE1OjAwICswMjAwLCBDaHJpc3RvcGggSGVsbHdpZyB3cm90 ZToKPiBPbiBUdWUsIE1heSAyMywgMjAxNyBhdCAwNDoxMTozOVBNICswMzAwLCBBbmR5IFNoZXZj aGVua28gd3JvdGU6Cj4gPiBTaW5jZSB3ZSBpbnRyb2R1Y2VkIGEgdW5pb24gaXQncyBwb3NzaWJs ZSB0aGF0IHdlIG1pZ2h0IGFjY2VzcyB0aGUKPiA+IG1lbWJlciB3aGljaCB3YXNuJ3QgbGFzdCBt b2RpZmllZCBvbmUuIFNvLCBteSBjb21tZW50IGlzIHRvIGdpdmUgYW4KPiA+IGF0dGVudGlvbiBv biBzdWNoIHBvc3NpYmlsaXR5IGFuZCBhdm9pZCBpZiB0aGVyZSBpcyBhbiBhbGlhc2luZwo+ID4g aGFwcGVuZWQuCj4gCj4gV2UgZG8gZm9yIEFGUyAoYW5kIFhGUyBmb3IgZnMgZnNpZCkuwqDCoE15 IHByZWZlcmVuY2Ugd291bGQgYmUgdG8KPiBub3QgaGF2ZSB0aGUgdjEgc3RydWN0IGRlZmludGlv biBidXQgaW5zdGVhZCBwcm92aWRlIGEgZmV3Cj4gaGVscGVycyBpbiB1dWlkLmggdGhhdCB1c2Ug Z2V0X3VuYWxpZ25lZF9iZSogaWYgbmVlZGVkOgo+IAo+IAl1dWlkX3YxX3RpbWVfbG93KCkKPiAJ dXVpZF92MV90aW1lX21pZCgpCj4gCXV1aWRfdjFfdGltZV90aW1lX2hpX2FuZF92ZXJzaW9uKCku Lgo+IAo+IEZyb20gaGlzIHByZXZpb3VzbHkgcmVwbHkgaXQgc2VlbXMgbGlrZSBEYXZlIGRvZXNu J3QgbGlrZSB0aGF0IGlkZWEKPiB0b28gbXVjaCwgaW4gd2hpY2ggY2FzZSBJIHN1c3BlY3QgbW92 aW5nIHN0cnVjdCB1dWlkX3YxIGJhY2sgaW50bwo+IGFmcyBhbmQgbGl2aW5nIHdpdGggY2FzdCBp biBpdCBpcyB0aGUgd2F5IHRvIGdvLgoKUGVyc29uYWxseSBJIGRvbid0IGxpa2UgdGhhdCB1bmlv biBzdHVmZiwgc28sIGRlZmluaXRlbHkgbXkgdm90ZSB0byBnZXQKcmlkIG9mIEFGUyBzdHVmZiBp biBnZW5lcmljIGhlbHBlcnMuCgpPVE9IIGlmIHRoZXJlIHdpbGwgYmUgbW9yZSB1c2VycyBvZiBz dWNoIEFQSSB0aGVuIHNvbWV0aGluZyBsaWtlIHlvdQpwcm9wb3NlZCB3b3VsZCBiZSBzdWZmaWNp ZW50IHdpdGhvdXQgaW50cm9kdWNpbmcgYSB1bmlvbi4KCi0tIApBbmR5IFNoZXZjaGVua28gPGFu ZHJpeS5zaGV2Y2hlbmtvQGxpbnV4LmludGVsLmNvbT4KSW50ZWwgRmlubGFuZCBPeQpfX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpMaW51eC1udmRpbW0gbWFp bGluZyBsaXN0CkxpbnV4LW52ZGltbUBsaXN0cy4wMS5vcmcKaHR0cHM6Ly9saXN0cy4wMS5vcmcv bWFpbG1hbi9saXN0aW5mby9saW51eC1udmRpbW0K From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andy Shevchenko Subject: Re: [PATCH 10/23] afs: switch to use uuid_t and uuid_gen Date: Thu, 25 May 2017 16:29:21 +0300 Message-ID: <1495718961.6967.117.camel@linux.intel.com> References: <20170518062705.25902-1-hch@lst.de> <20170518062705.25902-11-hch@lst.de> <1495478957.6967.69.camel@linux.intel.com> <20170523084956.GB20121@lst.de> <1495545099.6967.81.camel@linux.intel.com> <20170525130027.GA30194@lst.de> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20170525130027.GA30194-jcswGhMUV9g@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linux-nvdimm-bounces-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org Sender: "Linux-nvdimm" To: Christoph Hellwig Cc: linux-xfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-raid-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-nvdimm-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org, Mimi Zohar , Amir Goldstein , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, David Howells , linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Shaohua Li , Steven Whitehouse List-Id: linux-raid.ids T24gVGh1LCAyMDE3LTA1LTI1IGF0IDE1OjAwICswMjAwLCBDaHJpc3RvcGggSGVsbHdpZyB3cm90 ZToKPiBPbiBUdWUsIE1heSAyMywgMjAxNyBhdCAwNDoxMTozOVBNICswMzAwLCBBbmR5IFNoZXZj aGVua28gd3JvdGU6Cj4gPiBTaW5jZSB3ZSBpbnRyb2R1Y2VkIGEgdW5pb24gaXQncyBwb3NzaWJs ZSB0aGF0IHdlIG1pZ2h0IGFjY2VzcyB0aGUKPiA+IG1lbWJlciB3aGljaCB3YXNuJ3QgbGFzdCBt b2RpZmllZCBvbmUuIFNvLCBteSBjb21tZW50IGlzIHRvIGdpdmUgYW4KPiA+IGF0dGVudGlvbiBv biBzdWNoIHBvc3NpYmlsaXR5IGFuZCBhdm9pZCBpZiB0aGVyZSBpcyBhbiBhbGlhc2luZwo+ID4g aGFwcGVuZWQuCj4gCj4gV2UgZG8gZm9yIEFGUyAoYW5kIFhGUyBmb3IgZnMgZnNpZCkuwqDCoE15 IHByZWZlcmVuY2Ugd291bGQgYmUgdG8KPiBub3QgaGF2ZSB0aGUgdjEgc3RydWN0IGRlZmludGlv biBidXQgaW5zdGVhZCBwcm92aWRlIGEgZmV3Cj4gaGVscGVycyBpbiB1dWlkLmggdGhhdCB1c2Ug Z2V0X3VuYWxpZ25lZF9iZSogaWYgbmVlZGVkOgo+IAo+IAl1dWlkX3YxX3RpbWVfbG93KCkKPiAJ dXVpZF92MV90aW1lX21pZCgpCj4gCXV1aWRfdjFfdGltZV90aW1lX2hpX2FuZF92ZXJzaW9uKCku Lgo+IAo+IEZyb20gaGlzIHByZXZpb3VzbHkgcmVwbHkgaXQgc2VlbXMgbGlrZSBEYXZlIGRvZXNu J3QgbGlrZSB0aGF0IGlkZWEKPiB0b28gbXVjaCwgaW4gd2hpY2ggY2FzZSBJIHN1c3BlY3QgbW92 aW5nIHN0cnVjdCB1dWlkX3YxIGJhY2sgaW50bwo+IGFmcyBhbmQgbGl2aW5nIHdpdGggY2FzdCBp biBpdCBpcyB0aGUgd2F5IHRvIGdvLgoKUGVyc29uYWxseSBJIGRvbid0IGxpa2UgdGhhdCB1bmlv biBzdHVmZiwgc28sIGRlZmluaXRlbHkgbXkgdm90ZSB0byBnZXQKcmlkIG9mIEFGUyBzdHVmZiBp biBnZW5lcmljIGhlbHBlcnMuCgpPVE9IIGlmIHRoZXJlIHdpbGwgYmUgbW9yZSB1c2VycyBvZiBz dWNoIEFQSSB0aGVuIHNvbWV0aGluZyBsaWtlIHlvdQpwcm9wb3NlZCB3b3VsZCBiZSBzdWZmaWNp ZW50IHdpdGhvdXQgaW50cm9kdWNpbmcgYSB1bmlvbi4KCi0tIApBbmR5IFNoZXZjaGVua28gPGFu ZHJpeS5zaGV2Y2hlbmtvQGxpbnV4LmludGVsLmNvbT4KSW50ZWwgRmlubGFuZCBPeQpfX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpMaW51eC1udmRpbW0gbWFp bGluZyBsaXN0CkxpbnV4LW52ZGltbUBsaXN0cy4wMS5vcmcKaHR0cHM6Ly9saXN0cy4wMS5vcmcv bWFpbG1hbi9saXN0aW5mby9saW51eC1udmRpbW0K From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com ([134.134.136.31]:63605 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1424225AbdEYNbL (ORCPT ); Thu, 25 May 2017 09:31:11 -0400 Message-ID: <1495718961.6967.117.camel@linux.intel.com> Subject: Re: [PATCH 10/23] afs: switch to use uuid_t and uuid_gen From: Andy Shevchenko Date: Thu, 25 May 2017 16:29:21 +0300 In-Reply-To: <20170525130027.GA30194@lst.de> References: <20170518062705.25902-1-hch@lst.de> <20170518062705.25902-11-hch@lst.de> <1495478957.6967.69.camel@linux.intel.com> <20170523084956.GB20121@lst.de> <1495545099.6967.81.camel@linux.intel.com> <20170525130027.GA30194@lst.de> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-xfs-owner@vger.kernel.org List-ID: List-Id: xfs To: Christoph Hellwig Cc: Amir Goldstein , linux-fsdevel@vger.kernel.org, Shaohua Li , Dan Williams , David Howells , Steven Whitehouse , Mimi Zohar , linux-xfs@vger.kernel.org, linux-raid@vger.kernel.org, linux-nvdimm@lists.01.org, linux-kernel@vger.kernel.org On Thu, 2017-05-25 at 15:00 +0200, Christoph Hellwig wrote: > On Tue, May 23, 2017 at 04:11:39PM +0300, Andy Shevchenko wrote: > > Since we introduced a union it's possible that we might access the > > member which wasn't last modified one. So, my comment is to give an > > attention on such possibility and avoid if there is an aliasing > > happened. > > We do for AFS (and XFS for fs fsid).  My preference would be to > not have the v1 struct defintion but instead provide a few > helpers in uuid.h that use get_unaligned_be* if needed: > > uuid_v1_time_low() > uuid_v1_time_mid() > uuid_v1_time_time_hi_and_version().. > > From his previously reply it seems like Dave doesn't like that idea > too much, in which case I suspect moving struct uuid_v1 back into > afs and living with cast in it is the way to go. Personally I don't like that union stuff, so, definitely my vote to get rid of AFS stuff in generic helpers. OTOH if there will be more users of such API then something like you proposed would be sufficient without introducing a union. -- Andy Shevchenko Intel Finland Oy From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1424260AbdEYNbQ (ORCPT ); Thu, 25 May 2017 09:31:16 -0400 Received: from mga06.intel.com ([134.134.136.31]:63605 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1424225AbdEYNbL (ORCPT ); Thu, 25 May 2017 09:31:11 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.38,391,1491289200"; d="scan'208";a="91686773" Message-ID: <1495718961.6967.117.camel@linux.intel.com> Subject: Re: [PATCH 10/23] afs: switch to use uuid_t and uuid_gen From: Andy Shevchenko To: Christoph Hellwig Cc: Amir Goldstein , linux-fsdevel@vger.kernel.org, Shaohua Li , Dan Williams , David Howells , Steven Whitehouse , Mimi Zohar , linux-xfs@vger.kernel.org, linux-raid@vger.kernel.org, linux-nvdimm@ml01.01.org, linux-kernel@vger.kernel.org Date: Thu, 25 May 2017 16:29:21 +0300 In-Reply-To: <20170525130027.GA30194@lst.de> References: <20170518062705.25902-1-hch@lst.de> <20170518062705.25902-11-hch@lst.de> <1495478957.6967.69.camel@linux.intel.com> <20170523084956.GB20121@lst.de> <1495545099.6967.81.camel@linux.intel.com> <20170525130027.GA30194@lst.de> Organization: Intel Finland Oy Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.22.6-1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2017-05-25 at 15:00 +0200, Christoph Hellwig wrote: > On Tue, May 23, 2017 at 04:11:39PM +0300, Andy Shevchenko wrote: > > Since we introduced a union it's possible that we might access the > > member which wasn't last modified one. So, my comment is to give an > > attention on such possibility and avoid if there is an aliasing > > happened. > > We do for AFS (and XFS for fs fsid).  My preference would be to > not have the v1 struct defintion but instead provide a few > helpers in uuid.h that use get_unaligned_be* if needed: > > uuid_v1_time_low() > uuid_v1_time_mid() > uuid_v1_time_time_hi_and_version().. > > From his previously reply it seems like Dave doesn't like that idea > too much, in which case I suspect moving struct uuid_v1 back into > afs and living with cast in it is the way to go. Personally I don't like that union stuff, so, definitely my vote to get rid of AFS stuff in generic helpers. OTOH if there will be more users of such API then something like you proposed would be sufficient without introducing a union. -- Andy Shevchenko Intel Finland Oy