From: Bart Van Assche <Bart.VanAssche@sandisk.com>
To: "axboe@kernel.dk" <axboe@kernel.dk>
Cc: "hch@lst.de" <hch@lst.de>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"hare@suse.com" <hare@suse.com>,
"osandov@fb.com" <osandov@fb.com>,
"ming.lei@redhat.com" <ming.lei@redhat.com>
Subject: Re: [PATCH 4/5] blk-mq-debugfs: Show busy requests
Date: Fri, 26 May 2017 21:22:37 +0000 [thread overview]
Message-ID: <1495833756.2634.9.camel@sandisk.com> (raw)
In-Reply-To: <0c124a6c-8c2d-1fb9-118f-96ce7fadc64c@kernel.dk>
On Fri, 2017-05-26 at 15:20 -0600, Jens Axboe wrote:
> On 05/26/2017 03:17 PM, Bart Van Assche wrote:
> > On Fri, 2017-05-26 at 07:26 -0600, Jens Axboe wrote:
> > > On 05/25/2017 05:38 PM, Bart Van Assche wrote:
> > > > Requests that got stuck in a block driver are neither on
> > > > blk_mq_ctx.rq_list nor on any hw dispatch queue. Make these
> > > > visible in debugfs through the "busy" attribute.
> > > >=20
> > > > Signed-off-by: Bart Van Assche <bart.vanassche@sandisk.com>
> > > > Cc: Christoph Hellwig <hch@lst.de>
> > > > Cc: Hannes Reinecke <hare@suse.com>
> > > > Cc: Omar Sandoval <osandov@fb.com>
> > > > Cc: Ming Lei <ming.lei@redhat.com>
> > > > ---
> > > > block/blk-mq-debugfs.c | 25 +++++++++++++++++++++++++
> > > > 1 file changed, 25 insertions(+)
> > > >=20
> > > > diff --git a/block/blk-mq-debugfs.c b/block/blk-mq-debugfs.c
> > > > index 8b06a12c1461..70a2b955afee 100644
> > > > --- a/block/blk-mq-debugfs.c
> > > > +++ b/block/blk-mq-debugfs.c
> > > > @@ -370,6 +370,30 @@ static const struct seq_operations hctx_dispat=
ch_seq_ops =3D {
> > > > .show =3D blk_mq_debugfs_rq_show,
> > > > };
> > > > =20
> > > > +struct show_busy_ctx {
> > > > + struct seq_file *m;
> > > > + struct blk_mq_hw_ctx *hctx;
> > > > +};
> > > > +
> > > > +static void hctx_show_busy(struct request *rq, void *data, bool re=
served)
> > > > +{
> > > > + const struct show_busy_ctx *ctx =3D data;
> > >=20
> > > Let's not call that variable 'ctx', in blk-mq that's pretty much
> > > reserved for the sw queues.
> >=20
> > Hello Jens,
> >=20
> > How about renaming show_busy_ctx into show_busy_params and ctx into par=
ams?
>=20
> I think that would be an improvement. Also, this:
>=20
> blk_mq_debugfs_rq_show(ctx->m, &rq->queuelist);
>=20
> doesn't look safe at all, as you are passing in a node instead of a
> head. I think you just want to use __blk_mq_debugfs_rq_show() here.
Hello Jens,
That change will make the compiler perform type checking. I agree that's
an improvement. I will make that change.
Bart.=
next prev parent reply other threads:[~2017-05-26 21:22 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-25 23:38 [PATCH 0/5] Five blk-mq-debugfs patches Bart Van Assche
2017-05-25 23:38 ` [PATCH 1/5] blk-mq: Only register debugfs attributes for blk-mq queues Bart Van Assche
2017-05-26 0:23 ` Omar Sandoval
2017-05-26 5:56 ` Hannes Reinecke
2017-05-26 13:27 ` Jens Axboe
2017-05-25 23:38 ` [PATCH 2/5] blk-mq-debugfs: Show atomic request flags Bart Van Assche
2017-05-26 5:56 ` Hannes Reinecke
2017-05-25 23:38 ` [PATCH 3/5] blk-mq-debugfs: Show requeue list Bart Van Assche
2017-05-26 5:57 ` Hannes Reinecke
2017-05-25 23:38 ` [PATCH 4/5] blk-mq-debugfs: Show busy requests Bart Van Assche
2017-05-26 13:26 ` Jens Axboe
2017-05-26 21:17 ` Bart Van Assche
2017-05-26 21:20 ` Jens Axboe
2017-05-26 21:21 ` Jens Axboe
2017-05-26 21:22 ` Bart Van Assche [this message]
2017-05-26 14:38 ` Hannes Reinecke
2017-05-26 21:27 ` Bart Van Assche
2017-05-26 21:32 ` Jens Axboe
2017-05-27 0:54 ` Ming Lei
2017-05-27 3:16 ` Ming Lei
2017-05-30 17:29 ` Bart Van Assche
2017-05-30 17:24 ` Bart Van Assche
2017-05-30 17:32 ` Jens Axboe
2017-05-25 23:38 ` [PATCH 5/5] blk-mq-debugfs: Add 'kick' operation Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1495833756.2634.9.camel@sandisk.com \
--to=bart.vanassche@sandisk.com \
--cc=axboe@kernel.dk \
--cc=hare@suse.com \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=osandov@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.