Re: [PATCH 09/33] configfs: Introduce config_item_get_unless_zero()

[Bart Van Assche <Bart.VanAssche@sandisk.com>]

On Sun, 2017-05-28 at 02:33 -0700, Christoph Hellwig wrote:
> > +struct config_item *config_item_get_unless_zero(struct config_item *item)
> > +{
> > +	return item && kref_get_unless_zero(&item->ci_kref) ? item : NULL;
> > +}
> > +EXPORT_SYMBOL(config_item_get_unless_zero);
> 
> Style nipick, I'd prefer something like:
> 
> 	if (item && !kref_get_unless_zero(&item->ci_kref))
> 		item = NULL;
> 	return item;
> 
> Otherwise this looks fine to me:
> 
> Reviewed-by: Christoph Hellwig <hch@lst.de>
> 
> or should I pick it up through the configfs tree?

Hello Christoph,

If you could pick up this patch (any style) through the configfs tree that would
be great.

Thanks,

Bart.