All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gerd Hoffmann <kraxel@redhat.com>
To: "Marc-André Lureau" <marcandre.lureau@gmail.com>,
	"Jonathon Jongsma" <jjongsma@redhat.com>,
	qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] spice: Use proper enum type for kbd led state
Date: Mon, 29 May 2017 14:17:25 +0200	[thread overview]
Message-ID: <1496060245.5201.1.camel@redhat.com> (raw)
In-Reply-To: <CAJ+F1C+Tr_yK6FzpG4Xiwe=8gtUSc02T1oREc7Ba939y14pDFg@mail.gmail.com>

On Thu, 2017-05-25 at 12:50 +0000, Marc-André Lureau wrote:
> 
> 
> On Thu, May 11, 2017 at 6:16 AM Jonathon Jongsma <jjongsma@redhat.com
> > wrote:
> > Although the Qemu and spice flags currently have the same value, it
> > seems more correct to pass the spice flag values to
> > spice_server_kbd_leds(), especially considering that this function
> > already makes an effort to convert between the QEMU_*_LED and
> > SPICE_KEYBOARD_MODIFIER_* values.
> > 
> > Signed-off-by: Jonathon Jongsma <jjongsma@redhat.com>
> 
> Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> 
>  

Added to ui queue.

thanks,
  Gerd

      reply	other threads:[~2017-05-29 12:17 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-10 20:20 [Qemu-devel] [PATCH] spice: Use proper enum type for kbd led state Jonathon Jongsma
2017-05-25 12:50 ` Marc-André Lureau
2017-05-29 12:17   ` Gerd Hoffmann [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1496060245.5201.1.camel@redhat.com \
    --to=kraxel@redhat.com \
    --cc=jjongsma@redhat.com \
    --cc=marcandre.lureau@gmail.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.