From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Lee Jones <lee.jones@linaro.org>,
Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Wolfram Sang <wsa@the-dreams.de>,
Hans de Goede <hdegoede@redhat.com>,
Paul Gortmaker <paul.gortmaker@windriver.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Bin Gao <bin.gao@intel.com>,
Felipe Balbi <felipe.balbi@linux.intel.com>
Subject: Re: [PATCH v8] mfd: Add Cherry Trail Whiskey Cove PMIC driver
Date: Tue, 30 May 2017 16:05:52 +0300 [thread overview]
Message-ID: <1496149552.28981.24.camel@linux.intel.com> (raw)
In-Reply-To: <20170530122003.scaw5f7diez7uhl6@dell>
On Tue, 2017-05-30 at 13:20 +0100, Lee Jones wrote:
> On Tue, 30 May 2017, Andy Shevchenko wrote:
>
> > On Tue, May 30, 2017 at 12:02 PM, Lee Jones <lee.jones@linaro.org>
> > wrote:
> > > On Tue, 23 May 2017, Hans de Goede wrote:
> > > > +static const struct i2c_device_id cht_wc_i2c_id[] = {
> > > > + { }
> > > > +};
> > >
> > > What's the point in this empty table?
> >
> > This is artifact of I2C framework, otherwise if will be not
> > enumerated.
> >
> > +Wolfram.
> >
> > Wolfram, can we fix this? (In case we have either ACPI table or OF
> > table there is no need to oblige providing empty legacy table)
>
> I think I fixed this already.
>
> Hint: `git grep probe_new -- drivers/i2c`
Indeed.
Thanks for a hint!
--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy
next prev parent reply other threads:[~2017-05-30 13:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-23 21:24 [PATCH v8] mfd: Add Cherry Trail Whiskey Cove PMIC driver Hans de Goede
2017-05-30 9:02 ` Lee Jones
2017-05-30 10:42 ` Andy Shevchenko
2017-05-30 12:20 ` Lee Jones
2017-05-30 13:05 ` Andy Shevchenko [this message]
2017-06-04 12:52 ` Hans de Goede
2017-06-05 7:49 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1496149552.28981.24.camel@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=andy.shevchenko@gmail.com \
--cc=bin.gao@intel.com \
--cc=felipe.balbi@linux.intel.com \
--cc=hdegoede@redhat.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paul.gortmaker@windriver.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.