All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: mikelley@microsoft.com, davem@davemloft.net,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	devel@linuxdriverproject.org, olaf@aepfle.de, apw@canonical.com,
	jasowang@redhat.com, leann.ogasawara@canonical.comi,
	marcelo.cerri@canonical.com, sthemmin@microsoft.com
Subject: Re: [PATCH net-next 1/1] netvsc: Add #include's for csum_* function declarations
Date: Tue, 30 May 2017 11:03:21 -0700	[thread overview]
Message-ID: <1496167401.2618.27.camel@perches.com> (raw)
In-Reply-To: <1496166184-19805-1-git-send-email-mikelley@microsoft.com>

On Tue, 2017-05-30 at 10:43 -0700, Michael Kelley wrote:
> Add direct #include statements for declarations of csum_tcpudp_magic()
> and csum_ipv6_magic(). While the needed #include's are picked up
> indirectly for the x86 architecture, they aren't on other
> architectures, resulting in compile errors.
[]
> diff --git a/drivers/net/hyperv/netvsc_drv.c b/drivers/net/hyperv/netvsc_drv.c
> index 4421a6d..ca952b3 100644
> --- a/drivers/net/hyperv/netvsc_drv.c
> +++ b/drivers/net/hyperv/netvsc_drv.c
> @@ -37,6 +37,8 @@
>  #include <net/route.h>
>  #include <net/sock.h>
>  #include <net/pkt_sched.h>
> +#include <asm/checksum.h>

Maybe
#include <net/checksum.h>
instead?

> +#include <net/ip6_checksum.h>
>  
>  #include "hyperv_net.h"
>  

  reply	other threads:[~2017-05-30 18:03 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-30 17:43 [PATCH net-next 1/1] netvsc: Add #include's for csum_* function declarations Michael Kelley
2017-05-30 18:03 ` Joe Perches [this message]
2017-05-31 17:59 ` David Miller
2017-05-31 17:59   ` David Miller
2017-05-31 22:59   ` Joe Perches
2017-05-31 23:25     ` David Miller
2017-05-31 23:25       ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1496167401.2618.27.camel@perches.com \
    --to=joe@perches.com \
    --cc=apw@canonical.com \
    --cc=davem@davemloft.net \
    --cc=devel@linuxdriverproject.org \
    --cc=jasowang@redhat.com \
    --cc=leann.ogasawara@canonical.comi \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcelo.cerri@canonical.com \
    --cc=mikelley@microsoft.com \
    --cc=netdev@vger.kernel.org \
    --cc=olaf@aepfle.de \
    --cc=sthemmin@microsoft.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.