From: Leonardo Sandoval <leonardo.sandoval.gonzalez@linux.intel.com>
To: Alejandro Hernandez <alejandro.hernandez@linux.intel.com>
Cc: yocto@yoctoproject.org
Subject: Re: [PATCH] yocto-bsp: Fix QEMUARM based bsps to not offer SMP support
Date: Tue, 30 May 2017 14:59:14 -0500 [thread overview]
Message-ID: <1496174354.26945.54.camel@linux.intel.com> (raw)
In-Reply-To: <20170530184434.35089-1-alejandro.hernandez@linux.intel.com>
Alex,
is this change only applies to qemu arm? I wonder if the native arm arch
needs a similar series.
Leo
On Tue, 2017-05-30 at 11:44 -0700, Alejandro Hernandez wrote:
> The SMP kernel config presents issues on qemuarm because:
>
> CONFIG_SMP=y
> Dependencies Missing:
> - CPU_V6K or CPU_V7:
> These are selected by setting:
> CONFIG_ARCH_MULTI_V7=y
> or
> CONFIG_ARCH_MULTI_V6=y
>
> But our QEMU + ARM BSPs are based on armv4/v5 hence they are
> incompatible with CONFIG_SMP.
>
> This patch fixes the script, and avoids offering SMP to the user
> when the created BSP is based on QEMU + ARM.
>
> [YOCTO #11426]
>
> Signed-off-by: Alejandro Hernandez <alejandro.hernandez@linux.intel.com>
> ---
> .../target/arch/qemu/recipes-kernel/linux/linux-yocto-dev.bbappend | 1 +
> .../target/arch/qemu/recipes-kernel/linux/linux-yocto-tiny_4.1.bbappend | 1 +
> .../target/arch/qemu/recipes-kernel/linux/linux-yocto-tiny_4.10.bbappend | 1 +
> .../target/arch/qemu/recipes-kernel/linux/linux-yocto-tiny_4.4.bbappend | 1 +
> .../target/arch/qemu/recipes-kernel/linux/linux-yocto-tiny_4.8.bbappend | 1 +
> .../target/arch/qemu/recipes-kernel/linux/linux-yocto_4.1.bbappend | 1 +
> .../target/arch/qemu/recipes-kernel/linux/linux-yocto_4.10.bbappend | 1 +
> .../target/arch/qemu/recipes-kernel/linux/linux-yocto_4.4.bbappend | 1 +
> .../target/arch/qemu/recipes-kernel/linux/linux-yocto_4.8.bbappend | 1 +
> 9 files changed, 9 insertions(+)
>
> diff --git a/scripts/lib/bsp/substrate/target/arch/qemu/recipes-kernel/linux/linux-yocto-dev.bbappend b/scripts/lib/bsp/substrate/target/arch/qemu/recipes-kernel/linux/linux-yocto-dev.bbappend
> index 7e3ce5ba12d..11105ebcc26 100644
> --- a/scripts/lib/bsp/substrate/target/arch/qemu/recipes-kernel/linux/linux-yocto-dev.bbappend
> +++ b/scripts/lib/bsp/substrate/target/arch/qemu/recipes-kernel/linux/linux-yocto-dev.bbappend
> @@ -45,6 +45,7 @@ COMPATIBLE_MACHINE_{{=machine}} = "{{=machine}}"
> {{ if need_new_kbranch == "n": }}
> KBRANCH_{{=machine}} = "{{=existing_kbranch}}"
>
> +{{ if qemuarch != "arm": }}
> {{ input type:"boolean" name:"smp" prio:"30" msg:"Would you like SMP support? (y/n)" default:"y"}}
> {{ if smp == "y": }}
> KERNEL_FEATURES_append_{{=machine}} += " cfg/smp.scc"
> diff --git a/scripts/lib/bsp/substrate/target/arch/qemu/recipes-kernel/linux/linux-yocto-tiny_4.1.bbappend b/scripts/lib/bsp/substrate/target/arch/qemu/recipes-kernel/linux/linux-yocto-tiny_4.1.bbappend
> index 81392ce38ac..ad77a662682 100644
> --- a/scripts/lib/bsp/substrate/target/arch/qemu/recipes-kernel/linux/linux-yocto-tiny_4.1.bbappend
> +++ b/scripts/lib/bsp/substrate/target/arch/qemu/recipes-kernel/linux/linux-yocto-tiny_4.1.bbappend
> @@ -45,6 +45,7 @@ COMPATIBLE_MACHINE_{{=machine}} = "{{=machine}}"
> {{ if need_new_kbranch == "n": }}
> KBRANCH_{{=machine}} = "{{=existing_kbranch}}"
>
> +{{ if qemuarch != "arm": }}
> {{ input type:"boolean" name:"smp" prio:"30" msg:"Do you need SMP support? (y/n)" default:"y"}}
> {{ if smp == "y": }}
> KERNEL_FEATURES_append_{{=machine}} += " cfg/smp.scc"
> diff --git a/scripts/lib/bsp/substrate/target/arch/qemu/recipes-kernel/linux/linux-yocto-tiny_4.10.bbappend b/scripts/lib/bsp/substrate/target/arch/qemu/recipes-kernel/linux/linux-yocto-tiny_4.10.bbappend
> index 29ad17b2009..9b5f8016841 100644
> --- a/scripts/lib/bsp/substrate/target/arch/qemu/recipes-kernel/linux/linux-yocto-tiny_4.10.bbappend
> +++ b/scripts/lib/bsp/substrate/target/arch/qemu/recipes-kernel/linux/linux-yocto-tiny_4.10.bbappend
> @@ -45,6 +45,7 @@ COMPATIBLE_MACHINE_{{=machine}} = "{{=machine}}"
> {{ if need_new_kbranch == "n": }}
> KBRANCH_{{=machine}} = "{{=existing_kbranch}}"
>
> +{{ if qemuarch != "arm": }}
> {{ input type:"boolean" name:"smp" prio:"30" msg:"Do you need SMP support? (y/n)" default:"y"}}
> {{ if smp == "y": }}
> KERNEL_FEATURES_append_{{=machine}} += " cfg/smp.scc"
> diff --git a/scripts/lib/bsp/substrate/target/arch/qemu/recipes-kernel/linux/linux-yocto-tiny_4.4.bbappend b/scripts/lib/bsp/substrate/target/arch/qemu/recipes-kernel/linux/linux-yocto-tiny_4.4.bbappend
> index a73b1aa132f..2fc992992cf 100644
> --- a/scripts/lib/bsp/substrate/target/arch/qemu/recipes-kernel/linux/linux-yocto-tiny_4.4.bbappend
> +++ b/scripts/lib/bsp/substrate/target/arch/qemu/recipes-kernel/linux/linux-yocto-tiny_4.4.bbappend
> @@ -45,6 +45,7 @@ COMPATIBLE_MACHINE_{{=machine}} = "{{=machine}}"
> {{ if need_new_kbranch == "n": }}
> KBRANCH_{{=machine}} = "{{=existing_kbranch}}"
>
> +{{ if qemuarch != "arm": }}
> {{ input type:"boolean" name:"smp" prio:"30" msg:"Do you need SMP support? (y/n)" default:"y"}}
> {{ if smp == "y": }}
> KERNEL_FEATURES_append_{{=machine}} += " cfg/smp.scc"
> diff --git a/scripts/lib/bsp/substrate/target/arch/qemu/recipes-kernel/linux/linux-yocto-tiny_4.8.bbappend b/scripts/lib/bsp/substrate/target/arch/qemu/recipes-kernel/linux/linux-yocto-tiny_4.8.bbappend
> index 7d40671fd43..868d12af04b 100644
> --- a/scripts/lib/bsp/substrate/target/arch/qemu/recipes-kernel/linux/linux-yocto-tiny_4.8.bbappend
> +++ b/scripts/lib/bsp/substrate/target/arch/qemu/recipes-kernel/linux/linux-yocto-tiny_4.8.bbappend
> @@ -45,6 +45,7 @@ COMPATIBLE_MACHINE_{{=machine}} = "{{=machine}}"
> {{ if need_new_kbranch == "n": }}
> KBRANCH_{{=machine}} = "{{=existing_kbranch}}"
>
> +{{ if qemuarch != "arm": }}
> {{ input type:"boolean" name:"smp" prio:"30" msg:"Do you need SMP support? (y/n)" default:"y"}}
> {{ if smp == "y": }}
> KERNEL_FEATURES_append_{{=machine}} += " cfg/smp.scc"
> diff --git a/scripts/lib/bsp/substrate/target/arch/qemu/recipes-kernel/linux/linux-yocto_4.1.bbappend b/scripts/lib/bsp/substrate/target/arch/qemu/recipes-kernel/linux/linux-yocto_4.1.bbappend
> index a9fd9ecff5a..13450f47438 100644
> --- a/scripts/lib/bsp/substrate/target/arch/qemu/recipes-kernel/linux/linux-yocto_4.1.bbappend
> +++ b/scripts/lib/bsp/substrate/target/arch/qemu/recipes-kernel/linux/linux-yocto_4.1.bbappend
> @@ -45,6 +45,7 @@ COMPATIBLE_MACHINE_{{=machine}} = "{{=machine}}"
> {{ if need_new_kbranch == "n": }}
> KBRANCH_{{=machine}} = "{{=existing_kbranch}}"
>
> +{{ if qemuarch != "arm": }}
> {{ input type:"boolean" name:"smp" prio:"30" msg:"Would you like SMP support? (y/n)" default:"y"}}
> {{ if smp == "y": }}
> KERNEL_FEATURES_append_{{=machine}} += " cfg/smp.scc"
> diff --git a/scripts/lib/bsp/substrate/target/arch/qemu/recipes-kernel/linux/linux-yocto_4.10.bbappend b/scripts/lib/bsp/substrate/target/arch/qemu/recipes-kernel/linux/linux-yocto_4.10.bbappend
> index 5873da4245c..e1af4976fc4 100644
> --- a/scripts/lib/bsp/substrate/target/arch/qemu/recipes-kernel/linux/linux-yocto_4.10.bbappend
> +++ b/scripts/lib/bsp/substrate/target/arch/qemu/recipes-kernel/linux/linux-yocto_4.10.bbappend
> @@ -45,6 +45,7 @@ COMPATIBLE_MACHINE_{{=machine}} = "{{=machine}}"
> {{ if need_new_kbranch == "n": }}
> KBRANCH_{{=machine}} = "{{=existing_kbranch}}"
>
> +{{ if qemuarch != "arm": }}
> {{ input type:"boolean" name:"smp" prio:"30" msg:"Would you like SMP support? (y/n)" default:"y"}}
> {{ if smp == "y": }}
> KERNEL_FEATURES_append_{{=machine}} += " cfg/smp.scc"
> diff --git a/scripts/lib/bsp/substrate/target/arch/qemu/recipes-kernel/linux/linux-yocto_4.4.bbappend b/scripts/lib/bsp/substrate/target/arch/qemu/recipes-kernel/linux/linux-yocto_4.4.bbappend
> index cdee7737983..a2511ba197c 100644
> --- a/scripts/lib/bsp/substrate/target/arch/qemu/recipes-kernel/linux/linux-yocto_4.4.bbappend
> +++ b/scripts/lib/bsp/substrate/target/arch/qemu/recipes-kernel/linux/linux-yocto_4.4.bbappend
> @@ -45,6 +45,7 @@ COMPATIBLE_MACHINE_{{=machine}} = "{{=machine}}"
> {{ if need_new_kbranch == "n": }}
> KBRANCH_{{=machine}} = "{{=existing_kbranch}}"
>
> +{{ if qemuarch != "arm": }}
> {{ input type:"boolean" name:"smp" prio:"30" msg:"Would you like SMP support? (y/n)" default:"y"}}
> {{ if smp == "y": }}
> KERNEL_FEATURES_append_{{=machine}} += " cfg/smp.scc"
> diff --git a/scripts/lib/bsp/substrate/target/arch/qemu/recipes-kernel/linux/linux-yocto_4.8.bbappend b/scripts/lib/bsp/substrate/target/arch/qemu/recipes-kernel/linux/linux-yocto_4.8.bbappend
> index 24c28803ee7..fdf66bb4429 100644
> --- a/scripts/lib/bsp/substrate/target/arch/qemu/recipes-kernel/linux/linux-yocto_4.8.bbappend
> +++ b/scripts/lib/bsp/substrate/target/arch/qemu/recipes-kernel/linux/linux-yocto_4.8.bbappend
> @@ -45,6 +45,7 @@ COMPATIBLE_MACHINE_{{=machine}} = "{{=machine}}"
> {{ if need_new_kbranch == "n": }}
> KBRANCH_{{=machine}} = "{{=existing_kbranch}}"
>
> +{{ if qemuarch != "arm": }}
> {{ input type:"boolean" name:"smp" prio:"30" msg:"Would you like SMP support? (y/n)" default:"y"}}
> {{ if smp == "y": }}
> KERNEL_FEATURES_append_{{=machine}} += " cfg/smp.scc"
> --
> 2.12.0
>
next prev parent reply other threads:[~2017-05-30 19:50 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-30 18:44 [PATCH] yocto-bsp: Fix QEMUARM based bsps to not offer SMP support Alejandro Hernandez
2017-05-30 19:59 ` Leonardo Sandoval [this message]
2017-05-30 20:12 ` Alejandro Hernandez
2017-05-30 22:32 ` Andre McCurdy
2017-05-30 22:52 ` Alejandro Hernandez
2017-05-31 1:11 ` Andre McCurdy
2017-05-31 1:15 ` Bruce Ashfield
2017-05-31 18:20 ` Andre McCurdy
2017-05-31 18:46 ` Khem Raj
2017-06-01 0:41 ` Alejandro Hernandez
2017-06-01 0:57 ` Khem Raj
-- strict thread matches above, loose matches on Subject: below --
2017-05-31 19:01 gmane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1496174354.26945.54.camel@linux.intel.com \
--to=leonardo.sandoval.gonzalez@linux.intel.com \
--cc=alejandro.hernandez@linux.intel.com \
--cc=yocto@yoctoproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.