From mboxrd@z Thu Jan 1 00:00:00 1970 From: leonard.crestez@nxp.com (Leonard Crestez) Date: Wed, 31 May 2017 01:20:16 +0300 Subject: [PATCH 1/2] ARM: dts: imx6ul-14x14-evk: Add ksz8081 phy properties In-Reply-To: <46bde649-c9ce-5a87-d4c4-1c1ebc5a8923@gmail.com> References: <46bde649-c9ce-5a87-d4c4-1c1ebc5a8923@gmail.com> Message-ID: <1496182816.19669.18.camel@nxp.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Tue, 2017-05-30 at 11:10 -0700, Florian Fainelli wrote: > On 05/30/2017 10:34 AM, Leonard Crestez wrote: > > Right now mach-imx6ul registers a fixup for the ksz8081 phy. The same > > register values can be set through the micrel phy driver by using dts > > properties. > > > > This seems preferable and allows cleanly fixing suspend/resume. > > > > Signed-off-by: Leonard Crestez > > Should you have a Fixes: tag for that? Sounds like something you'd want > to backport to stable trees as well, no? I don't know if suspend over nfs ever worked on this board in upstream so there is no commit that this patch "Fixes: ". It would make sense to CC stable. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751190AbdE3WUZ (ORCPT ); Tue, 30 May 2017 18:20:25 -0400 Received: from mail-bl2nam02on0069.outbound.protection.outlook.com ([104.47.38.69]:32099 "EHLO NAM02-BL2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750841AbdE3WUX (ORCPT ); Tue, 30 May 2017 18:20:23 -0400 Authentication-Results: spf=fail (sender IP is 192.88.168.50) smtp.mailfrom=nxp.com; vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=fail action=none header.from=nxp.com; Message-ID: <1496182816.19669.18.camel@nxp.com> Subject: Re: [PATCH 1/2] ARM: dts: imx6ul-14x14-evk: Add ksz8081 phy properties From: Leonard Crestez To: Florian Fainelli , Shawn Guo , Andrew Lunn , Andy Duan CC: Johan Hovold , Alexandre Belloni , Philipp Zabel , Fabio Estevam , , , Date: Wed, 31 May 2017 01:20:16 +0300 In-Reply-To: <46bde649-c9ce-5a87-d4c4-1c1ebc5a8923@gmail.com> References: <46bde649-c9ce-5a87-d4c4-1c1ebc5a8923@gmail.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.22.6-1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-Matching-Connectors: 131406564212198371;(91ab9b29-cfa4-454e-5278-08d120cd25b8);() X-Forefront-Antispam-Report: CIP:192.88.168.50;IPV:NLI;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(336005)(39410400002)(39450400003)(39860400002)(39380400002)(39400400002)(39840400002)(39850400002)(2980300002)(1109001)(1110001)(339900001)(199003)(377454003)(377424004)(189002)(24454002)(2950100002)(33646002)(229853002)(38730400002)(6636002)(6246003)(50466002)(498600001)(305945005)(106466001)(8656002)(76176999)(105606002)(77096006)(50986999)(68736007)(53936002)(7416002)(54906002)(36756003)(5820100001)(189998001)(85426001)(47776003)(2906002)(4326008)(230783001)(39060400002)(53546009)(104016004)(230700001)(86362001)(5660300001)(356003)(57986006)(23676002)(8936002)(50226002)(103116003)(8676002)(81166006)(99106002)(32563001);DIR:OUT;SFP:1101;SCL:1;SRVR:BN6PR03MB2804;H:tx30smr01.am.freescale.net;FPR:;SPF:Fail;MLV:ovrnspm;A:1;MX:1;PTR:InfoDomainNonexistent;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;BL2FFO11OLC016;1:6Bt0U+HE7ZR8qBAp8COUPpvfjN8Nzx6YhX83uo9pa924oszbmD6TBrr5VwC9GhWbhlcN4eSs7mfaGbVb3uIx9kDWMlJcsVuSwzo6BFJUdyUyz5ed9zcF+B0w4lvqi5LHAYRJRvgnZMDaVtJ2nmSVAygEVvVxQ7J7zbdJ3qBCwUVXjIiCEjGSJMkQ2BpAlTs4BTRpVJjXzop1wLw4UtUTl40LHhEyeIjaXsg1lNsNeUgaxd1p5AoPCrBmWhsmQpfIQHC3MB7p9vzIEE7UtxB8eK0nuFUKKvIiZ5542FVeJSi+XGZPqJafpiDYGpyL8Mp4pa7FnBr/7uK1VRJo7Kle8t6m1NCmR0V+H78I88sjN/TmMeUWrev2KcTy4ioMVSa9ZXNCF+O8PZVr7ByKpFdlJbuwchZ+zwULT7knQiCgcLPfQpQlvMxIWwNNJb07s9C/b60ZvKUsVEbTzVZpl3/wDMhbBht1I74NuZtk2YYmELIkCSWT9YRVdZ3oC5XhlKw6pipKIq/3jKExX9jJiOXp2I4p+JNYRyd1JOOOBING/4pjI4ycsJgtOrnx0lqd3Atu X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN6PR03MB2804: X-MS-Office365-Filtering-Correlation-Id: 84966d6c-8b3a-4060-cbe3-08d4a7aa0f7c X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(201703131430075)(201703131517081);SRVR:BN6PR03MB2804; X-Microsoft-Exchange-Diagnostics: 1;BN6PR03MB2804;3:Mhrj4XGNTfANbFgkmChkfFGUoKoq/3UVYW+w6ofytu6RvEpG+3ymF1PJoY9QzUKZB3JQ2glTNDwYaUFS2Q+dBYF5r2XUjUH4U6FWKG8GH3QSznzjjwN7OG+4zTMiYfwA29N6RTjkZ+nak1/tu5BsxU96vTcSui65xfDk4dc7E08Ujy88muGyaP23notT15F/3xC5S2kEnqhos5eKFXWr60tuCOdTq5uuNpHDIoyZ5PNE1gGuHtz616ai5EihFGs+eztq4EPZHxuYucgQFWCeXriWx+Hz4ztcWYGrBFbB5IQ9M4wg96obPeU2WI31iexsa+DXBFqNKVzT1Sawz8/y/IZ6f51m8gEFSstRndrbVblKClNzFIoR3uyaMR9pWSIzAYlgHU2iXY+R8MSK5QYsIWOyohlxZABQQFVINgS29cDKzXcGsaS6qcqOsTt0OSvc;25:aZBhfi2vF94/hGEPjd42Ueac8Glsg/j8Sxaz2BGb/btgEKHU3CxRuCItAX78GwaswGqPpEEAjKI9rn8kkzLZlV/YfOiAFmpGGF9132shYjfkPsCD0lqOB1PH74xYKi1LptQGfbPido6yM892jHYpDObT24vSFLMzmQ0gZWTwCfatJBts6RIAV8G0pTqXmAt9DxjCpxKVWaDeLGW0PvmwEg1ATpX3+BX+0Ekp8x/gaxrY2xgJ8rwMljyKomo45okdG7CQkiC1b3cDi6IwxXq5bjh73339G+6BYrkWUmVGCi2VhGkkayR3LjuJYyXe5C559LR7DXctLd4CFGDoenUPFG9lVuZ2pA7hK4AV9h7VlIle2IOXvt2nSFMQrrEfHvmCu1lVIUyz2FCsg1/BWkwJa/NYjiwtEdkscPS0FCXCjS8fdeS1oYUJOlBM3F2bywX6+SU5heeqZzBMzLshhD5evZVk24eFhQ/K57mhgOqVb08= X-Microsoft-Exchange-Diagnostics: 1;BN6PR03MB2804;31:d3TX6WEWfO76Nl3+0cNtQGA/6rcOc2gjdHZL21sikgD9QU0lBvzn2WEME+39g7wc+XQmovcPtuzwcpo2Lw4Y1A9f/+u5MpWfLMPO0zo37JJrOK+W0ZvIPkKu+ioktWodJn8RXBa7W/KSbpG3DhgPbzZZ2slnb05MnatZ3QZ9+rszYvfOJFsmhfrw45Faq5zUGNkOvH74xW2ha3ZzV4IQ5W7a7c8y62KyGvueAQx9FzoMcY+DmwhSasI9CZtuILcMnyfJ8q6y75elBgBgxGjbNw== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6095135)(601004)(2401047)(13018025)(13016025)(8121501046)(5005006)(93006095)(93001095)(3002001)(10201501046)(6055026)(6096035)(20161123561025)(201703131430075)(201703131433075)(201703131441075)(201703131448075)(201703161259150)(20161123556025)(20161123559100)(20161123563025)(20161123565025);SRVR:BN6PR03MB2804;BCL:0;PCL:0;RULEID:(400006);SRVR:BN6PR03MB2804; X-Microsoft-Exchange-Diagnostics: 1;BN6PR03MB2804;4:qvBTynwbrrpB4MpQO5z/ZMwWriF3MYVVo+zC6Nk7k3Qbx71QBfSLLBcZ01goERYd/gUM4mhzO3kCazZfdusyeaJolCZSTx29qDSV7nneilWKsDVifDOXboN2W1jnLC0vYqYK2gTXwNeVg3JymJ7EgTP+5QBWMU4vVB3Ot1G6OUn2AGxdKzfbU0ZleBO45HFUBa3/hebAOhD3s2gRBTTleLF1CER7qCGu0hcQXQediN2oR4hCAQknNaiqqP9kIsq1x84tblHjMT0xAB8GlAVxhyVHxp9bKSEImaDnAX1/YHM8ME+cNg/hdNTbW/9xRXTMW5/OBlZOmZqcOPsX0c1CDIpCG+qNjEAI0IPf++UrMKGioJT8aXbsba6TPKXsrT/7b0TDCKTUR6IHvrCLtdS4xw+zT+2r/C1V7oyMjIyOfm+bCcEXnQY/DxklfZEeAMaUbWOERaWL8OVFXcCgxiR1qpuWn2ArAJ/Z9toKpv3B3NlWMCYA6nZNM245/hY/GvI8nFC+45NJc6EileDZlbQdQLCCRVdXjeQtW3YoC6ViN5LxHsxusGhQkv6L/ODx4jfCkF5hoJhABJadfNy6j5GLMlZtQQJLdi8rPFcwpqFFK57lItblg6nucDwLCy+dmOgQZXkH3h/zVBu8K8rg6jpEY91WxDFH8OWuxYFIZFfrT63YsdrU5wJwrTS0PTD8EiyBUyD8z9KbaiYEEArtSkc6Xxfb4D7dmDPH/y+lY8zh806zQ01XwGgIe2h6750BmlWMFRs1xbT3XVrsA7dVMkscC27sHHu8FJZ08e5ljjb/De7yB4cDDGW5X+Jpr2lt7wgV8Hrzf8VN5w7rcOg4YnZFzt4iezKXF27FWa27GKXoyHwBuAXGyO4E8kyXOkmLtox/LbqTEbRNRsgPtqsgKXf6ZA== X-Forefront-PRVS: 032334F434 X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtCTjZQUjAzTUIyODA0OzIzOnU4dTB4cmJxMkVpbG93cWtEcHNGMFNXbWk0?= =?utf-8?B?MTM1TGg1MjdIL1AxQmM0TnkwZXpqTDdaZDVjMVlja1ovU1BrbVBMVWlLQmNL?= =?utf-8?B?bXg3NGorbDloUFRsUU01Z0cyNFZGOFFCZmxzd0FtU1l5US9zZUl0UXY5eUJO?= =?utf-8?B?M1o4UU8xQzJUYkJnM0Z6cXdHOGlJdmxRL3FVWGErNkVjNlJQelgzd05lSFpq?= =?utf-8?B?NFNCOTBhZ0VUS216Q3kvRmpnZTNqdjRFcXhXU25iZFd1YlpoSDYxbEg0NXN6?= =?utf-8?B?bmJ2NnBBS1dOTytPN3ZYSU44TE8yVW0rWGY4a0Z3bFpod0VpbW9HOS9lSmpl?= =?utf-8?B?aTMzTmhLclZYSExHMDFLYWRkRWVDTE9vcEJKUk8wa1JVNUIxYTJBeU8wTkhT?= =?utf-8?B?MGE2cURaTVdibXJsZnBuRXJUd3REWjNDVEVvVEU4VmV3bTUveU5GQ2hac2Np?= =?utf-8?B?RzF5TGlCTm9KSU1SUDc2U255REgwMXJkS255Mmp5b0pLZEJoK2RRbW44V3Rn?= =?utf-8?B?RFdwZGNhMzJxcjYvUlh4eFowTm41ZDJSYmJNSGN1RTRnaTdCRnBnWVpHMkdo?= =?utf-8?B?eG9qUUwxMkxtTFU1NmpKUHdOTGhwSU1OTXZORmZ2dlFwTmh1U3ZrdGk1ekxP?= =?utf-8?B?dkpYT3R0N3FkRG9MYWd5ejdUNzJEbnlJdDVSZmRuWHA0TGVWRHE3cnRILzhV?= =?utf-8?B?U2NDcUdocEZXY0U5RlJiUy9vdjVmei9pVjlveEpGZ3NWWW15c3h4RnQ0Rkpv?= =?utf-8?B?MjVNcmp0RlNSa25FUkpiRGl2NjREKytVYXZwSVpHaXM0WXc1UW45N0N1RVZt?= =?utf-8?B?ejRuendKVS9rRzVFZ2syaG9sY2hRQU9JSG1PY210WGJNb1QwOUxJL2NVSHFS?= =?utf-8?B?bHNIVWR1SEhnY0xReklhaU4wTDFkbnAzWENpYVZWRFNNWkc2RUZFM0V0dnJt?= =?utf-8?B?ZTRGK1V2S2VJQVFTZHZJWTNlYW5Gd2djVlZTRmhzUzk1Ui9hMmk2WEhyTzVu?= =?utf-8?B?VEhsYXNlTnJxMDhFZkxuS3NIMWJodVBiMi9USkFSOWcwZUxIQTA3a05PQjJm?= =?utf-8?B?OEFxc1NacUtLVXR4N3BUVWRPTjcxOGtyYjhzeEx4S08wY3hLSllHWGRvR2hi?= =?utf-8?B?V2MzSjZzZktlN2M3ZnhrZ09RY2hCb0tkZlF4ZmxIZ05jRW9JZW5yS0k0Vmtk?= =?utf-8?B?UmUySWVhNGlpaldBWVlTb3prNXNJem9MUUN4akpXSFRBZWZ3enVtbFNsMmdR?= =?utf-8?B?QlhLalBTZFROSm1mMmdPU1E2NWlNN3hwRUhBL1hZelFRUmZMNHVQaktZZldY?= =?utf-8?B?QlFET3oxOXhjTENyekRYRExLM1B4NnB1Z2poUEY3TTBDMW4yaTFyZzlJTDRY?= =?utf-8?B?RjIzZzgrRVFrKzhBdzVhZmsvTHNQcFAxdXZJb1Vic1JIUFd4MTYrbUQ3dHkw?= =?utf-8?B?cGJtaXozMjJaZWZDUzY1QjIvaEo5RVZTQnppSytudEVDSEYrWXJjaWsreEJT?= =?utf-8?B?VUxkRi9SVDJydmRWekpqZDBUVk5wdy9nYWVESWVPT0R2bDFqZ2lnbDhNdFVr?= =?utf-8?B?Q0xraUNRaHBlVDNGSzJHSHhCMUltRU1UM0Y0aWJncGc2bzVyd0h3RUdQcXN3?= =?utf-8?B?blpJQ1l6UnFFbmU2dDkvZEx0QzF2QmVSWHlJeWc2eDNZalFMOWhEM2h4RWNr?= =?utf-8?B?OGJJY1J3cVNnbXRxUEdMbGlhYUhwRklMTzg1S0JsTUwvY3RBekM4RWRDY0k5?= =?utf-8?B?TUN6b04vTmZJWWRGRjdTaHovandLTGpabE1qWUdiZCt5TFZTVldsTWlPbDlC?= =?utf-8?B?R0hxOFhna0tqdnZMYmltL3Jud3I2Qk5vTFRJMVNyOXhxS2FybmtKZy9pSWow?= =?utf-8?B?UDFwYjlFV05ONlFGMHprU2hTRHd6MENQUUZaUFhRWlk5R2ppd2ZUYkduc3p1?= =?utf-8?B?aDFBaUpiRHYzNWJPK29KZjhjQW8wcXVMcGo1TG5HcGU0QVpWTW5wNGJjZVFu?= =?utf-8?B?S1dGNzF6VEw3dEVHeUJUdEdDalNKU29MUDJKZz09?= X-Microsoft-Exchange-Diagnostics: 1;BN6PR03MB2804;6:RL0z44zw9WrGiYf8tFYTF3g//2nnmzJrB69Xj1myGfmDs8jMjI7Gi0g05Dm+d4pFZ//WTZwlYLsQ3RvLjb/rEirEc/h7M7XNvWBEuK1ZTNHDGiSXmMUZEAzcn1mf/inVd12bV+KXGR2x/TRMhi/9BGlJ6vL6KHdYcM5I0wwA7lJCu2Jljy/q+I10aesqgckpO2lGRPe7xDlQ2GDhnW5DRuOL0kBWb6Q2vQhpHRdOf33SRpk3bV37YwUNxdTameq03YPsWdRkeJP679pnRfRfVLa7tnVBQjTmSqtlyNCdbb3KDvGUx01Kmn0Fgflv/eEuL4mKB+XR9cKjUEPhaIcxEAR68NgJf1axxcgfOQOJIcMkHiELQgfgcd2RPPej5iPGWjyh91Fe50ldx8NHo7mktCtvrgMx11VhJrd3KKxdLgKhMfXTWMBIaW3q372odCFOHkKCTf3vQwrX7hGSreQg5kOBMWV//zpodhefQNb00M6DYXxr123UmR+2JSmf5H0guxwyu1eDoLd+1JrDqiuf6A==;5:8Z/fsRiZOOSgAOnwdsK8uW24TDc09ZFsHtScOBo1ebil9WlA5M7fDEukH4g5kNesxGax2KajOiVzn2lRNhtQB0jR4D8CT24htCPgMlAjfb0+zmxUsMGxBRI6pWco4c8WVHlMvezWtVP3f0JOX0MoYchzc2IcnPbc7qdACCO9xa3poyY1bWtNsTKjdXVQ/PAp;24:mPq+fuXqopA8GFRrkuO5vURCYBSFujGCUa1+2gw6iuHS5pJLFHyp2X/c48LDvlcjK5+zBU2859z1gzrfDypulsmwJSJg+EShIXloVKdKAu8= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;BN6PR03MB2804;7:u5wJijOp46Hukc4itBzFx//IzSUVvWdIfrO+Tqlh0N01BrG6MOSD4i4Ye9zft45tXKEZpCD/Uy+EV6wLrBCTtATiyacuqyDyAidy0r0FR+FoimCCUnasHr89RGrr/6vDT0xEGxFpgyBWgtP+ZlC2l1hJaPppW6U3ug1Rp4eb8wqL+M1uDYQ9seWcGOMUAGAgRF6kzIZVB1V+3V1u7Ec1Y0imIZgdlT89ML2GSjnk13i93yyMGLWA47mAz6TvRTfDUN9gEIGNeflTeLFju2xcrUyrkmZB9GlHwOpvDJ8r++RdBYHIscfkl6TSXRE5GNBD9z0OAqGSMIQnasV6DliiNA== X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 May 2017 22:20:20.8142 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e;Ip=[192.88.168.50];Helo=[tx30smr01.am.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR03MB2804 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2017-05-30 at 11:10 -0700, Florian Fainelli wrote: > On 05/30/2017 10:34 AM, Leonard Crestez wrote: > > Right now mach-imx6ul registers a fixup for the ksz8081 phy. The same > > register values can be set through the micrel phy driver by using dts > > properties. > > > > This seems preferable and allows cleanly fixing suspend/resume. > > > > Signed-off-by: Leonard Crestez > > Should you have a Fixes: tag for that? Sounds like something you'd want > to backport to stable trees as well, no? I don't know if suspend over nfs ever worked on this board in upstream so there is no commit that this patch "Fixes: ". It would make sense to CC stable.