From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751182AbdEaBly (ORCPT ); Tue, 30 May 2017 21:41:54 -0400 Received: from smtprelay0033.hostedemail.com ([216.40.44.33]:52522 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750912AbdEaBlx (ORCPT ); Tue, 30 May 2017 21:41:53 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 50,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::,RULES_HIT:41:355:379:541:599:967:973:981:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:1801:2393:2525:2561:2564:2682:2685:2828:2859:2933:2937:2939:2942:2945:2947:2951:2954:3022:3138:3139:3140:3141:3142:3352:3865:3866:3867:3870:3871:3873:3934:3936:3938:3941:3944:3947:3950:3953:3956:3959:4321:4362:4605:5007:6119:7903:9010:9025:10004:10394:10400:10848:11026:11232:11473:11658:11914:12043:12266:12295:12296:12438:12555:12740:12760:12895:13069:13255:13311:13357:13439:13870:14180:14181:14659:14721:21080:21365:21434:21451:21627:30029:30054:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:1,LUA_SUMMARY:none X-HE-Tag: sheet29_8476db9bcf21f X-Filterd-Recvd-Size: 2745 Message-ID: <1496194908.2618.41.camel@perches.com> Subject: Re: [rcu:rcu/next 97/97] arch/blackfin/kernel/module.c:20:25: error: expected ')' before 'fmt' From: Joe Perches To: kbuild test robot , "Paul E. McKenney" Cc: kbuild-all@01.org, linux-kernel@vger.kernel.org Date: Tue, 30 May 2017 18:41:48 -0700 In-Reply-To: <201705310853.mFjeKUkH%fengguang.wu@intel.com> References: <201705310853.mFjeKUkH%fengguang.wu@intel.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.22.6-1ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hey Paul. Can you please fix the mod_debug macro definition as described below? Thanks. Joe On Wed, 2017-05-31 at 08:48 +0800, kbuild test robot wrote: > tree: https://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git rcu/next > head: 19223c8730d289cd4c65b46250b3e02a6752803c > commit: 19223c8730d289cd4c65b46250b3e02a6752803c [97/97] module: Fix pr_fmt() bug for header use of printk > config: blackfin-allmodconfig (attached as .config) > compiler: bfin-uclinux-gcc (GCC) 6.2.0 > reproduce: > wget https://raw.githubusercontent.com/01org/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross > chmod +x ~/bin/make.cross > git checkout 19223c8730d289cd4c65b46250b3e02a6752803c > # save the attached .config to linux build tree > make.cross ARCH=blackfin > > All error/warnings (new ones prefixed by >>): > > In file included from include/linux/printk.h:329:0, > from include/linux/kernel.h:13, > from include/linux/list.h:8, > from include/linux/module.h:9, > from include/linux/moduleloader.h:5, > from arch/blackfin/kernel/module.c:7: > arch/blackfin/kernel/module.c: In function 'apply_relocate_add': > > > arch/blackfin/kernel/module.c:20:25: error: expected ')' before 'fmt' > > pr_debug("module %s: " fmt, (mod)->name, ##__VA_ARGS__) > ^ > include/linux/dynamic_debug.h:79:14: note: in definition of macro 'DEFINE_DYNAMIC_DEBUG_METADATA_KEY' > .format = (fmt), \ [] > vim +20 arch/blackfin/kernel/module.c > [] > 19 #define mod_debug(mod, ...) \ duh. This line needs to be: #define mod_debug(mod, fmt, ...) \ so fmt is one of the arguments to mod_debug > > 20 pr_debug("module %s: " fmt, (mod)->name, ##__VA_ARGS__)