From: Jeff Layton <jlayton@redhat.com>
To: Benjamin Coddington <bcodding@redhat.com>,
Alexander Viro <viro@zeniv.linux.org.uk>,
bfields@fieldses.org
Cc: Christoph Hellwig <hch@infradead.org>,
linux-fsdevel@vger.kernel.org, linux-nfs@vger.kernel.org
Subject: Re: [PATCH v2 0/3] Fixups for l_pid
Date: Wed, 31 May 2017 13:16:51 -0400 [thread overview]
Message-ID: <1496251011.2984.2.camel@redhat.com> (raw)
In-Reply-To: <cover.1496161312.git.bcodding@redhat.com>
On Tue, 2017-05-30 at 12:31 -0400, Benjamin Coddington wrote:
> LTP fcntl tests (fcntl11 fcntl14 fcntl17 fcntl19 fcntl20 fcntl21) have been
> failing for NFSv4 mounts due to an unexpected l_pid. What follows are some
> fixups:
>
> on v2:
> - Rebase onto linux-next
> - Revert back to using the stack in locks_mandatory_area(), and fixup
> patch description for 1/3
> - Add a comment to 3/3 explaining the seemingly-redundant fl_pid and
> fl_nspid
>
> These three patches can be pulled from the branch named "fixups_for_l_pid"
> here: git://bcodding.com/~bcodding/linux
>
> Benjamin Coddington (3):
> fs/locks: Use allocation rather than the stack in fcntl_getlk()
> fs/locks: Set fl_nspid at file_lock allocation
> fs/locks: Use fs-specific l_pid for remote locks
>
> fs/locks.c | 100 ++++++++++++++++++++++++++++++++++-------------------
> include/linux/fs.h | 7 ++++
> 2 files changed, 72 insertions(+), 35 deletions(-)
>
This all looks good to me. Nice work!
I've gone ahead and merged it into my linux-next branch, and it should
make v4.13 (barring any problems).
Thanks!
--
Jeff Layton <jlayton@redhat.com>
prev parent reply other threads:[~2017-05-31 17:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-30 16:31 [PATCH v2 0/3] Fixups for l_pid Benjamin Coddington
2017-05-30 16:31 ` [PATCH v2 1/3] fs/locks: Use allocation rather than the stack in fcntl_getlk() Benjamin Coddington
2017-05-30 16:31 ` [PATCH v2 2/3] fs/locks: Set fl_nspid at file_lock allocation Benjamin Coddington
2017-06-05 2:19 ` [lkp-robot] [fs/locks] 4a4b31973e: will-it-scale.per_thread_ops -80.7% regression kernel test robot
2017-05-30 16:31 ` [PATCH v2 3/3] fs/locks: Use fs-specific l_pid for remote locks Benjamin Coddington
2017-05-31 17:16 ` Jeff Layton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1496251011.2984.2.camel@redhat.com \
--to=jlayton@redhat.com \
--cc=bcodding@redhat.com \
--cc=bfields@fieldses.org \
--cc=hch@infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.