From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Message-ID: <1496254594.28981.37.camel@linux.intel.com> Subject: Re: [PATCH 15/24] block: remove blk_part_pack_uuid From: Andy Shevchenko To: Christoph Hellwig , Amir Goldstein , linux-fsdevel@vger.kernel.org Cc: Shaohua Li , Dan Williams , David Howells , Steven Whitehouse , Mimi Zohar , linux-xfs@vger.kernel.org, linux-raid@vger.kernel.org, linux-nvdimm@lists.01.org, linux-kernel@vger.kernel.org, linux-block@vger.kernel.org Date: Wed, 31 May 2017 21:16:34 +0300 In-Reply-To: <20170531161826.23243-16-hch@lst.de> References: <20170531161826.23243-1-hch@lst.de> <20170531161826.23243-16-hch@lst.de> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Wed, 2017-05-31 at 18:18 +0200, Christoph Hellwig wrote: > This helper was only used by IMA of all things, which would get > spurious > errors if CONFIG_BLOCK is disabled.  Just opencode the call there. > - result = blk_part_pack_uuid(args[0].from, > -     entry->fsuuid); > + result = uuid_to_bin(args[0].from, (uuid_t > *)&entry->fsuuid); > uuid_parse() ? -- Andy Shevchenko Intel Finland Oy From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id E22782095A58F for ; Wed, 31 May 2017 11:15:37 -0700 (PDT) Message-ID: <1496254594.28981.37.camel@linux.intel.com> Subject: Re: [PATCH 15/24] block: remove blk_part_pack_uuid From: Andy Shevchenko Date: Wed, 31 May 2017 21:16:34 +0300 In-Reply-To: <20170531161826.23243-16-hch@lst.de> References: <20170531161826.23243-1-hch@lst.de> <20170531161826.23243-16-hch@lst.de> Mime-Version: 1.0 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: linux-nvdimm-bounces@lists.01.org Sender: "Linux-nvdimm" To: Christoph Hellwig , Amir Goldstein , linux-fsdevel@vger.kernel.org Cc: linux-xfs@vger.kernel.org, linux-raid@vger.kernel.org, linux-nvdimm@lists.01.org, Shaohua Li , linux-kernel@vger.kernel.org, David Howells , linux-block@vger.kernel.org, Mimi Zohar , Steven Whitehouse List-ID: T24gV2VkLCAyMDE3LTA1LTMxIGF0IDE4OjE4ICswMjAwLCBDaHJpc3RvcGggSGVsbHdpZyB3cm90 ZToKPiBUaGlzIGhlbHBlciB3YXMgb25seSB1c2VkIGJ5IElNQSBvZiBhbGwgdGhpbmdzLCB3aGlj aCB3b3VsZCBnZXQKPiBzcHVyaW91cwo+IGVycm9ycyBpZiBDT05GSUdfQkxPQ0sgaXMgZGlzYWJs ZWQuwqDCoEp1c3Qgb3BlbmNvZGUgdGhlIGNhbGwgdGhlcmUuCgo+IC0JCQlyZXN1bHQgPSBibGtf cGFydF9wYWNrX3V1aWQoYXJnc1swXS5mcm9tLAo+IC0JCQkJCQnCoMKgwqDCoGVudHJ5LT5mc3V1 aWQpOwo+ICsJCQlyZXN1bHQgPSB1dWlkX3RvX2JpbihhcmdzWzBdLmZyb20sICh1dWlkX3QKPiAq KSZlbnRyeS0+ZnN1dWlkKTsKPiAKCnV1aWRfcGFyc2UoKSA/CgotLSAKQW5keSBTaGV2Y2hlbmtv IDxhbmRyaXkuc2hldmNoZW5rb0BsaW51eC5pbnRlbC5jb20+CkludGVsIEZpbmxhbmQgT3kKX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KTGludXgtbnZkaW1t IG1haWxpbmcgbGlzdApMaW51eC1udmRpbW1AbGlzdHMuMDEub3JnCmh0dHBzOi8vbGlzdHMuMDEu b3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtbnZkaW1tCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751067AbdEaSQl (ORCPT ); Wed, 31 May 2017 14:16:41 -0400 Received: from mga06.intel.com ([134.134.136.31]:13969 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750898AbdEaSQj (ORCPT ); Wed, 31 May 2017 14:16:39 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.39,275,1493708400"; d="scan'208";a="268615808" Message-ID: <1496254594.28981.37.camel@linux.intel.com> Subject: Re: [PATCH 15/24] block: remove blk_part_pack_uuid From: Andy Shevchenko To: Christoph Hellwig , Amir Goldstein , linux-fsdevel@vger.kernel.org Cc: Shaohua Li , Dan Williams , David Howells , Steven Whitehouse , Mimi Zohar , linux-xfs@vger.kernel.org, linux-raid@vger.kernel.org, linux-nvdimm@ml01.01.org, linux-kernel@vger.kernel.org, linux-block@vger.kernel.org Date: Wed, 31 May 2017 21:16:34 +0300 In-Reply-To: <20170531161826.23243-16-hch@lst.de> References: <20170531161826.23243-1-hch@lst.de> <20170531161826.23243-16-hch@lst.de> Organization: Intel Finland Oy Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.22.6-1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2017-05-31 at 18:18 +0200, Christoph Hellwig wrote: > This helper was only used by IMA of all things, which would get > spurious > errors if CONFIG_BLOCK is disabled.  Just opencode the call there. > - result = blk_part_pack_uuid(args[0].from, > -     entry->fsuuid); > + result = uuid_to_bin(args[0].from, (uuid_t > *)&entry->fsuuid); > uuid_parse() ? -- Andy Shevchenko Intel Finland Oy