Re: [Resend][PATCH 01/17] rb_tree: reorganize code in rb_erase() for additional changes

[Dario Faggioli <dario.faggioli@citrix.com>]

[-- Attachment #1.1: Type: text/plain, Size: 2028 bytes --]

On Wed, 2017-05-31 at 23:56 +0100, Andrew Cooper wrote:
> As an example, see
> 
> http://xenbits.xen.org/gitweb/?p=xen.git;a=commitdiff;h=b01c2fb5834ae
> a0328db55c310caa34173021d3d
> 
Nice, I especially like how the changelog looks, i.e.:
 - original Linux patch description description
 - Linux's Signed-off-by, Reviewed-by, Acked-by, etc.
 - ref to Linux commit id
 - a line with "Ported to Xen."
 - author of the port's Signed-off-by
 - (Reviewed-by, Acked-by, etc. coming from xen-devel)

Praveen, I suggest using the same pattern (if you also like it, of
course :-D).

Using patch 1 as an example, that would mean the following:

  Subject: [PATCH 01/17] rb_tree: reorganize code in rb_erase() for additional changes

  First, move some code around in order to make the next change more 
  obvious.

  [akpm@linux-foundation.org: coding-style fixes]
  Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
  Signed-off-by: Wolfram Strepp <wstrepp@gmx.de>
  Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
  Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
  [Linux commit 16c047add3ceaf0ab882e3e094d1ec904d02312d]

  Ported to Xen.

  Signed-off-by: Praveen Kumar <kpraveen.lkml@gmail.com>
  ---

> The way I prepare series like this for email is to use `git format-
> patch
> staging --cover-letter` to render the entire series as patch files in
> the local directory,  edit each patch to put suitable Cc: lines
> beside
> the From: header, then `git send-email --dry-run *.patch
> --suppress-cc=all` to check what it will actually send.  The Cc's in
> the
> header section are included, but no automatic Cc's are generated from
> content in the body.
> 
Cool to know, thanks.

Dario
-- 
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)

[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

[-- Attachment #2: Type: text/plain, Size: 127 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel