From: Leonardo Sandoval <leonardo.sandoval.gonzalez@linux.intel.com>
To: "Gan, Yau Wai" <yau.wai.gan@intel.com>
Cc: Gan@mail.openembedded.org, openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] insane.bbclass: fix override handling in RDEPENDS QA
Date: Thu, 01 Jun 2017 10:09:29 -0500 [thread overview]
Message-ID: <1496329769.26945.72.camel@linux.intel.com> (raw)
In-Reply-To: <1496276679-137217-1-git-send-email-yau.wai.gan@intel.com>
On Wed, 2017-05-31 at 17:24 -0700, Gan, Yau Wai wrote:
> The package_qa_check_rdepends() in insane.bbclass has
> incorrectly replace its localdata OVERRIDES value with
> the package name. Fixing it by appending the package name
> to the existing OVERRIDES value. This resolves RDEPENDS QA
> error when setting PACKAGECONFIG using a pn- override at
> local.conf.
>
> [YOCTO #11374]
>
> Signed-off-by: Gan, Yau Wai <yau.wai.gan@intel.com>
> ---
> meta/classes/insane.bbclass | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/classes/insane.bbclass b/meta/classes/insane.bbclass
> index dc1c2f8..5a3d017 100644
> --- a/meta/classes/insane.bbclass
> +++ b/meta/classes/insane.bbclass
> @@ -867,7 +867,7 @@ def package_qa_check_rdepends(pkg, pkgdest, skip, taskdeps, packages, d):
>
> if not "-dbg" in pkg and not "packagegroup-" in pkg and not "-image" in pkg:
> localdata = bb.data.createCopy(d)
> - localdata.setVar('OVERRIDES', pkg)
> + localdata.setVar('OVERRIDES', localdata.getVar('OVERRIDES') + ':' + pkg)
you may use localdata.appendVar instead of setting the value again.
>
> # Now check the RDEPENDS
> rdepends = bb.utils.explode_deps(localdata.getVar('RDEPENDS') or "")
> --
> 2.7.4
>
prev parent reply other threads:[~2017-06-01 15:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-01 0:24 [PATCH] insane.bbclass: fix override handling in RDEPENDS QA Gan, Yau Wai
2017-06-01 15:09 ` Leonardo Sandoval [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1496329769.26945.72.camel@linux.intel.com \
--to=leonardo.sandoval.gonzalez@linux.intel.com \
--cc=Gan@mail.openembedded.org \
--cc=openembedded-core@lists.openembedded.org \
--cc=yau.wai.gan@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.