From: Bart Van Assche <Bart.VanAssche@sandisk.com>
To: "hch@lst.de" <hch@lst.de>, "axboe@kernel.dk" <axboe@kernel.dk>
Cc: "osandov@fb.com" <osandov@fb.com>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"hare@suse.com" <hare@suse.com>
Subject: Re: [PATCH v2 12/12] block: Rename blk_mq_rq_{to,from}_pdu()
Date: Thu, 1 Jun 2017 19:17:03 +0000 [thread overview]
Message-ID: <1496344622.3075.10.camel@sandisk.com> (raw)
In-Reply-To: <4ffd4d62-0e2d-0eb9-aa9a-0550363259d4@kernel.dk>
On Thu, 2017-06-01 at 12:06 -0700, Jens Axboe wrote:
> On 06/01/2017 06:11 AM, Bart Van Assche wrote:
> > On Thu, 2017-06-01 at 08:08 +0200, Christoph Hellwig wrote:
> > > On Wed, May 31, 2017 at 03:52:46PM -0700, Bart Van Assche wrote:
> > > > Commit 6d247d7f71d1 ("block: allow specifying size for extra comman=
d
> > > > data") added support for .cmd_size to blk-sq. Due to that patch the
> > > > blk_mq_rq_{to,from}_pdu() functions are also useful for single-queu=
e
> > > > block drivers. Hence remove "_mq" from the name of these functions.
> > > > This patch does not change any functionality. Most of this patch ha=
s
> > > > been generated by running the following shell command:
> > >=20
> > > I don't really see the point of this as it's primarily a blk-mq API
> > > and we still hope to get rid of the old code. But I'm not necessaril=
y
> > > against it either.
> >=20
> > I would like to introduce calls to these functions in several scsi-sq
> > functions. If I would do that without renaming these functions then any=
one
> > who reads the code of these functions and sees calls to functions with =
a
> > blk_mq_ prefix could get really confused when trying to figure out whet=
her
> > these functions are used by scsi-sq, scsi-mq or perhaps both.
>=20
> But that should go away, eventually.
Hello Jens,
I agree that we should work towards removal of the single queue block layer=
.
But how long will it take before that code is removed?
Due to recent patches from Christoph the 'request' member in struct scsi_cm=
nd
is now superfluous. I'd like to replace accesses to that member by a call t=
o
blk_mq_rq_from_pdu(). I'm afraid that doing that in scsi-sq code paths will
make that code look weird.
Bart.=
next prev parent reply other threads:[~2017-06-01 19:17 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-31 22:52 [PATCH v2 00/12] More patches for kernel v4.13 Bart Van Assche
2017-05-31 22:52 ` [PATCH v2 01/12] block: Make request operation type argument declarations consistent Bart Van Assche
2017-05-31 22:52 ` [PATCH v2 02/12] block: Introduce request_queue.initialize_rq_fn() Bart Van Assche
2017-06-01 6:06 ` Christoph Hellwig
2017-05-31 22:52 ` [PATCH v2 03/12] block: Make most scsi_req_init() calls implicit Bart Van Assche
2017-06-01 6:08 ` Christoph Hellwig
2017-05-31 22:52 ` [PATCH v2 04/12] block: Change argument type of scsi_req_init() Bart Van Assche
2017-05-31 22:52 ` [PATCH v2 05/12] blk-mq: Initialize a request before assigning a tag Bart Van Assche
2017-06-01 6:09 ` Christoph Hellwig
2017-05-31 22:52 ` [PATCH v2 06/12] block: Add a comment above queue_lockdep_assert_held() Bart Van Assche
2017-05-31 22:52 ` [PATCH v2 07/12] block: Check locking assumptions at runtime Bart Van Assche
2017-06-01 6:09 ` Christoph Hellwig
2017-05-31 22:52 ` [PATCH v2 08/12] block: Document what queue type each function is intended for Bart Van Assche
2017-06-01 6:10 ` Christoph Hellwig
2017-05-31 22:52 ` [PATCH v2 09/12] blk-mq: Document locking assumptions Bart Van Assche
2017-06-01 6:11 ` Christoph Hellwig
2017-05-31 22:52 ` [PATCH v2 10/12] block: Constify disk_type Bart Van Assche
2017-05-31 22:52 ` [PATCH v2 11/12] blk-mq: Warn when attempting to run a hardware queue that is not mapped Bart Van Assche
2017-06-01 6:11 ` Christoph Hellwig
2017-05-31 22:52 ` [PATCH v2 12/12] block: Rename blk_mq_rq_{to,from}_pdu() Bart Van Assche
2017-06-01 6:08 ` Christoph Hellwig
2017-06-01 13:11 ` Bart Van Assche
2017-06-01 19:06 ` Jens Axboe
2017-06-01 19:17 ` Bart Van Assche [this message]
2017-06-01 19:28 ` Jens Axboe
2017-06-01 19:04 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1496344622.3075.10.camel@sandisk.com \
--to=bart.vanassche@sandisk.com \
--cc=axboe@kernel.dk \
--cc=hare@suse.com \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=osandov@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.