Re: [PATCH rdma-rc v1] IB/uverbs: Declare local function to be static and add brackets to sizeof

[Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>]

On Thu, 2017-05-18 at 07:40 +0300, Leon Romanovsky wrote:
> From: Leon Romanovsky <leonro-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
> 
> Commit 57520751445b ("IB/SA: Add OPA path record type") introduced
> new local function __ib_copy_path_rec_to_user, but didn't limit its
> scope. This produces the following sparse warning:
> 
>         drivers/infiniband/core/uverbs_marshall.c:99:6: warning:
>         symbol '__ib_copy_path_rec_to_user' was not declared. Should
> it be
>         static?
> 
> In addition, it used sizeof ... notations instead of sizeof(...),
> which
> is correct in C, but a little bit misleading. Let's change it too.
> 
> Fixes: 57520751445b ("IB/SA: Add OPA path record type")
> Reviewed-by: Yuval Shaia <yuval.shaia-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
> Signed-off-by: Leon Romanovsky <leonro-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>

Thanks, applied.

-- 
Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
    GPG KeyID: B826A3330E572FDD
   
Key fingerprint = AE6B 1BDA 122B 23B4 265B  1274 B826 A333 0E57 2FDD

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html