All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Lai Jiangshan <jiangshanlai@gmail.com>
Cc: Tejun Heo <tj@kernel.org>, linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: single-threaded wq lockdep is broken
Date: Fri, 02 Jun 2017 10:51:48 +0200	[thread overview]
Message-ID: <1496393508.20223.0.camel@sipsolutions.net> (raw)
In-Reply-To: <CAJhGHyCks3S_UFoFtiE-wC+Q1Lv4+1EAwn=m6L=hYtBPfHz3EQ@mail.gmail.com> (sfid-20170602_090400_729536_8FF35C48)

On Fri, 2017-06-02 at 15:03 +0800, Lai Jiangshan wrote:
> 
> the @w2 is not queued before flush_work(&w2), it is expected
> that @w2 is not associated with @wq, and the dependence
> mtx -> wq will not be recorded. And it is expected no warning.

Lockdep is symmetric. So then maybe it won't warn when executing
flush_work(), but should later when executing @w2. No real difference?

johannes

  reply	other threads:[~2017-06-02  8:51 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-28 19:33 single-threaded wq lockdep is broken Johannes Berg
2017-05-31  8:34 ` Lai Jiangshan
2017-05-31  8:36   ` Johannes Berg
2017-05-31  8:47     ` Johannes Berg
2017-06-02  7:03     ` Lai Jiangshan
2017-06-02  8:51       ` Johannes Berg [this message]
2017-05-31 18:19 ` Tejun Heo
2017-05-31 19:15   ` Johannes Berg
2017-06-13 16:06 ` Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1496393508.20223.0.camel@sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=jiangshanlai@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.