All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joshua Lock <joshua.g.lock@linux.intel.com>
To: Jose Lamego <jose.a.lamego@linux.intel.com>, yocto@yoctoproject.org
Subject: Re: [yocto-autobuilder][PATCH] forcebuild: allow build with default options
Date: Fri, 02 Jun 2017 16:55:12 +0100	[thread overview]
Message-ID: <1496418912.4307.0.camel@linux.intel.com> (raw)
In-Reply-To: <1496338372-20109-1-git-send-email-jose.a.lamego@linux.intel.com>

On Thu, 2017-06-01 at 12:32 -0500, Jose Lamego wrote:
> From: Anibal Limon <anibal.limon@linux.intel.com>
> 
> A forced build fails if no options are passed through command
> line (using "-o OPTIONS").
> 
> This change allows build to use default options if none are passed
> at the command line.

Useful. Merged, thanks!

Joshua

> Signed-off-by: Jose Lamego <jose.a.lamego@linux.intel.com>
> ---
>  bin/forcebuild.py | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/bin/forcebuild.py b/bin/forcebuild.py
> index 5fe61a0..e6770a4 100755
> --- a/bin/forcebuild.py
> +++ b/bin/forcebuild.py
> @@ -108,7 +108,11 @@ class YoctoAutobuilderAPI(object):
>                      % (builder, state))
>              return 1
>  
> -        opts = eval(opts) # FIXME: transform string argument into
> dictionary, security?
> +        if opts:
> +            # FIXME: transform string argument into dictionary,
> security?
> +            opts = eval(opts)
> +        else:
> +            opts = {}
>          current_opts = self._get_options_by_builder(builder)
>          for opt in opts:
>              if not opt in current_opts:
> -- 
> 2.7.4
> 


      parent reply	other threads:[~2017-06-02 15:55 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-01 17:32 [yocto-autobuilder][PATCH] forcebuild: allow build with default options Jose Lamego
2017-06-01 18:48 ` Aníbal Limón
2017-06-02 15:55 ` Joshua Lock [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1496418912.4307.0.camel@linux.intel.com \
    --to=joshua.g.lock@linux.intel.com \
    --cc=jose.a.lamego@linux.intel.com \
    --cc=yocto@yoctoproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.