From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Christoph Hellwig <hch@lst.de>,
Linus Torvalds <torvalds@linux-foundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: new tree for linux-next: uuid
Date: Mon, 05 Jun 2017 17:43:18 +0300 [thread overview]
Message-ID: <1496673798.22624.9.camel@linux.intel.com> (raw)
In-Reply-To: <20170606002914.695e9c0b@canb.auug.org.au>
On Tue, 2017-06-06 at 00:29 +1000, Stephen Rothwell wrote:
> Hi Andy,
>
> On Mon, 05 Jun 2017 17:06:45 +0300 Andy Shevchenko <andriy.shevchenko@
> linux.intel.com> wrote:
> >
> > On Mon, 2017-06-05 at 10:07 +0200, Christoph Hellwig wrote:
> > > Meh, thanks. This has been throught the buildbot countless times
> > > without a report. But I guess a less generic name might be a good
> > > idea to start with.
> > >
> > > Andy: do you think UUID_INIT/GUID_INIT make sense to your?
> > > or _INITIALIZER?
> >
> > I'm a bit out of context. Where this will be used?
>
> include/uapi/linux/uuid.h (after the uuid lib changes) contains a
> definition of the macro GUID() which is probably a bit generic a name
> for a uapi include file. It also clashes with a couple of other uses
> of that macro name already in the kernel (one of which produced
> several
> warnings in linux-next today).
>
> It produces an initializer for a guid_t (structure).
Just had read and finished answering to a warning.
In kernel users shouldn't really use so generic names, we may fix it.
OTOH, for user space I dunno if need to export that at all.
If we need by some reason, shorter version looks better, GUID_INIT(),
UUID_INIT()...
--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy
next prev parent reply other threads:[~2017-06-05 14:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-04 20:14 new tree for linux-next: uuid Christoph Hellwig
2017-06-04 23:49 ` Stephen Rothwell
2017-06-05 8:07 ` Christoph Hellwig
2017-06-05 14:06 ` Andy Shevchenko
2017-06-05 14:29 ` Stephen Rothwell
2017-06-05 14:43 ` Andy Shevchenko [this message]
2017-06-05 14:55 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1496673798.22624.9.camel@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.