From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Subject: Re: [PATCH v2 1/5] acpi,
	nfit: Switch to use new generic UUID API
Date: Mon, 05 Jun 2017 19:18:49 +0300
Message-ID: <1496679529.22624.14.camel@linux.intel.com>
References: <20170531194152.65927-1-andriy.shevchenko@linux.intel.com>
 <20170531194152.65927-2-andriy.shevchenko@linux.intel.com>
 <20170605160102.GA29981@lst.de>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
In-Reply-To: <20170605160102.GA29981@lst.de>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Christoph Hellwig <hch@lst.de>
Cc: intel-gfx@lists.freedesktop.org, "Rafael J . Wysocki" <rjw@rjwysocki.net>, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, Dan Williams <dan.j.williams@intel.com>, Borislav Petkov <bp@suse.de>, Mika Westerberg <mika.westerberg@linux.intel.com>
List-Id: linux-acpi@vger.kernel.org

T24gTW9uLCAyMDE3LTA2LTA1IGF0IDE4OjAxICswMjAwLCBDaHJpc3RvcGggSGVsbHdpZyB3cm90
ZToKPiA+IMKgCWZvciAoaSA9IDA7IGkgPCBORklUX1VVSURfTUFYOyBpKyspCj4gPiAtCQlpZiAo
bWVtY21wKHRvX25maXRfdXVpZChpKSwgc3BhLT5yYW5nZV9ndWlkLCAxNikgPT0KPiA+IDApCj4g
PiArCQlpZiAoIWd1aWRfZXF1YWwodG9fbmZpdF91dWlkKGkpLCAoZ3VpZF90ICopJnNwYS0KPiA+
ID5yYW5nZV9ndWlkKSkKPiA+IMKgCQkJcmV0dXJuIGk7Cj4gCj4gSSB0aGluayB0aGlzIHNob3Vs
ZCBiZSBndWlkX2VxdWFsIHdpdGhvdXQgdGhlICIhIgoKUmlnaHQuCgoKLS0gCkFuZHkgU2hldmNo
ZW5rbyA8YW5kcml5LnNoZXZjaGVua29AbGludXguaW50ZWwuY29tPgpJbnRlbCBGaW5sYW5kIE95
Cl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdm
eCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xp
c3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=

From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751635AbdFEQTC (ORCPT <rfc822;w@1wt.eu>);
        Mon, 5 Jun 2017 12:19:02 -0400
Received: from mga03.intel.com ([134.134.136.65]:11323 "EHLO mga03.intel.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751614AbdFEQS7 (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 5 Jun 2017 12:18:59 -0400
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.39,302,1493708400"; 
   d="scan'208";a="864756004"
Message-ID: <1496679529.22624.14.camel@linux.intel.com>
Subject: Re: [PATCH v2 1/5] acpi, nfit: Switch to use new generic UUID API
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Christoph Hellwig <hch@lst.de>
Cc: linux-kernel@vger.kernel.org, "Rafael J . Wysocki" <rjw@rjwysocki.net>,
        linux-acpi@vger.kernel.org, Dan Williams <dan.j.williams@intel.com>,
        Mika Westerberg <mika.westerberg@linux.intel.com>,
        Borislav Petkov <bp@suse.de>, intel-gfx@lists.freedesktop.org
Date: Mon, 05 Jun 2017 19:18:49 +0300
In-Reply-To: <20170605160102.GA29981@lst.de>
References: <20170531194152.65927-1-andriy.shevchenko@linux.intel.com>
         <20170531194152.65927-2-andriy.shevchenko@linux.intel.com>
         <20170605160102.GA29981@lst.de>
Organization: Intel Finland Oy
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.22.6-1 
Mime-Version: 1.0
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, 2017-06-05 at 18:01 +0200, Christoph Hellwig wrote:
> >  	for (i = 0; i < NFIT_UUID_MAX; i++)
> > -		if (memcmp(to_nfit_uuid(i), spa->range_guid, 16) ==
> > 0)
> > +		if (!guid_equal(to_nfit_uuid(i), (guid_t *)&spa-
> > >range_guid))
> >  			return i;
> 
> I think this should be guid_equal without the "!"

Right.


-- 
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy