From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andy Shevchenko Subject: Re: [PATCH v2 2/5] ACPI / APEI: Switch to use new generic UUID API Date: Mon, 05 Jun 2017 19:19:43 +0300 Message-ID: <1496679583.22624.15.camel@linux.intel.com> References: <20170531194152.65927-1-andriy.shevchenko@linux.intel.com> <20170531194152.65927-3-andriy.shevchenko@linux.intel.com> <20170605160151.GB29981@lst.de> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20170605160151.GB29981@lst.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Christoph Hellwig Cc: intel-gfx@lists.freedesktop.org, "Rafael J . Wysocki" , linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, Dan Williams , Borislav Petkov , Mika Westerberg List-Id: linux-acpi@vger.kernel.org T24gTW9uLCAyMDE3LTA2LTA1IGF0IDE4OjAxICswMjAwLCBDaHJpc3RvcGggSGVsbHdpZyB3cm90 ZToKPiA+IC0JCWlmICghdXVpZF9sZV9jbXAoKih1dWlkX2xlICopZ2RhdGEtPnNlY3Rpb25fdHlw ZSwKPiA+IC0JCQkJwqBDUEVSX1NFQ19QTEFURk9STV9NRU0pKSB7Cj4gPiArCQlpZiAoIWd1aWRf ZXF1YWwoc2VjX3R5cGUsICZDUEVSX1NFQ19QTEFURk9STV9NRU0pKQo+ID4gewo+IAo+IFRoZSAi ISIgaGVyZSBzZWVtcyBpbmNvcnJlY3QuCj4gCj4gPiDCoCNpZmRlZiBDT05GSUdfQUNQSV9BUEVJ X1BDSUVBRVIKPiA+IC0JCWVsc2UgaWYgKCF1dWlkX2xlX2NtcCgqKHV1aWRfbGUgKilnZGF0YS0K PiA+ID5zZWN0aW9uX3R5cGUsCj4gPiAtCQkJCcKgwqDCoMKgwqDCoENQRVJfU0VDX1BDSUUpKSB7 Cj4gPiArCQllbHNlIGlmICghZ3VpZF9lcXVhbChzZWNfdHlwZSwgJkNQRVJfU0VDX1BDSUUpKSB7 Cj4gCj4gU2FtZSBoZXJlLgoKVGhhbmtzIQpBcmUgeW91IGdvaW5nIHRvIGZpeHVwIHdoZW4gYXBw bHlpbmcgb3IgYmV0dGVyIG1lIHRvIHNlbmQgYW4gdXBkYXRlZAp2ZXJzaW9uPwoKLS0gCkFuZHkg U2hldmNoZW5rbyA8YW5kcml5LnNoZXZjaGVua29AbGludXguaW50ZWwuY29tPgpJbnRlbCBGaW5s YW5kIE95Cl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCklu dGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRw czovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752118AbdFER2b (ORCPT ); Mon, 5 Jun 2017 13:28:31 -0400 Received: from mga01.intel.com ([192.55.52.88]:21162 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751905AbdFEQUL (ORCPT ); Mon, 5 Jun 2017 12:20:11 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.39,302,1493708400"; d="scan'208";a="976974680" Message-ID: <1496679583.22624.15.camel@linux.intel.com> Subject: Re: [PATCH v2 2/5] ACPI / APEI: Switch to use new generic UUID API From: Andy Shevchenko To: Christoph Hellwig Cc: linux-kernel@vger.kernel.org, "Rafael J . Wysocki" , linux-acpi@vger.kernel.org, Dan Williams , Mika Westerberg , Borislav Petkov , intel-gfx@lists.freedesktop.org Date: Mon, 05 Jun 2017 19:19:43 +0300 In-Reply-To: <20170605160151.GB29981@lst.de> References: <20170531194152.65927-1-andriy.shevchenko@linux.intel.com> <20170531194152.65927-3-andriy.shevchenko@linux.intel.com> <20170605160151.GB29981@lst.de> Organization: Intel Finland Oy Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.22.6-1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2017-06-05 at 18:01 +0200, Christoph Hellwig wrote: > > - if (!uuid_le_cmp(*(uuid_le *)gdata->section_type, > > -  CPER_SEC_PLATFORM_MEM)) { > > + if (!guid_equal(sec_type, &CPER_SEC_PLATFORM_MEM)) > > { > > The "!" here seems incorrect. > > >  #ifdef CONFIG_ACPI_APEI_PCIEAER > > - else if (!uuid_le_cmp(*(uuid_le *)gdata- > > >section_type, > > -       CPER_SEC_PCIE)) { > > + else if (!guid_equal(sec_type, &CPER_SEC_PCIE)) { > > Same here. Thanks! Are you going to fixup when applying or better me to send an updated version? -- Andy Shevchenko Intel Finland Oy