From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andy Shevchenko Subject: Re: [PATCH v2 4/5] ACPI / extlog: Switch to use new generic UUID API Date: Mon, 05 Jun 2017 19:23:05 +0300 Message-ID: <1496679785.22624.19.camel@linux.intel.com> References: <20170531194152.65927-1-andriy.shevchenko@linux.intel.com> <20170531194152.65927-5-andriy.shevchenko@linux.intel.com> <20170605160626.GD29981@lst.de> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20170605160626.GD29981@lst.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Christoph Hellwig Cc: intel-gfx@lists.freedesktop.org, "Rafael J . Wysocki" , linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, Dan Williams , Borislav Petkov , Mika Westerberg List-Id: linux-acpi@vger.kernel.org T24gTW9uLCAyMDE3LTA2LTA1IGF0IDE4OjA2ICswMjAwLCBDaHJpc3RvcGggSGVsbHdpZyB3cm90 ZToKPiA+IEBAIC0xNjUsMTEgKzE2NSwxMSBAQCBzdGF0aWMgaW50IGV4dGxvZ19wcmludChzdHJ1 Y3Qgbm90aWZpZXJfYmxvY2sKPiA+ICpuYiwgdW5zaWduZWQgbG9uZyB2YWwsCj4gPiDCoAllcnJf c2VxKys7Cj4gPiDCoAlnZGF0YSA9IChzdHJ1Y3QgYWNwaV9oZXN0X2dlbmVyaWNfZGF0YSAqKSh0 bXAgKyAxKTsKPiA+IMKgCWlmIChnZGF0YS0+dmFsaWRhdGlvbl9iaXRzICYgQ1BFUl9TRUNfVkFM SURfRlJVX0lEKQo+ID4gLQkJZnJ1X2lkID0gKHV1aWRfbGUgKilnZGF0YS0+ZnJ1X2lkOwo+ID4g KwkJZnJ1X2lkID0gKGd1aWRfdCAqKWdkYXRhLT5mcnVfaWQ7Cj4gPiDCoAlpZiAoZ2RhdGEtPnZh bGlkYXRpb25fYml0cyAmIENQRVJfU0VDX1ZBTElEX0ZSVV9URVhUKQo+ID4gwqAJCWZydV90ZXh0 ID0gZ2RhdGEtPmZydV90ZXh0Owo+ID4gLQlzZWNfdHlwZSA9ICh1dWlkX2xlICopZ2RhdGEtPnNl Y3Rpb25fdHlwZTsKPiA+IC0JaWYgKCF1dWlkX2xlX2NtcCgqc2VjX3R5cGUsIENQRVJfU0VDX1BM QVRGT1JNX01FTSkpIHsKPiA+ICsJc2VjX3R5cGUgPSAoZ3VpZF90ICopZ2RhdGEtPnNlY3Rpb25f dHlwZTsKPiAKPiBGcm9tIGEgcXVpY2sgbG9vayBvdmVyIHRoZSB0cmVlIGl0IHNlZW1zIGxpa2Ug Ym90aCBmcnVfaWQgYW5kCj4gc2VjdGlvbl90eXBlIHNob3VsZCBiZSBkZWNsYXJlZCBhcyBndWlk X3QgaW4KPiBzdHJ1Y3QgYWNwaV9oZXN0X2dlbmVyaWNfZGF0YS4KCgpUaGV5IGFyZSBhcnJheXMg b2YgMTYgdTg6cy4KQW5kIHNpbmNlIGl0J3MgZGVmaW5lZCBpbiBBQ1BJIHRhYmxlIGRlZmluaXRp b24gSSdtIG5vdCBzdXJlIHdlIGNhbgpjaGFuZ2UgaXQuCgo+IAo+ID4gKwlpZiAoIWd1aWRfZXF1 YWwoc2VjX3R5cGUsICZDUEVSX1NFQ19QTEFURk9STV9NRU0pKSB7Cj4gCj4gVGhlICIhIiBzZWVt cyBpbmNvcnJlY3QgaGVyZS4KClJpZ2h0LgoKLS0gCkFuZHkgU2hldmNoZW5rbyA8YW5kcml5LnNo ZXZjaGVua29AbGludXguaW50ZWwuY29tPgpJbnRlbCBGaW5sYW5kIE95Cl9fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QK SW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9w Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752645AbdFEQXh (ORCPT ); Mon, 5 Jun 2017 12:23:37 -0400 Received: from mga09.intel.com ([134.134.136.24]:39640 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751701AbdFEQXe (ORCPT ); Mon, 5 Jun 2017 12:23:34 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.39,302,1493708400"; d="scan'208";a="864757218" Message-ID: <1496679785.22624.19.camel@linux.intel.com> Subject: Re: [PATCH v2 4/5] ACPI / extlog: Switch to use new generic UUID API From: Andy Shevchenko To: Christoph Hellwig Cc: linux-kernel@vger.kernel.org, "Rafael J . Wysocki" , linux-acpi@vger.kernel.org, Dan Williams , Mika Westerberg , Borislav Petkov , intel-gfx@lists.freedesktop.org Date: Mon, 05 Jun 2017 19:23:05 +0300 In-Reply-To: <20170605160626.GD29981@lst.de> References: <20170531194152.65927-1-andriy.shevchenko@linux.intel.com> <20170531194152.65927-5-andriy.shevchenko@linux.intel.com> <20170605160626.GD29981@lst.de> Organization: Intel Finland Oy Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.22.6-1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2017-06-05 at 18:06 +0200, Christoph Hellwig wrote: > > @@ -165,11 +165,11 @@ static int extlog_print(struct notifier_block > > *nb, unsigned long val, > >   err_seq++; > >   gdata = (struct acpi_hest_generic_data *)(tmp + 1); > >   if (gdata->validation_bits & CPER_SEC_VALID_FRU_ID) > > - fru_id = (uuid_le *)gdata->fru_id; > > + fru_id = (guid_t *)gdata->fru_id; > >   if (gdata->validation_bits & CPER_SEC_VALID_FRU_TEXT) > >   fru_text = gdata->fru_text; > > - sec_type = (uuid_le *)gdata->section_type; > > - if (!uuid_le_cmp(*sec_type, CPER_SEC_PLATFORM_MEM)) { > > + sec_type = (guid_t *)gdata->section_type; > > From a quick look over the tree it seems like both fru_id and > section_type should be declared as guid_t in > struct acpi_hest_generic_data. They are arrays of 16 u8:s. And since it's defined in ACPI table definition I'm not sure we can change it. > > > + if (!guid_equal(sec_type, &CPER_SEC_PLATFORM_MEM)) { > > The "!" seems incorrect here. Right. -- Andy Shevchenko Intel Finland Oy