All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Jörg Krause" <joerg.krause@embedded.rocks>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] toolchain/toolchain-common.in: update definition of BR2_TOOLCHAIN_HAS_GCC_BUG_64735 for GCC 7
Date: Tue, 06 Jun 2017 20:44:05 +0200	[thread overview]
Message-ID: <1496774645.3962.1.camel@embedded.rocks> (raw)
In-Reply-To: <20170606173222.537500c6@free-electrons.com>

Hi Thomas,

On Tue, 2017-06-06 at 17:32 +0200, Thomas Petazzoni wrote:
> Hello,
> 
> On Tue,  6 Jun 2017 16:08:50 +0200, J?rg Krause wrote:
> 
> > diff --git a/toolchain/toolchain-common.in b/toolchain/toolchain-common.in
> > index d670f44747..06986abdd2 100644
> > --- a/toolchain/toolchain-common.in
> > +++ b/toolchain/toolchain-common.in
> > @@ -13,10 +13,9 @@ comment "Toolchain Generic Options"
> >  # ints before GCC 7
> >  config BR2_TOOLCHAIN_HAS_GCC_BUG_64735
> >  	bool
> > -	default y if BR2_nios2
> > -	default y if BR2_ARM_CPU_ARMV4
> > -	default y if BR2_ARM_CPU_ARMV5
> > -	default y if BR2_sparc_v8
> > +	default y if (BR2_nios2 || BR2_ARM_CPU_ARMV4 || \
> > +		BR2_ARM_CPU_ARMV5 || BR2_sparc_v8) && \
> > +		!BR2_TOOLCHAIN_GCC_AT_LEAST_7
> 
> This feels very complicated. What about just:
> 
> 	depends on !BR2_TOOLCHAIN_GCC_AT_LEAST_7

Wouldn't that be rather:

"""
config BR2_TOOLCHAIN_HAS_GCC_BUG_64735
	default y if !BR2_TOOLCHAIN_GCC_AT_LEAST_7
"""

The package mpd chooses between version 0.19 and 0.20 depending on that
bug. For now, if mpd is build with GCC6 (and below) and an architecture
not affected by this bug, version 0.20 is selected. By not depending on
the architecture anymore, mpd version 0.19 would be selected instead.

J?rg

  reply	other threads:[~2017-06-06 18:44 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-06 14:08 [Buildroot] [PATCH] toolchain/toolchain-common.in: update definition of BR2_TOOLCHAIN_HAS_GCC_BUG_64735 for GCC 7 Jörg Krause
2017-06-06 15:32 ` Thomas Petazzoni
2017-06-06 18:44   ` Jörg Krause [this message]
2017-06-06 19:23     ` Thomas Petazzoni
2017-06-06 19:35       ` Jörg Krause
2017-06-06 19:42         ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1496774645.3962.1.camel@embedded.rocks \
    --to=joerg.krause@embedded.rocks \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.