From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff Kirsher Date: Wed, 07 Jun 2017 13:34:59 -0700 Subject: [Intel-wired-lan] [net-intel-i40e] question about assignment overwrite In-Reply-To: <20170607195526.GA26867@korriban> References: <20170517154858.Horde.xMvsIEhHNSGu52mfyp7HA3R@gator4166.hostgator.com> <1495086551.46489.1.camel@intel.com> <20170607195526.GA26867@korriban> Message-ID: <1496867699.2192.2.camel@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: intel-wired-lan@osuosl.org List-ID: On Wed, 2017-06-07 at 16:55 -0300, Mauro Rodrigues wrote: > On Wed, May 17, 2017 at 10:49:11PM -0700, Jeff Kirsher wrote: > > On Wed, 2017-05-17 at 15:48 -0500, Gustavo A. R. Silva wrote: > > > While looking into Coverity ID 1408956 I ran into the following > > > piece?? > > > of code at drivers/net/ethernet/intel/i40e/i40e_main.c:8807: > > > > > > 8807??????? if (pf->hw.mac.type == I40E_MAC_X722) { > > > 8808??????????????? pf->flags |= I40E_FLAG_RSS_AQ_CAPABLE > > > 8809???????????????????????????? | I40E_FLAG_128_QP_RSS_CAPABLE > > > 8810???????????????????????????? | I40E_FLAG_HW_ATR_EVICT_CAPABLE > > > 8811???????????????????????????? | I40E_FLAG_OUTER_UDP_CSUM_CAPABLE > > > 8812???????????????????????????? | I40E_FLAG_WB_ON_ITR_CAPABLE > > > 8813???????????????????????????? | > > > I40E_FLAG_MULTIPLE_TCP_UDP_RSS_PCTYPE > > > 8814???????????????????????????? | I40E_FLAG_NO_PCI_LINK_CHECK > > > 8815???????????????????????????? | I40E_FLAG_USE_SET_LLDP_MIB > > > 8816???????????????????????????? | I40E_FLAG_GENEVE_OFFLOAD_CAPABLE > > > 8817???????????????????????????? | I40E_FLAG_PTP_L4_CAPABLE > > > 8818???????????????????????????? | I40E_FLAG_WOL_MC_MAGIC_PKT_WAKE; > > > 8819??????? } else if ((pf->hw.aq.api_maj_ver > 1) || > > > 8820?????????????????? ((pf->hw.aq.api_maj_ver == 1) && > > > 8821??????????????????? (pf->hw.aq.api_min_ver > 4))) { > > > 8822??????????????? /* Supported in FW API version higher than 1.4 */ > > > 8823??????????????? pf->flags |= I40E_FLAG_GENEVE_OFFLOAD_CAPABLE; > > > 8824??????????????? pf->flags = I40E_FLAG_HW_ATR_EVICT_CAPABLE; > > > 8825??????? } else { > > > 8826??????????????? pf->flags = I40E_FLAG_HW_ATR_EVICT_CAPABLE; > > > 8827??????? } > > > > > > The issue here is that the assignment at line 8823 is overwritten > > > by?? > > > the code at line 8824. > > > > > > I'm suspicious that line 8824 should be remove and a patch like the?? > > > following can be applied: > > > > > > index d5c9c9e..48ffa73 100644 > > > --- a/drivers/net/ethernet/intel/i40e/i40e_main.c > > > +++ b/drivers/net/ethernet/intel/i40e/i40e_main.c > > > @@ -8821,7 +8821,6 @@ static int i40e_sw_init(struct i40e_pf *pf) > > > ???????????????????? (pf->hw.aq.api_min_ver > 4))) { > > > ???????????????? /* Supported in FW API version higher than 1.4 */ > > > ???????????????? pf->flags |= I40E_FLAG_GENEVE_OFFLOAD_CAPABLE; > > > -?????????????? pf->flags = I40E_FLAG_HW_ATR_EVICT_CAPABLE; > > > ???????? } else { > > > ???????????????? pf->flags = I40E_FLAG_HW_ATR_EVICT_CAPABLE; > > > ???????? } > > > > > > What do you think? > > > > This issue is already fixed in my dev-queue branch on my next-queue > > tree. > > Hi Jeff, are you planning to push this fix into net branch anytime soon? > > Thanks, > > Mauro The patch that fixed this issue is already in David Miller's net-next tree. -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: This is a digitally signed message part URL: From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751511AbdFGUfH (ORCPT ); Wed, 7 Jun 2017 16:35:07 -0400 Received: from mga06.intel.com ([134.134.136.31]:17405 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751299AbdFGUfF (ORCPT ); Wed, 7 Jun 2017 16:35:05 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.39,311,1493708400"; d="asc'?scan'208";a="110417333" Message-ID: <1496867699.2192.2.camel@intel.com> Subject: Re: [net-intel-i40e] question about assignment overwrite From: Jeff Kirsher To: Mauro Rodrigues Cc: "Gustavo A. R. Silva" , intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Date: Wed, 07 Jun 2017 13:34:59 -0700 In-Reply-To: <20170607195526.GA26867@korriban> References: <20170517154858.Horde.xMvsIEhHNSGu52mfyp7HA3R@gator4166.hostgator.com> <1495086551.46489.1.camel@intel.com> <20170607195526.GA26867@korriban> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-wSm8y2wVnRk1vY5qlnqX" X-Mailer: Evolution 3.22.6 (3.22.6-1.fc25) Mime-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --=-wSm8y2wVnRk1vY5qlnqX Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: base64 T24gV2VkLCAyMDE3LTA2LTA3IGF0IDE2OjU1IC0wMzAwLCBNYXVybyBSb2RyaWd1ZXMgd3JvdGU6 Cj4gT24gV2VkLCBNYXkgMTcsIDIwMTcgYXQgMTA6NDk6MTFQTSAtMDcwMCwgSmVmZiBLaXJzaGVy IHdyb3RlOgo+ID4gT24gV2VkLCAyMDE3LTA1LTE3IGF0IDE1OjQ4IC0wNTAwLCBHdXN0YXZvIEEu IFIuIFNpbHZhIHdyb3RlOgo+ID4gPiBXaGlsZSBsb29raW5nIGludG8gQ292ZXJpdHkgSUQgMTQw ODk1NiBJIHJhbiBpbnRvIHRoZSBmb2xsb3dpbmcKPiA+ID4gcGllY2XCoMKgCj4gPiA+IG9mIGNv ZGUgYXQgZHJpdmVycy9uZXQvZXRoZXJuZXQvaW50ZWwvaTQwZS9pNDBlX21haW4uYzo4ODA3Ogo+ ID4gPiAKPiA+ID4gODgwN8KgwqDCoMKgwqDCoMKgIGlmIChwZi0+aHcubWFjLnR5cGUgPT0gSTQw RV9NQUNfWDcyMikgewo+ID4gPiA4ODA4wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIHBm LT5mbGFncyB8PSBJNDBFX0ZMQUdfUlNTX0FRX0NBUEFCTEUKPiA+ID4gODgwOcKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIHwgSTQwRV9GTEFH XzEyOF9RUF9SU1NfQ0FQQUJMRQo+ID4gPiA4ODEwwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgfCBJNDBFX0ZMQUdfSFdfQVRSX0VWSUNUX0NB UEFCTEUKPiA+ID4gODgxMcKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgIHwgSTQwRV9GTEFHX09VVEVSX1VEUF9DU1VNX0NBUEFCTEUKPiA+ID4g ODgxMsKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgIHwgSTQwRV9GTEFHX1dCX09OX0lUUl9DQVBBQkxFCj4gPiA+IDg4MTPCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCB8Cj4gPiA+IEk0MEVf RkxBR19NVUxUSVBMRV9UQ1BfVURQX1JTU19QQ1RZUEUKPiA+ID4gODgxNMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIHwgSTQwRV9GTEFHX05P X1BDSV9MSU5LX0NIRUNLCj4gPiA+IDg4MTXCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCB8IEk0MEVfRkxBR19VU0VfU0VUX0xMRFBfTUlCCj4g PiA+IDg4MTbCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoCB8IEk0MEVfRkxBR19HRU5FVkVfT0ZGTE9BRF9DQVBBQkxFCj4gPiA+IDg4MTfCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCB8IEk0 MEVfRkxBR19QVFBfTDRfQ0FQQUJMRQo+ID4gPiA4ODE4wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgfCBJNDBFX0ZMQUdfV09MX01DX01BR0lD X1BLVF9XQUtFOwo+ID4gPiA4ODE5wqDCoMKgwqDCoMKgwqAgfSBlbHNlIGlmICgocGYtPmh3LmFx LmFwaV9tYWpfdmVyID4gMSkgfHwKPiA+ID4gODgyMMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoCAoKHBmLT5ody5hcS5hcGlfbWFqX3ZlciA9PSAxKSAmJgo+ID4gPiA4ODIxwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgKHBmLT5ody5hcS5hcGlfbWluX3Zl ciA+IDQpKSkgewo+ID4gPiA4ODIywqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIC8qIFN1 cHBvcnRlZCBpbiBGVyBBUEkgdmVyc2lvbiBoaWdoZXIgdGhhbiAxLjQgKi8KPiA+ID4gODgyM8Kg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBwZi0+ZmxhZ3MgfD0gSTQwRV9GTEFHX0dFTkVW RV9PRkZMT0FEX0NBUEFCTEU7Cj4gPiA+IDg4MjTCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqAgcGYtPmZsYWdzID0gSTQwRV9GTEFHX0hXX0FUUl9FVklDVF9DQVBBQkxFOwo+ID4gPiA4ODI1 wqDCoMKgwqDCoMKgwqAgfSBlbHNlIHsKPiA+ID4gODgyNsKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoCBwZi0+ZmxhZ3MgPSBJNDBFX0ZMQUdfSFdfQVRSX0VWSUNUX0NBUEFCTEU7Cj4gPiA+ IDg4MjfCoMKgwqDCoMKgwqDCoCB9Cj4gPiA+IAo+ID4gPiBUaGUgaXNzdWUgaGVyZSBpcyB0aGF0 IHRoZSBhc3NpZ25tZW50IGF0IGxpbmUgODgyMyBpcyBvdmVyd3JpdHRlbgo+ID4gPiBiecKgwqAK PiA+ID4gdGhlIGNvZGUgYXQgbGluZSA4ODI0Lgo+ID4gPiAKPiA+ID4gSSdtIHN1c3BpY2lvdXMg dGhhdCBsaW5lIDg4MjQgc2hvdWxkIGJlIHJlbW92ZSBhbmQgYSBwYXRjaCBsaWtlIHRoZcKgwqAK PiA+ID4gZm9sbG93aW5nIGNhbiBiZSBhcHBsaWVkOgo+ID4gPiAKPiA+ID4gaW5kZXggZDVjOWM5 ZS4uNDhmZmE3MyAxMDA2NDQKPiA+ID4gLS0tIGEvZHJpdmVycy9uZXQvZXRoZXJuZXQvaW50ZWwv aTQwZS9pNDBlX21haW4uYwo+ID4gPiArKysgYi9kcml2ZXJzL25ldC9ldGhlcm5ldC9pbnRlbC9p NDBlL2k0MGVfbWFpbi5jCj4gPiA+IEBAIC04ODIxLDcgKzg4MjEsNiBAQCBzdGF0aWMgaW50IGk0 MGVfc3dfaW5pdChzdHJ1Y3QgaTQwZV9wZiAqcGYpCj4gPiA+IMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqAgKHBmLT5ody5hcS5hcGlfbWluX3ZlciA+IDQpKSkgewo+ID4g PiDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCAvKiBTdXBwb3J0ZWQgaW4gRlcgQVBJ IHZlcnNpb24gaGlnaGVyIHRoYW4gMS40ICovCj4gPiA+IMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgIHBmLT5mbGFncyB8PSBJNDBFX0ZMQUdfR0VORVZFX09GRkxPQURfQ0FQQUJMRTsK PiA+ID4gLcKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgcGYtPmZsYWdzID0gSTQwRV9GTEFH X0hXX0FUUl9FVklDVF9DQVBBQkxFOwo+ID4gPiDCoMKgwqDCoMKgwqDCoMKgIH0gZWxzZSB7Cj4g PiA+IMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIHBmLT5mbGFncyA9IEk0MEVfRkxB R19IV19BVFJfRVZJQ1RfQ0FQQUJMRTsKPiA+ID4gwqDCoMKgwqDCoMKgwqDCoCB9Cj4gPiA+IAo+ ID4gPiBXaGF0IGRvIHlvdSB0aGluaz8KPiA+IAo+ID4gVGhpcyBpc3N1ZSBpcyBhbHJlYWR5IGZp eGVkIGluIG15IGRldi1xdWV1ZSBicmFuY2ggb24gbXkgbmV4dC1xdWV1ZQo+ID4gdHJlZS4KPiAK PiBIaSBKZWZmLCBhcmUgeW91IHBsYW5uaW5nIHRvIHB1c2ggdGhpcyBmaXggaW50byBuZXQgYnJh bmNoIGFueXRpbWUgc29vbj8KPiAKPiBUaGFua3MsCj4gCj4gTWF1cm8KClRoZSBwYXRjaCB0aGF0 IGZpeGVkIHRoaXMgaXNzdWUgaXMgYWxyZWFkeSBpbiBEYXZpZCBNaWxsZXIncyBuZXQtbmV4dCB0 cmVlLg== --=-wSm8y2wVnRk1vY5qlnqX Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAABCgAGBQJZOGNzAAoJEOVv75VaS+3O4RoQAKbkVORTPpov/Iow4A/uXKKI cjYmOPsMxHKLwslr8obGUnTZe7GlEZUDy6XJRwOLa0jMHm1aGteZPvrk3yKNUsN/ 5qF5IT8YU2295llo2UqyGcN2PhHWD/M/aKWE5Gunn6nToVOwufa/HBuC0t0H9Kha ZXmWqH9mx6wtG8OyOKG+N8QZjhEl53y0c5T5JO0ZNFn1LEhVW9YaYWb/3vK0JADa mypJTzo9lmKzoNEUF4GUleSlJ6CESRmC9BJLCCYegWoEsQu+Yw6AzN5JrOfkBHXy xvPFgLZznXiKujF9H96a6wbdqa9C1+E4x8nosrNV68I9c2asJB7qz4kkQ2BkX5kT fDy1QvehWA+k1zHrSckUdbiyQY3jT5U+zW8TUB6VPOwCwidATCRK+zydHTFcXjhM dePKQTejwyy++RXMHTBbOF8xPoR3iA/fp13I6QNMCa/zWrTqrD6IDFpQasYuSKTr ydS/9GI6FSfYKn/6BY9ZbjFyIxRoICPfg38dl6xaf2C6JC+Q9IgzlYCiJu06/ko9 NJngfTVffkMvTXugbmomu6AG+wgQ23MADFYtsD4ROA3BkjLyF5fFWIr6GO9S4V3R nTEEEg0Y0IRMbaUw0AKXyyaMa1Yfy44udPFSZSQRot+UcmU7u1E5bQLrk+ZzHHVm fwUWIbkUKHf4v+6U6osU =2TIT -----END PGP SIGNATURE----- --=-wSm8y2wVnRk1vY5qlnqX--