From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46775) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dIxee-0001bj-3b for qemu-devel@nongnu.org; Thu, 08 Jun 2017 09:39:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dIxed-0005PD-CA for qemu-devel@nongnu.org; Thu, 08 Jun 2017 09:39:16 -0400 Received: from mx1.redhat.com ([209.132.183.28]:36284) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dIxed-0005Og-7J for qemu-devel@nongnu.org; Thu, 08 Jun 2017 09:39:15 -0400 Message-ID: <1496929152.29761.3.camel@redhat.com> From: Gerd Hoffmann Date: Thu, 08 Jun 2017 15:39:12 +0200 In-Reply-To: <1496927734-29174-4-git-send-email-owen.smith@citrix.com> References: <1496927734-29174-1-git-send-email-owen.smith@citrix.com> <1496927734-29174-4-git-send-email-owen.smith@citrix.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 3/4] ui/input: Add activate/remove for keyboard handlers List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Owen Smith , qemu-devel@nongnu.org Cc: sstabellini@kernel.org, anthony.perard@citrix.com, xen-devel@lists.xenproject.org diff --git a/ui/input-legacy.c b/ui/input-legacy.c > index 7159747..fbe1ce7 100644 > --- a/ui/input-legacy.c > +++ b/ui/input-legacy.c > @@ -142,6 +142,18 @@ QEMUPutKbdEntry > *qemu_add_kbd_event_handler(QEMUPutKBDEvent *func, void *opaque) > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0return entry; > =C2=A0} > =C2=A0 > +void qemu_activate_kbd_event_handler(QEMUPutKbdEntry *entry) Please don't add new code to input-legacy.c please. Switch your code to use the new qemu_input_handler_*() functions directly instead. cheers, Gerd From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gerd Hoffmann Subject: Re: [PATCH 3/4] ui/input: Add activate/remove for keyboard handlers Date: Thu, 08 Jun 2017 15:39:12 +0200 Message-ID: <1496929152.29761.3.camel@redhat.com> References: <1496927734-29174-1-git-send-email-owen.smith@citrix.com> <1496927734-29174-4-git-send-email-owen.smith@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dIxef-0000w9-Bw for xen-devel@lists.xenproject.org; Thu, 08 Jun 2017 13:39:17 +0000 In-Reply-To: <1496927734-29174-4-git-send-email-owen.smith@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Owen Smith , qemu-devel@nongnu.org Cc: anthony.perard@citrix.com, xen-devel@lists.xenproject.org, sstabellini@kernel.org List-Id: xen-devel@lists.xenproject.org ZGlmZiAtLWdpdCBhL3VpL2lucHV0LWxlZ2FjeS5jIGIvdWkvaW5wdXQtbGVnYWN5LmMKPiBpbmRl eCA3MTU5NzQ3Li5mYmUxY2U3IDEwMDY0NAo+IC0tLSBhL3VpL2lucHV0LWxlZ2FjeS5jCj4gKysr IGIvdWkvaW5wdXQtbGVnYWN5LmMKPiBAQCAtMTQyLDYgKzE0MiwxOCBAQCBRRU1VUHV0S2JkRW50 cnkKPiAqcWVtdV9hZGRfa2JkX2V2ZW50X2hhbmRsZXIoUUVNVVB1dEtCREV2ZW50ICpmdW5jLCB2 b2lkICpvcGFxdWUpCj4gwqDCoMKgwqDCoHJldHVybiBlbnRyeTsKPiDCoH0KPiDCoAo+ICt2b2lk IHFlbXVfYWN0aXZhdGVfa2JkX2V2ZW50X2hhbmRsZXIoUUVNVVB1dEtiZEVudHJ5ICplbnRyeSkK ClBsZWFzZSBkb24ndCBhZGQgbmV3IGNvZGUgdG8gaW5wdXQtbGVnYWN5LmMgcGxlYXNlLgoKU3dp dGNoIHlvdXIgY29kZSB0byB1c2UgdGhlIG5ldyBxZW11X2lucHV0X2hhbmRsZXJfKigpIGZ1bmN0 aW9ucwpkaXJlY3RseSBpbnN0ZWFkLgoKY2hlZXJzLAogIEdlcmQKCl9fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fClhlbi1kZXZlbCBtYWlsaW5nIGxpc3QKWGVu LWRldmVsQGxpc3RzLnhlbi5vcmcKaHR0cHM6Ly9saXN0cy54ZW4ub3JnL3hlbi1kZXZlbAo=