From mboxrd@z Thu Jan 1 00:00:00 1970 From: jbrunet@baylibre.com (Jerome Brunet) Date: Thu, 08 Jun 2017 15:53:36 +0200 Subject: [PATCH] pinctrl: meson-gxl: add tsin_a pins In-Reply-To: References: <20170608130948.16426-1-jbrunet@baylibre.com> Message-ID: <1496930016.3552.45.camel@baylibre.com> To: linus-amlogic@lists.infradead.org List-Id: linus-amlogic.lists.infradead.org On Thu, 2017-06-08 at 15:49 +0200, Andreas F?rber wrote: > Am 08.06.2017 um 15:09 schrieb Jerome Brunet: > > Add Tsin A pins to bank DV and X. > > We don't have a driver for the tsin yet but since the tsin A pinmux is > > enabled by default at boot time, declaring this pinmux is required to > > properly operate on GPIOX. > > > > Without this change, GPIOX 8, 9, 10 and 11 can't be driven as GPIO output > > as the tsin A seems to have priority. > > Should this get a Fixes header then for stable backports? Nothing is wrong with what is already in. This is merely an addition. If we go that way, all commit to this file should have a Fixes to the initial commit. This seems a bit extreme to me ... > > > > > Signed-off-by: Jerome Brunet > > --- > > ?drivers/pinctrl/meson/pinctrl-meson-gxl.c | 36 > > +++++++++++++++++++++++++++++++ > > ?1 file changed, 36 insertions(+) > > Looks OK AFAICT. > > Cheers, > Andreas > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jerome Brunet Subject: Re: [PATCH] pinctrl: meson-gxl: add tsin_a pins Date: Thu, 08 Jun 2017 15:53:36 +0200 Message-ID: <1496930016.3552.45.camel@baylibre.com> References: <20170608130948.16426-1-jbrunet@baylibre.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Return-path: Received: from mail-wr0-f169.google.com ([209.85.128.169]:33624 "EHLO mail-wr0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752074AbdFHNxj (ORCPT ); Thu, 8 Jun 2017 09:53:39 -0400 Received: by mail-wr0-f169.google.com with SMTP id v104so18906089wrb.0 for ; Thu, 08 Jun 2017 06:53:38 -0700 (PDT) In-Reply-To: Sender: linux-gpio-owner@vger.kernel.org List-Id: linux-gpio@vger.kernel.org To: Andreas =?ISO-8859-1?Q?F=E4rber?= Cc: Linus Walleij , Kevin Hilman , Carlo Caione , linux-gpio@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org On Thu, 2017-06-08 at 15:49 +0200, Andreas Färber wrote: > Am 08.06.2017 um 15:09 schrieb Jerome Brunet: > > Add Tsin A pins to bank DV and X. > > We don't have a driver for the tsin yet but since the tsin A pinmux is > > enabled by default at boot time, declaring this pinmux is required to > > properly operate on GPIOX. > > > > Without this change, GPIOX 8, 9, 10 and 11 can't be driven as GPIO output > > as the tsin A seems to have priority. > > Should this get a Fixes header then for stable backports? Nothing is wrong with what is already in. This is merely an addition. If we go that way, all commit to this file should have a Fixes to the initial commit. This seems a bit extreme to me ... > > > > > Signed-off-by: Jerome Brunet > > --- > >  drivers/pinctrl/meson/pinctrl-meson-gxl.c | 36 > > +++++++++++++++++++++++++++++++ > >  1 file changed, 36 insertions(+) > > Looks OK AFAICT. > > Cheers, > Andreas >