Re: [PATCH 06/15] xen: trace IRQ enabling/disabling

[Dario Faggioli <dario.faggioli@citrix.com>]

[-- Attachment #1.1: Type: text/plain, Size: 1890 bytes --]

On Thu, 2017-06-08 at 17:01 +0100, George Dunlap wrote:
> On 01/06/17 18:34, Dario Faggioli wrote:
> > diff --git a/xen/Kconfig.debug b/xen/Kconfig.debug
> > index 374c1c0..81910c9 100644
> > --- a/xen/Kconfig.debug
> > +++ b/xen/Kconfig.debug
> > @@ -98,7 +98,7 @@ config PERF_ARRAYS
> >  	---help---
> >  	  Enables software performance counter array histograms.
> >  
> > -config TRACING
> > +menuconfig TRACING
> >  	bool "Tracing"
> >  	default y
> >  	---help---
> > @@ -106,6 +106,15 @@ config TRACING
> >  	  in per-CPU ring buffers. The 'xentrace' tool can be used
> > to read
> >  	  the buffers and dump the content on the disk.
> >  
> > +config TRACE_IRQSOFF
> > +	bool "Trace when IRQs are disabled and (re)enabled" if
> > EXPERT = "y"
> > +	default n
> > +	depends on TRACING
> > +	---help---
> > +	  Makes it possible to generate events _every_ time IRQs
> > are disabled
> > +          and (re)enabled, with also an indication of where that
> > happened.
> > +          Note that this comes with high overead and produces huge
> > amount of
> > +          tracing data.
> 
> I think I might emphasize that the overhead well be present even when
> tracing is off.  What about something like this?
> 
Yes, good point.

> "Note that this comes with an overhead even when tracing is disabled;
> and has a high overhead and produces a large amount of tracing data
> when
> enabled."
> 
I like it, I'll go for it.

> With that change:
> 
> Acked-by: George Dunlap <george.dunlap@citrix.com>
> 
Thanks and Regards,
Dario
-- 
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)

[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

[-- Attachment #2: Type: text/plain, Size: 127 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel