From: Bartosz Golaszewski <brgl@bgdev.pl>
To: Andy Shevchenko <andy.shevchenko@gmail.com>,
Linus Walleij <linus.walleij@linaro.org>,
Alexandre Courbot <gnurou@gmail.com>,
Bamvor Jian Zhang <bamvor.zhangjian@linaro.org>
Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
Bartosz Golaszewski <brgl@bgdev.pl>
Subject: [PATCH v3 6/8] gpio: mockup: improve the error message
Date: Fri, 9 Jun 2017 13:41:30 +0200 [thread overview]
Message-ID: <1497008492-14907-7-git-send-email-brgl@bgdev.pl> (raw)
In-Reply-To: <1497008492-14907-1-git-send-email-brgl@bgdev.pl>
Indicate the error number and make the message a bit more elaborate.
Signed-off-by: Bartosz Golaszewski <brgl@bgdev.pl>
---
drivers/gpio/gpio-mockup.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/gpio/gpio-mockup.c b/drivers/gpio/gpio-mockup.c
index ab2d38e..2f4fe41 100644
--- a/drivers/gpio/gpio-mockup.c
+++ b/drivers/gpio/gpio-mockup.c
@@ -373,8 +373,9 @@ static int gpio_mockup_probe(struct platform_device *pdev)
}
if (ret) {
- dev_err(dev, "gpio<%d..%d> add failed\n",
- base, base < 0 ? ngpio : base + ngpio);
+ dev_err(dev,
+ "adding gpiochip failed: %d (base: %d, ngpio: %d)\n",
+ ret, base, base < 0 ? ngpio : base + ngpio);
return ret;
}
--
2.9.3
next prev parent reply other threads:[~2017-06-09 11:41 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-09 11:41 [PATCH v3 0/8] gpio: mockup: updates for 4.13 Bartosz Golaszewski
2017-06-09 11:41 ` [PATCH v3 1/8] gpio: mockup: improve the debugfs input sanitization Bartosz Golaszewski
2017-06-20 7:12 ` Linus Walleij
2017-06-09 11:41 ` [PATCH v3 2/8] gpio: mockup: tweak gpio_mockup_event_write() Bartosz Golaszewski
2017-06-20 7:13 ` Linus Walleij
2017-06-09 11:41 ` [PATCH v3 3/8] gpio: mockup: refuse to accept an odd number of GPIO ranges Bartosz Golaszewski
2017-06-20 7:14 ` Linus Walleij
2017-06-09 11:41 ` [PATCH v3 4/8] gpio: mockup: improve readability Bartosz Golaszewski
2017-06-20 7:14 ` Linus Walleij
2017-06-09 11:41 ` [PATCH v3 5/8] gpio: mockup: don't return magic numbers from probe() Bartosz Golaszewski
2017-06-20 7:15 ` Linus Walleij
2017-06-09 11:41 ` Bartosz Golaszewski [this message]
2017-06-20 7:16 ` [PATCH v3 6/8] gpio: mockup: improve the error message Linus Walleij
2017-06-09 11:41 ` [PATCH v3 7/8] gpio: mockup: add myself as author Bartosz Golaszewski
2017-06-20 7:17 ` Linus Walleij
2017-06-09 11:41 ` [PATCH v3 8/8] gpio: mockup: use devm_kcalloc() where applicable Bartosz Golaszewski
2017-06-20 7:17 ` Linus Walleij
2017-06-09 15:46 ` [PATCH v3 0/8] gpio: mockup: updates for 4.13 Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1497008492-14907-7-git-send-email-brgl@bgdev.pl \
--to=brgl@bgdev.pl \
--cc=andy.shevchenko@gmail.com \
--cc=bamvor.zhangjian@linaro.org \
--cc=gnurou@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.