All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Xu <peterx@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Michael S . Tsirkin" <mst@redhat.com>,
	Marcel Apfelbaum <marcel@redhat.com>,
	peterx@redhat.com, Jason Wang <jasowang@redhat.com>
Subject: [Qemu-devel] [PATCH v2 0/3] VT-d: convert the rest of DPRINTF()s
Date: Fri,  9 Jun 2017 21:53:26 +0800	[thread overview]
Message-ID: <1497016409-22650-1-git-send-email-peterx@redhat.com> (raw)

v2:
- fix the issue that patchew reported
- further refactor patch 2 to make it better

Mainly I am doing the translation and then we can get rid of that.
Finally we won't need to recompile for its debugging any more.

I did spend some time on considering which DPRINTF to remove, which
one to convert to trace_*, also I am more careful this time with the
naming, e.g., I named all the error cases with trace_vtd_err_*, so
that we can easily get them when as long as we have a HMP interface,
using:

  trace-event vtd_err* on

The next two patches are simple cleanups. Please review. Thanks.

(I really want this series to be in asap... I should just do this
 months ago)

Peter Xu (3):
  intel_iommu: switching the rest DPRINTF to trace
  intel_iommu: cleanup vtd_{do_}iommu_translate()
  intel_iommu: cleanup vtd_interrupt_remap_msi()

 hw/i386/intel_iommu.c          | 421 +++++++++++++++--------------------------
 hw/i386/intel_iommu_internal.h |   1 +
 hw/i386/trace-events           |  44 +++++
 3 files changed, 196 insertions(+), 270 deletions(-)

-- 
2.7.4

             reply	other threads:[~2017-06-09 13:53 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-09 13:53 Peter Xu [this message]
2017-06-09 13:53 ` [Qemu-devel] [PATCH v2 1/3] intel_iommu: switching the rest DPRINTF to trace Peter Xu
2017-06-09 13:53 ` [Qemu-devel] [PATCH v2 2/3] intel_iommu: cleanup vtd_{do_}iommu_translate() Peter Xu
2017-06-09 13:53 ` [Qemu-devel] [PATCH v2 3/3] intel_iommu: cleanup vtd_interrupt_remap_msi() Peter Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1497016409-22650-1-git-send-email-peterx@redhat.com \
    --to=peterx@redhat.com \
    --cc=jasowang@redhat.com \
    --cc=marcel@redhat.com \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.