All of lore.kernel.org
 help / color / mirror / Atom feed
From: Patrick Ohly <patrick.ohly@intel.com>
To: Fan Xin <fan.xin@jp.fujitsu.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] acpica: Upgrade 20150515 -> 20170303
Date: Fri, 09 Jun 2017 21:26:20 +0200	[thread overview]
Message-ID: <1497036380.30163.221.camel@intel.com> (raw)
In-Reply-To: <1496638270-4482-1-git-send-email-fan.xin@jp.fujitsu.com>

On Mon, 2017-06-05 at 13:51 +0900, Fan Xin wrote:
> -@@ -569,6 +574,8 @@ FlOpenMiscOutputFiles (
> +@@ -607,6 +611,8 @@ FlOpenMiscOutputFiles (
>   
>       if (Gbl_DebugFlag)
>       {
> -+        int fd;
> ++      int fd;

Looks like you (accidentally?) also changed whitespaces while rebasing
the patch...


> +@@ -635,6 +641,8 @@ FlOpenMiscOutputFiles (
> +             exit (1);
>           }
> -+        Gbl_Files[ASL_FILE_DEBUG_OUTPUT].Handle = stderr;
>   
> ++        Gbl_Files[ASL_FILE_DEBUG_OUTPUT].Handle = stderr;
> ++

... and added lines.

Not a big deal, but you diff could have been smaller if you hadn't made
these unnecessary changes.

-- 
Best Regards, Patrick Ohly

The content of this message is my personal opinion only and although
I am an employee of Intel, the statements I make here in no way
represent Intel's position on the issue, nor am I authorized to speak
on behalf of Intel on this matter.





      reply	other threads:[~2017-06-09 19:26 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-05  4:51 [PATCH] acpica: Upgrade 20150515 -> 20170303 Fan Xin
2017-06-09 19:26 ` Patrick Ohly [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1497036380.30163.221.camel@intel.com \
    --to=patrick.ohly@intel.com \
    --cc=fan.xin@jp.fujitsu.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.