All of lore.kernel.org
 help / color / mirror / Atom feed
From: <netanel@amazon.com>
To: <davem@davemloft.net>, <netdev@vger.kernel.org>
Cc: Netanel Belgazal <netanel@amazon.com>, <dwmw@amazon.com>,
	<zorik@amazon.com>, <matua@amazon.com>, <saeedb@amazon.com>,
	<msw@amazon.com>, <aliguori@amazon.com>, <nafea@amazon.com>,
	<evgenys@amazon.com>
Subject: [PATCH net 3/9] net: ena: add missing return when ena_com_get_io_handlers() fails
Date: Sun, 11 Jun 2017 15:42:45 +0300	[thread overview]
Message-ID: <1497184971-28178-4-git-send-email-netanel@amazon.com> (raw)
In-Reply-To: <1497184971-28178-1-git-send-email-netanel@amazon.com>

From: Netanel Belgazal <netanel@amazon.com>

Fixes: 1738cd3ed342 ("Add a driver for Amazon Elastic Network Adapters (ENA)")
Signed-off-by: Netanel Belgazal <netanel@amazon.com>
---
 drivers/net/ethernet/amazon/ena/ena_netdev.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/net/ethernet/amazon/ena/ena_netdev.c b/drivers/net/ethernet/amazon/ena/ena_netdev.c
index 0e3c60c7eccf..1e71e89e1e18 100644
--- a/drivers/net/ethernet/amazon/ena/ena_netdev.c
+++ b/drivers/net/ethernet/amazon/ena/ena_netdev.c
@@ -1543,6 +1543,7 @@ static int ena_create_io_tx_queue(struct ena_adapter *adapter, int qid)
 			  "Failed to get TX queue handlers. TX queue num %d rc: %d\n",
 			  qid, rc);
 		ena_com_destroy_io_queue(ena_dev, ena_qid);
+		return rc;
 	}
 
 	ena_com_update_numa_node(tx_ring->ena_com_io_cq, ctx.numa_node);
@@ -1607,6 +1608,7 @@ static int ena_create_io_rx_queue(struct ena_adapter *adapter, int qid)
 			  "Failed to get RX queue handlers. RX queue num %d rc: %d\n",
 			  qid, rc);
 		ena_com_destroy_io_queue(ena_dev, ena_qid);
+		return rc;
 	}
 
 	ena_com_update_numa_node(rx_ring->ena_com_io_cq, ctx.numa_node);
-- 
2.7.4

  parent reply	other threads:[~2017-06-11 12:53 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-11 12:42 [PATCH net 0/9] Bugs fixes in ena ethernet driver netanel
2017-06-11 12:42 ` [PATCH net 1/9] net: ena: fix rare uncompleted admin command false alarm netanel
2017-06-11 12:42 ` [PATCH net 2/9] net: ena: fix bug that might cause hang after consecutive open/close interface netanel
2017-06-11 12:42 ` netanel [this message]
2017-06-11 12:42 ` [PATCH net 4/9] net: ena: fix race condition between submit and completion admin command netanel
2017-06-11 12:42 ` [PATCH net 5/9] net: ena: add missing unmap bars on device removal netanel
2017-06-11 12:42 ` [PATCH net 6/9] net: ena: fix theoretical Rx hang on low memory systems netanel
2017-06-11 12:42 ` [PATCH net 7/9] net: ena: disable admin msix while working in polling mode netanel
2017-06-11 12:42 ` [PATCH net 8/9] net: ena: bug fix in lost tx packets detection mechanism netanel
2017-06-11 12:42 ` [PATCH net 9/9] net: ena: update ena driver to version 1.1.7 netanel
2017-06-11 20:38 ` [PATCH net 0/9] Bugs fixes in ena ethernet driver David Miller
2017-06-12 14:09   ` Belgazal, Netanel
2017-06-12 14:24     ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1497184971-28178-4-git-send-email-netanel@amazon.com \
    --to=netanel@amazon.com \
    --cc=aliguori@amazon.com \
    --cc=davem@davemloft.net \
    --cc=dwmw@amazon.com \
    --cc=evgenys@amazon.com \
    --cc=matua@amazon.com \
    --cc=msw@amazon.com \
    --cc=nafea@amazon.com \
    --cc=netdev@vger.kernel.org \
    --cc=saeedb@amazon.com \
    --cc=zorik@amazon.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.