From: Gerd Hoffmann <kraxel@redhat.com>
To: "Marc-André Lureau" <marcandre.lureau@gmail.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 3/4] sdl2: use framebuffer helper functions.
Date: Mon, 12 Jun 2017 10:23:58 +0200 [thread overview]
Message-ID: <1497255838.6334.6.camel@redhat.com> (raw)
In-Reply-To: <CAJ+F1CLAq16p4SkcsyAeLZJ3BCtQQVfiXzvgnzxfN-iVFT0RCA@mail.gmail.com>
Hi,
> It's a bit weird to have win_fb used without being really
> initialized.
>
> Furthermore, there doesn't seem to be guarantee that
> glGenFramebuffers(1, &fb->framebuffer) will make only non-0 values.
0 is reserved for the default framebuffer of the current context, i.e.
the sdl window in this case.
cheers,
Gerd
next prev parent reply other threads:[~2017-06-12 8:24 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-06 11:04 [Qemu-devel] [PATCH 0/4] ui/opengl: add and use helper functions to handle framebuffers Gerd Hoffmann
2017-06-06 11:04 ` [Qemu-devel] [PATCH 1/4] egl-helpers: add helpers to handle opengl framebuffers Gerd Hoffmann
2017-06-07 19:16 ` Marc-André Lureau
2017-06-06 11:04 ` [Qemu-devel] [PATCH 2/4] egl-headless: use framebuffer helper functions Gerd Hoffmann
2017-06-07 21:02 ` Marc-André Lureau
2017-06-12 8:20 ` Gerd Hoffmann
2017-06-06 11:04 ` [Qemu-devel] [PATCH 3/4] sdl2: " Gerd Hoffmann
2017-06-08 7:11 ` Marc-André Lureau
2017-06-12 8:23 ` Gerd Hoffmann [this message]
2017-06-06 11:04 ` [Qemu-devel] [PATCH 4/4] gtk: " Gerd Hoffmann
-- strict thread matches above, loose matches on Subject: below --
2017-06-14 8:41 [Qemu-devel] [PATCH 0/4] ui/opengl: add and use helper functions to handle framebuffers Gerd Hoffmann
2017-06-14 8:41 ` [Qemu-devel] [PATCH 3/4] sdl2: use framebuffer helper functions Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1497255838.6334.6.camel@redhat.com \
--to=kraxel@redhat.com \
--cc=marcandre.lureau@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.