All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gerd Hoffmann <kraxel@redhat.com>
To: Igor Mammedov <imammedo@redhat.com>,
	Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Cc: qemu-devel@nongnu.org, rjones@redhat.com, pbonzini@redhat.com,
	somlo@cmu.edu, lersek@redhat.com, mst@redhat.com,
	ehabkost@redhat.com
Subject: Re: [Qemu-devel] [PATCH 3/6] fw_cfg: move setting of FW_CFG_ID into fw_cfg_init1()
Date: Mon, 12 Jun 2017 15:03:53 +0200	[thread overview]
Message-ID: <1497272633.30925.3.camel@redhat.com> (raw)
In-Reply-To: <20170612133740.2f3eef83@nial.brq.redhat.com>

On Mon, 2017-06-12 at 13:37 +0200, Igor Mammedov wrote:
> On Sat, 10 Jun 2017 13:30:18 +0100
> Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk> wrote:
> 
> > The dma_enabled property enables us to set the FW_CFG_ID version
> > accordingly.
> 
> it might be not safe as patch reorders FW_CFG_ID entry.
> 
> (I recall there were patches that sorted fwcfg entries,
> but it's worth checking that it won't break migration)
> 
> CCing Gerd, maybe he would recall how it works.

http://git.qemu.org/?p=qemu.git;a=blob;f=hw/nvram/fw_cfg.c;h=316fca9bc1
dadf8777ad9a9c238381702022bc56;hb=HEAD#l723

So, should be safe to shuffle around stuff.

cheers,
  Gerd

  parent reply	other threads:[~2017-06-12 13:04 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-10 12:30 [Qemu-devel] [PATCH 0/6] fw_cfg: qdev-related tidy-ups Mark Cave-Ayland
2017-06-10 12:30 ` [Qemu-devel] [PATCH 1/6] fw_cfg: move initialisation of FWCfgState into instance_init Mark Cave-Ayland
2017-06-10 18:05   ` Philippe Mathieu-Daudé
2017-06-12 11:20   ` Igor Mammedov
2017-06-12 11:45     ` Mark Cave-Ayland
2017-06-12 18:27       ` Laszlo Ersek
2017-06-12 18:46         ` Mark Cave-Ayland
2017-06-10 12:30 ` [Qemu-devel] [PATCH 2/6] fw_cfg: move qdev_init_nofail() out from fw_cfg_init1() into callers Mark Cave-Ayland
2017-06-12 11:43   ` Igor Mammedov
2017-06-12 11:54     ` Mark Cave-Ayland
2017-06-12 19:15       ` Laszlo Ersek
2017-06-12 19:50         ` Mark Cave-Ayland
2017-06-12 21:11           ` Mark Cave-Ayland
2017-06-10 12:30 ` [Qemu-devel] [PATCH 3/6] fw_cfg: move setting of FW_CFG_ID into fw_cfg_init1() Mark Cave-Ayland
2017-06-10 18:07   ` Philippe Mathieu-Daudé
2017-06-12 11:37   ` Igor Mammedov
2017-06-12 11:49     ` Mark Cave-Ayland
2017-06-12 13:03     ` Gerd Hoffmann [this message]
2017-06-10 12:30 ` [Qemu-devel] [PATCH 4/6] fw_cfg: move fw_cfg_init1() into the fw_cfg_*_realize() functions Mark Cave-Ayland
2017-06-12 12:03   ` Igor Mammedov
2017-06-10 12:30 ` [Qemu-devel] [PATCH 5/6] fw_cfg: use sysbus_init_mmio() in fw_cfg_io_realize() Mark Cave-Ayland
2017-06-12 12:16   ` Igor Mammedov
2017-06-12 12:59     ` Mark Cave-Ayland
2017-06-10 12:30 ` [Qemu-devel] [PATCH 6/6] fw_cfg: move QOM type defines into fw_cfg.h Mark Cave-Ayland
2017-06-10 17:43   ` Philippe Mathieu-Daudé
2017-06-10 18:15 ` [Qemu-devel] [PATCH 0/6] fw_cfg: qdev-related tidy-ups Philippe Mathieu-Daudé
2017-06-11 15:00   ` Mark Cave-Ayland

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1497272633.30925.3.camel@redhat.com \
    --to=kraxel@redhat.com \
    --cc=ehabkost@redhat.com \
    --cc=imammedo@redhat.com \
    --cc=lersek@redhat.com \
    --cc=mark.cave-ayland@ilande.co.uk \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=rjones@redhat.com \
    --cc=somlo@cmu.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.