From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752587AbdFMGDl (ORCPT ); Tue, 13 Jun 2017 02:03:41 -0400 Received: from smtprelay0212.hostedemail.com ([216.40.44.212]:40269 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752490AbdFMGDk (ORCPT ); Tue, 13 Jun 2017 02:03:40 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::,RULES_HIT:41:355:379:541:599:960:966:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2194:2196:2198:2199:2200:2201:2393:2559:2562:2828:3138:3139:3140:3141:3142:3352:3622:3866:3867:3871:4321:4385:4605:5007:6691:9108:10004:10400:10848:11026:11232:11657:11658:11914:12043:12048:12296:12438:12740:12760:12895:13069:13311:13357:13439:14659:14721:21080:21627:30054:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:1,LUA_SUMMARY:none X-HE-Tag: girl24_7702aaafccd36 X-Filterd-Recvd-Size: 2052 Message-ID: <1497333816.18751.9.camel@perches.com> Subject: Re: [PATCH v2 3/3] staging: rtl8188eu: Shorten lines over 80 chars From: Joe Perches To: Aviya Erenfeld , gregkh@linuxfoundation.org, goudapatilk@gmail.com, insafonov@gmail.com Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Date: Mon, 12 Jun 2017 23:03:36 -0700 In-Reply-To: <70808b1d-6494-ec20-ec6c-0ff26204ea99@gmail.com> References: <70808b1d-6494-ec20-ec6c-0ff26204ea99@gmail.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.22.6-1ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2017-06-13 at 08:52 +0300, Aviya Erenfeld wrote: > Shorten lines over 80 chars Most of these changes are not useful. Style nits if 80 columns are _really_ desired. > diff --git a/drivers/staging/rtl8188eu/core/rtw_sta_mgt.c b/drivers/staging/rtl8188eu/core/rtw_sta_mgt.c [] > @@ -157,7 +164,8 @@ u32 _rtw_free_sta_priv(struct sta_priv *pstapriv) > plist = plist->next; > > for (i = 0; i < 16; i++) { > - preorder_ctrl = &psta->recvreorder_ctrl[i]; > + preorder_ctrl = > + &psta->recvreorder_ctrl[i]; > del_timer_sync(&preorder_ctrl->reordering_ctrl_timer); This is harder to read. > @@ -453,14 +471,16 @@ u32 rtw_init_bcmc_stainfo(struct adapter *padapter) > { > struct sta_info *psta; > u32 res = _SUCCESS; > - unsigned char bcast_addr[ETH_ALEN] = {0xff, 0xff, 0xff, 0xff, 0xff, 0xff}; > + unsigned char bcast_addr[ETH_ALEN] = {0xff, 0xff, 0xff, 0xff, 0xff, > + 0xff}; More common would be unsigned char bcast_addr[ETH_ALEN] = { 0xff, 0xff, 0xff, 0xff, 0xff, 0xff }; Better still would be to use static const. Best would be to see if bcast_addr is needed at all.