From: "Lankhorst, Maarten" <maarten.lankhorst@intel.com>
To: "intel-gfx@lists.freedesktop.org"
<intel-gfx@lists.freedesktop.org>,
"Kumar, Mahesh1" <mahesh1.kumar@intel.com>
Cc: "Zanoni, Paulo R" <paulo.r.zanoni@intel.com>
Subject: Re: [PATCH 1/6] drm/i915: cleanup fixed-point wrappers naming
Date: Tue, 13 Jun 2017 07:38:29 +0000 [thread overview]
Message-ID: <1497339508.2330.3.camel@intel.com> (raw)
In-Reply-To: <20170613060450.16094-2-mahesh1.kumar@intel.com>
Mahesh Kumar schreef op di 13-06-2017 om 11:34 [+0530]:
> This patch make naming of fixed-point wrappers consistent
> operation_<any_post_operation>_<1st operand>_<2nd operand>
> also shorten the name for fixed_16_16 to fixed16
>
> s/u32_to_fixed_16_16/u32_to_fixed16
> s/fixed_16_16_to_u32/fixed16_to_u32
> s/fixed_16_16_to_u32_round_up/fixed16_to_u32_round_up
> s/min_fixed_16_16/min_fixed16
> s/max_fixed_16_16/max_fixed16
> s/mul_u32_fixed_16_16/mul_u32_fixed16
>
> always do division internal operation in 64 bits:
> s/fixed_16_16_div/div_fixed16
> s/fixed_16_16_div_64/div_fixed16
>
> Introduce Addition wrappers for fixed16
> add_fixed16 : takes 2 fixed_16_16_t variable & returns fixed16_16_t
> add_fixed16_u32 : takes fixed_16_16_t & u32 variable & returns
> fixed16_16_t
I think to make it readable, the additions should be done separately.
mul_round_up_u32_fixed16 seems like it should use clamp_u64_to_fixed16,
perhaps others too. Maybe do it as a preparation patch so this patch
strictly does the renaming for review?
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-06-13 7:38 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-13 6:04 [PATCH 0/6] Fixed16.16 wrapper cleanup & wm optimization Mahesh Kumar
2017-06-13 6:04 ` [PATCH 1/6] drm/i915: cleanup fixed-point wrappers naming Mahesh Kumar
2017-06-13 7:38 ` Lankhorst, Maarten [this message]
2017-06-13 7:49 ` Mahesh Kumar
2017-06-13 9:37 ` Mahesh Kumar
2017-06-13 6:04 ` [PATCH 2/6] drm/i915/hsw: use intel_compute_linetime_wm function for linetime wm Mahesh Kumar
2017-06-13 7:30 ` Lankhorst, Maarten
2017-06-13 7:48 ` Mahesh Kumar
2017-06-13 13:12 ` Ville Syrjälä
2017-06-13 13:50 ` Mahesh Kumar
2017-06-13 6:04 ` [PATCH 3/6] drm/i915/skl+: WM calculation don't require height Mahesh Kumar
2017-06-13 6:04 ` [PATCH 4/6] drm/i915/skl+: unify cpp value in WM calculation Mahesh Kumar
2017-06-13 6:04 ` [PATCH 5/6] drm/i915/skl+: Optimize " Mahesh Kumar
2017-06-13 6:04 ` [PATCH 6/6] drm/i915/gen10: Calculate and enable transition WM Mahesh Kumar
2017-06-13 9:29 ` Lankhorst, Maarten
2017-06-13 9:44 ` Mahesh Kumar
2017-06-13 6:17 ` ✓ Fi.CI.BAT: success for Fixed16.16 wrapper cleanup & wm optimization Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1497339508.2330.3.camel@intel.com \
--to=maarten.lankhorst@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=mahesh1.kumar@intel.com \
--cc=paulo.r.zanoni@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.