All of lore.kernel.org
 help / color / mirror / Atom feed
From: Davide Caratti <dcaratti@redhat.com>
To: Michael Ellerman <mpe@ellerman.id.au>, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH] powerpc/configs: fix default values for NF_CT_PROTO_*
Date: Tue, 13 Jun 2017 14:21:09 +0200	[thread overview]
Message-ID: <1497356469.2604.18.camel@redhat.com> (raw)
In-Reply-To: <87lgowgo2f.fsf@concordia.ellerman.id.au>

On Tue, 2017-06-13 at 20:49 +1000, Michael Ellerman wrote:
> Davide Caratti <dcaratti@redhat.com> writes:
> 
> > NF_CT_PROTO_{SCTP,UDPLITE,DCCP} can't be set to 'm' anymore, since they
> > have been redefined as 'bool': fix defconfig for linkstation, mvme5100 and
> > ppc6xx platforms accordingly.
> 
> Since when? ie. which commit changed the symbols to bool from tristate?
> 
> cheers

hello Michael,

the commits are:

a85406afeb3e ("netfilter: conntrack: built-in support for SCTP")
c51d39010a1b ("netfilter: conntrack: built-in support for DCCP")
9b91c96c5d1f ("netfilter: conntrack: built-in support for UDPlite")

they were causing a "warning symbol value 'm' invalid" in kconfig: sorry
for not noticing this before. I see that ARM and MIPS already have a fix:

5aff1d245e8c ("ARM: defconfigs: make NF_CT_PROTO_SCTP and
NF_CT_PROTO_UDPLITE built-in")
9ddc16ad8e0b ("MIPS: Update defconfigs for NF_CT_PROTO_DCCP/UDPLITE
change")

but (some) ppc and tile defconfig were still missing the correction:
that's why I submitted this patch (and a similar one, http://www.mail-arch
ive.com/linux-kernel@vger.kernel.org/msg1413473.html , for tile).

thank you for looking at this,
regards
--
davide

  reply	other threads:[~2017-06-13 12:21 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-05 14:22 [PATCH] powerpc/configs: fix default values for NF_CT_PROTO_* Davide Caratti
2017-06-13 10:49 ` Michael Ellerman
2017-06-13 12:21   ` Davide Caratti [this message]
2017-06-14 11:44     ` Michael Ellerman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1497356469.2604.18.camel@redhat.com \
    --to=dcaratti@redhat.com \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=mpe@ellerman.id.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.