From: Johannes Berg <johannes@sipsolutions.net>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: yuan linyu <cugyly@163.com>,
netdev@vger.kernel.org, "David S . Miller" <davem@davemloft.net>,
yuan linyu <Linyu.Yuan@alcatel-sbell.com.cn>
Subject: Re: [PATCH net-next 01/11] ipv6: skb_put_zero() used to optimize code
Date: Wed, 14 Jun 2017 21:51:23 +0200 [thread overview]
Message-ID: <1497469883.9377.6.camel@sipsolutions.net> (raw)
In-Reply-To: <20170614121416.63a78b0d@xeon-e3> (sfid-20170614_211424_579385_35B01873)
On Wed, 2017-06-14 at 12:14 -0700, Stephen Hemminger wrote:
>
> > I just copied it from skb_put() - you could ask the same there? :)
>
> My taste is to have less casts. Never understood why so many skb_
> functions returned char *, probably a leftover from older Unix style.
I agree, for many of them it's awkward and I often just put a (void *)
cast in there ...
I guess we can just make them void, and if anyone wants it I can easily
cook up an spatch to remove casts.
johannes
prev parent reply other threads:[~2017-06-14 19:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-14 14:37 [PATCH net-next 01/11] ipv6: skb_put_zero() used to optimize code yuan linyu
2017-06-14 15:44 ` Stephen Hemminger
2017-06-14 19:01 ` Johannes Berg
2017-06-14 19:14 ` Stephen Hemminger
2017-06-14 19:51 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1497469883.9377.6.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=Linyu.Yuan@alcatel-sbell.com.cn \
--cc=cugyly@163.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.