From: Johannes Berg <johannes@sipsolutions.net>
To: YUAN Linyu <Linyu.Yuan@alcatel-sbell.com.cn>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [RFC] networking: convert many more places to skb_put_zero()
Date: Thu, 15 Jun 2017 09:45:17 +0200 [thread overview]
Message-ID: <1497512717.2518.5.camel@sipsolutions.net> (raw)
In-Reply-To: <8729016553E3654398EA69218DA29EEF15BC8F15@cnshjmbx02>
On Thu, 2017-06-15 at 07:20 +0000, YUAN Linyu wrote:
> >
> In my opinion if spatch can do it even it found one place, keep it.
> Only leave difficult places like ndisc.c to me.
It's not so simple - I'd have to tailor the spatch to it pretty much I
guess, spending far more time on the spatch than the single place
warrants.
> > Btw, just made a patch to add and use "skb_put_data()", just doing
> > a
> > memcpy() into the skb_put() area also has lots of users.
>
> Yes, I also notice some places.
I sent a patch.
johannes
next prev parent reply other threads:[~2017-06-15 7:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-14 20:17 [RFC] networking: convert many more places to skb_put_zero() Johannes Berg
2017-06-15 0:23 ` YUAN Linyu
2017-06-15 6:57 ` Johannes Berg
2017-06-15 7:05 ` YUAN Linyu
2017-06-15 7:11 ` Johannes Berg
2017-06-15 7:20 ` YUAN Linyu
2017-06-15 7:45 ` Johannes Berg [this message]
2017-06-15 7:47 ` YUAN Linyu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1497512717.2518.5.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=Linyu.Yuan@alcatel-sbell.com.cn \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.