From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gerd Hoffmann Subject: Re: [PATCH v9 5/7] vfio: Define vfio based dma-buf operations Date: Thu, 15 Jun 2017 18:00:38 +0200 Message-ID: <1497542438.29252.1.camel@redhat.com> References: <1497513611-2814-1-git-send-email-xiaoguang.chen@intel.com> <1497513611-2814-6-git-send-email-xiaoguang.chen@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Kirti Wankhede , Xiaoguang Chen , alex.williamson@redhat.com, chris@chris-wilson.co.uk, intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, zhenyuw@linux.intel.com, zhiyuan.lv@intel.com, intel-gvt-dev@lists.freedesktop.org, zhi.a.wang@intel.com, kevin.tian@intel.com List-Id: intel-gfx@lists.freedesktop.org ICBIaSwKCj4gPiArc3RydWN0IHZmaW9fZG1hYnVmX21ncl9wbGFuZV9pbmZvIHsKPiA+ICsJX191 NjQgc3RhcnQ7Cj4gPiArCV9fdTY0IGRybV9mb3JtYXRfbW9kOwo+ID4gKwlfX3UzMiBkcm1fZm9y bWF0Owo+ID4gKwlfX3UzMiB3aWR0aDsKPiA+ICsJX191MzIgaGVpZ2h0Owo+ID4gKwlfX3UzMiBz dHJpZGU7Cj4gPiArCV9fdTMyIHNpemU7Cj4gPiArCV9fdTMyIHhfcG9zOwo+ID4gKwlfX3UzMiB5 X3BvczsKPiA+ICsJX191MzIgcGFkZGluZzsKPiA+ICt9Owo+ID4gKwo+IAo+IFRoaXMgc3RydWN0 dXJlIGlzIGdlbmVyaWMsIGNhbiByZW1vdmUgZG1hYnVmIGZyb20gaXRzIG5hbWUsCj4gdmZpb19w bGFuZV9pbmZvIG9yIHZmaW9fdmdwdV9zdXJmYWNlX2luZm8gc2luY2UgdGhpcyB3aWxsIG9ubHkg YmUKPiB1c2VkCj4gYnkgdmdwdS4KCkFncmVlLgoKPiA+ICtzdHJ1Y3QgdmZpb19kbWFidWZfbWdy X3F1ZXJ5X3BsYW5lIHsKPiA+ICsJX191MzIgYXJnc3o7Cj4gPiArCV9fdTMyIGZsYWdzOwo+ID4g KwlzdHJ1Y3QgdmZpb19kbWFidWZfbWdyX3BsYW5lX2luZm8gcGxhbmVfaW5mbzsKPiA+ICsJX191 MzIgcGxhbmVfaWQ7Cj4gPiArfTsKPiA+ICsKPiA+ICsjZGVmaW5lIFZGSU9fRE1BQlVGX01HUl9R VUVSWV9QTEFORSBfSU8oVkZJT19UWVBFLCBWRklPX0JBU0UgKyAxNSkKPiA+ICsKPiAKPiBUaGlz IHNhbWUgaW50ZXJmYWNlIGNhbiBiZSB1c2VkIHRvIHF1ZXJ5IHN1cmZhY2UvcGxhbmUgaW5mb3Jt YXRpb24KPiBmb3IKPiBib3RoLCBkbWFidWYgYW5kIHJlZ2lvbiwgY2FzZS4gSGVyZSBhbHNvICdE TUFCVUYnIGNhbiBiZSByZW1vdmVkIGFuZAo+IGRlZmluZSBmbGFncyBpZiB5b3Ugd2FudCB0byBk aWZmZXJlbnRpYXRlIHF1ZXJ5IGZvciAnZG1hYnVmJyBhbmQKPiAncmVnaW9uJy4KCkhtbSwgYW55 IHNwZWNpZmljIHJlYXNvbiB3aHkgeW91IHdhbnQgdXNlIGEgaW9jdGwgZm9yIHRoYXQ/ICBJIHdv dWxkCnNpbXBseSBwbGFjZSBhICJzdHJ1Y3QgdmZpb19kbWFidWZfbWdyX3BsYW5lX2luZm8iIChv ciB3aGF0ZXZlciB0aGUKZmluYWwgbmFtZSB3aWxsIGJlKSBhdCB0aGUgc3RhcnQgb2YgdGhlIHJl Z2lvbi4KCmNoZWVycywKICBHZXJkCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVl ZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5m by9pbnRlbC1nZngK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752121AbdFOQAm (ORCPT ); Thu, 15 Jun 2017 12:00:42 -0400 Received: from mx1.redhat.com ([209.132.183.28]:5694 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751979AbdFOQAl (ORCPT ); Thu, 15 Jun 2017 12:00:41 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 6AB7DC04B326 Authentication-Results: ext-mx07.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx07.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=kraxel@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 6AB7DC04B326 Message-ID: <1497542438.29252.1.camel@redhat.com> Subject: Re: [PATCH v9 5/7] vfio: Define vfio based dma-buf operations From: Gerd Hoffmann To: Kirti Wankhede , Xiaoguang Chen , alex.williamson@redhat.com, chris@chris-wilson.co.uk, intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, zhenyuw@linux.intel.com, zhiyuan.lv@intel.com, intel-gvt-dev@lists.freedesktop.org, zhi.a.wang@intel.com, kevin.tian@intel.com Date: Thu, 15 Jun 2017 18:00:38 +0200 In-Reply-To: References: <1497513611-2814-1-git-send-email-xiaoguang.chen@intel.com> <1497513611-2814-6-git-send-email-xiaoguang.chen@intel.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Thu, 15 Jun 2017 16:00:40 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, > > +struct vfio_dmabuf_mgr_plane_info { > > + __u64 start; > > + __u64 drm_format_mod; > > + __u32 drm_format; > > + __u32 width; > > + __u32 height; > > + __u32 stride; > > + __u32 size; > > + __u32 x_pos; > > + __u32 y_pos; > > + __u32 padding; > > +}; > > + > > This structure is generic, can remove dmabuf from its name, > vfio_plane_info or vfio_vgpu_surface_info since this will only be > used > by vgpu. Agree. > > +struct vfio_dmabuf_mgr_query_plane { > > + __u32 argsz; > > + __u32 flags; > > + struct vfio_dmabuf_mgr_plane_info plane_info; > > + __u32 plane_id; > > +}; > > + > > +#define VFIO_DMABUF_MGR_QUERY_PLANE _IO(VFIO_TYPE, VFIO_BASE + 15) > > + > > This same interface can be used to query surface/plane information > for > both, dmabuf and region, case. Here also 'DMABUF' can be removed and > define flags if you want to differentiate query for 'dmabuf' and > 'region'. Hmm, any specific reason why you want use a ioctl for that? I would simply place a "struct vfio_dmabuf_mgr_plane_info" (or whatever the final name will be) at the start of the region. cheers, Gerd