From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mimi Zohar Date: Thu, 15 Jun 2017 16:00:56 +0000 Subject: Re: [PATCH v2 3/6] ima: Log the same audit cause whenever a file has no signature Message-Id: <1497542456.4287.57.camel@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="maccentraleurope" Content-Transfer-Encoding: base64 List-Id: References: <1496886555-10082-1-git-send-email-bauerman@linux.vnet.ibm.com> <1496886555-10082-4-git-send-email-bauerman@linux.vnet.ibm.com> In-Reply-To: <1496886555-10082-4-git-send-email-bauerman@linux.vnet.ibm.com> To: Thiago Jung Bauermann , linux-security-module@vger.kernel.org Cc: linux-ima-devel@lists.sourceforge.net, keyrings@vger.kernel.org, linux-crypto@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, Dmitry Kasatkin , James Morris , "Serge E. Hallyn" , David Howells , David Woodhouse , Jessica Yu , Rusty Russell , Herbert Xu , "David S. Miller" , "AKASHI, Takahiro" T24gV2VkLCAyMDE3LTA2LTA3IGF0IDIyOjQ5IC0wMzAwLCBUaGlhZ28gSnVuZyBCYXVlcm1hbm4g d3JvdGU6Cj4gSWYgdGhlIGZpbGUgZG9lc24ndCBoYXZlIGFuIHhhdHRyLCBpbWFfYXBwcmFpc2Vf bWVhc3VyZW1lbnQgc2V0cyBjYXVzZSB0bwo+ICJtaXNzaW5nLWhhc2giIHdoaWxlIGlmIHRoZXJl J3MgYW4geGF0dHIgYnV0IGl0J3MgYSBkaWdlc3QgaW5zdGVhZCBvZiBhCj4gc2lnbmF0dXJlIGl0 IHNldHMgY2F1c2UgdG8gIklNQS1zaWduYXR1cmUtcmVxdWlyZWQiLgo+IAo+IEZpeCBpdCBieSBz ZXR0aW5nIGNhdXNlIHRvICJJTUEtc2lnbmF0dXJlLXJlcXVpcmVkIiBpbiBib3RoIGNhc2VzLgo+ IAo+IFNpZ25lZC1vZmYtYnk6IFRoaWFnbyBKdW5nIEJhdWVybWFubiA8YmF1ZXJtYW5AbGludXgu dm5ldC5pYm0uY29tPgoKVGhhbmsgeW91LsKgwqBRdWV1ZWQgdG8gYmUgdXBzdHJlYW1lZC4KCk1p bWkKPiAtLS0KPiAgc2VjdXJpdHkvaW50ZWdyaXR5L2ltYS9pbWFfYXBwcmFpc2UuYyB8IDMgKyst Cj4gIDEgZmlsZSBjaGFuZ2VkLCAyIGluc2VydGlvbnMoKyksIDEgZGVsZXRpb24oLSkKPiAKPiBk aWZmIC0tZ2l0IGEvc2VjdXJpdHkvaW50ZWdyaXR5L2ltYS9pbWFfYXBwcmFpc2UuYyBiL3NlY3Vy aXR5L2ludGVncml0eS9pbWEvaW1hX2FwcHJhaXNlLmMKPiBpbmRleCBlYTM2YTRmMTM0ZjQuLjgw OWJhNzBmYmJiZiAxMDA2NDQKPiAtLS0gYS9zZWN1cml0eS9pbnRlZ3JpdHkvaW1hL2ltYV9hcHBy YWlzZS5jCj4gKysrIGIvc2VjdXJpdHkvaW50ZWdyaXR5L2ltYS9pbWFfYXBwcmFpc2UuYwo+IEBA IC0yMTcsNyArMjE3LDggQEAgaW50IGltYV9hcHByYWlzZV9tZWFzdXJlbWVudChlbnVtIGltYV9o b29rcyBmdW5jLAo+ICAJCWlmIChyYyAmJiByYyAhPSAtRU5PREFUQSkKPiAgCQkJZ290byBvdXQ7 Cj4gCj4gLQkJY2F1c2UgPSAibWlzc2luZy1oYXNoIjsKPiArCQljYXVzZSA9IGlpbnQtPmZsYWdz ICYgSU1BX0RJR1NJR19SRVFVSVJFRCA/Cj4gKwkJCQkiSU1BLXNpZ25hdHVyZS1yZXF1aXJlZCIg OiAibWlzc2luZy1oYXNoIjsKPiAgCQlzdGF0dXMgPSBJTlRFR1JJVFlfTk9MQUJFTDsKPiAgCQlp ZiAob3BlbmVkICYgRklMRV9DUkVBVEVEKQo+ICAJCQlpaW50LT5mbGFncyB8PSBJTUFfTkVXX0ZJ TEU7CgotLQpUbyB1bnN1YnNjcmliZSBmcm9tIHRoaXMgbGlzdDogc2VuZCB0aGUgbGluZSAidW5z dWJzY3JpYmUga2V5cmluZ3MiIGluCnRoZSBib2R5IG9mIGEgbWVzc2FnZSB0byBtYWpvcmRvbW9A dmdlci5rZXJuZWwub3JnCk1vcmUgbWFqb3Jkb21vIGluZm8gYXQgIGh0dHA6Ly92Z2VyLmtlcm5l bC5vcmcvbWFqb3Jkb21vLWluZm8uaHRtbA== From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mimi Zohar Subject: Re: [PATCH v2 3/6] ima: Log the same audit cause whenever a file has no signature Date: Thu, 15 Jun 2017 12:00:56 -0400 Message-ID: <1497542456.4287.57.camel@linux.vnet.ibm.com> References: <1496886555-10082-1-git-send-email-bauerman@linux.vnet.ibm.com> <1496886555-10082-4-git-send-email-bauerman@linux.vnet.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Cc: linux-ima-devel@lists.sourceforge.net, keyrings@vger.kernel.org, linux-crypto@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, Dmitry Kasatkin , James Morris , "Serge E. Hallyn" , David Howells , David Woodhouse , Jessica Yu , Rusty Russell , Herbert Xu , "David S. Miller" , "AKASHI, Takahiro" To: Thiago Jung Bauermann , linux-security-module@vger.kernel.org Return-path: Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:55130 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750830AbdFOQBd (ORCPT ); Thu, 15 Jun 2017 12:01:33 -0400 Received: from pps.filterd (m0098399.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.20/8.16.0.20) with SMTP id v5FFwoox096105 for ; Thu, 15 Jun 2017 12:01:33 -0400 Received: from e23smtp03.au.ibm.com (e23smtp03.au.ibm.com [202.81.31.145]) by mx0a-001b2d01.pphosted.com with ESMTP id 2b3vrwhxt0-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Thu, 15 Jun 2017 12:01:33 -0400 Received: from localhost by e23smtp03.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 16 Jun 2017 02:01:30 +1000 In-Reply-To: <1496886555-10082-4-git-send-email-bauerman@linux.vnet.ibm.com> Sender: linux-crypto-owner@vger.kernel.org List-ID: On Wed, 2017-06-07 at 22:49 -0300, Thiago Jung Bauermann wrote: > If the file doesn't have an xattr, ima_appraise_measurement sets cause to > "missing-hash" while if there's an xattr but it's a digest instead of a > signature it sets cause to "IMA-signature-required". > > Fix it by setting cause to "IMA-signature-required" in both cases. > > Signed-off-by: Thiago Jung Bauermann Thank you.  Queued to be upstreamed. Mimi > --- > security/integrity/ima/ima_appraise.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/security/integrity/ima/ima_appraise.c b/security/integrity/ima/ima_appraise.c > index ea36a4f134f4..809ba70fbbbf 100644 > --- a/security/integrity/ima/ima_appraise.c > +++ b/security/integrity/ima/ima_appraise.c > @@ -217,7 +217,8 @@ int ima_appraise_measurement(enum ima_hooks func, > if (rc && rc != -ENODATA) > goto out; > > - cause = "missing-hash"; > + cause = iint->flags & IMA_DIGSIG_REQUIRED ? > + "IMA-signature-required" : "missing-hash"; > status = INTEGRITY_NOLABEL; > if (opened & FILE_CREATED) > iint->flags |= IMA_NEW_FILE; From mboxrd@z Thu Jan 1 00:00:00 1970 From: zohar@linux.vnet.ibm.com (Mimi Zohar) Date: Thu, 15 Jun 2017 12:00:56 -0400 Subject: [PATCH v2 3/6] ima: Log the same audit cause whenever a file has no signature In-Reply-To: <1496886555-10082-4-git-send-email-bauerman@linux.vnet.ibm.com> References: <1496886555-10082-1-git-send-email-bauerman@linux.vnet.ibm.com> <1496886555-10082-4-git-send-email-bauerman@linux.vnet.ibm.com> Message-ID: <1497542456.4287.57.camel@linux.vnet.ibm.com> To: linux-security-module@vger.kernel.org List-Id: linux-security-module.vger.kernel.org On Wed, 2017-06-07 at 22:49 -0300, Thiago Jung Bauermann wrote: > If the file doesn't have an xattr, ima_appraise_measurement sets cause to > "missing-hash" while if there's an xattr but it's a digest instead of a > signature it sets cause to "IMA-signature-required". > > Fix it by setting cause to "IMA-signature-required" in both cases. > > Signed-off-by: Thiago Jung Bauermann Thank you.??Queued to be upstreamed. Mimi > --- > security/integrity/ima/ima_appraise.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/security/integrity/ima/ima_appraise.c b/security/integrity/ima/ima_appraise.c > index ea36a4f134f4..809ba70fbbbf 100644 > --- a/security/integrity/ima/ima_appraise.c > +++ b/security/integrity/ima/ima_appraise.c > @@ -217,7 +217,8 @@ int ima_appraise_measurement(enum ima_hooks func, > if (rc && rc != -ENODATA) > goto out; > > - cause = "missing-hash"; > + cause = iint->flags & IMA_DIGSIG_REQUIRED ? > + "IMA-signature-required" : "missing-hash"; > status = INTEGRITY_NOLABEL; > if (opened & FILE_CREATED) > iint->flags |= IMA_NEW_FILE; -- To unsubscribe from this list: send the line "unsubscribe linux-security-module" in the body of a message to majordomo at vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html